mbox series

[v2,00/37] net/mvpp2: misc updates

Message ID 20210122191925.24308-1-lironh@marvell.com (mailing list archive)
Headers show
Series net/mvpp2: misc updates | expand

Message

Liron Himi Jan. 22, 2021, 7:18 p.m. UTC
From: Liron Himi <lironh@marvell.com>

This patch series align the mainline driver with all changes since 19.11
some of the patches are fixes which should be pushed to stable

v2:
- fix commit msg styling
- Addressed various review comments

Dana Vardi (5):
  net/mvpp2: update start hdr name
  net/mvpp2: support custom header before ethernet
  net/mvpp2: forward bad packets support
  net/mvpp2: update qos defaults parameter name
  net/mvpp2: add fill buffs to configuration file

Liron Himi (20):
  net/mvpp2: remove debug log on fast-path
  net/mvpp2: skip VLAN flush
  net/mvpp2: remove CRC len from MRU validation
  net/mvpp2: fix frame size checking
  net/mvpp2: update Tx checksum
  net/mvpp2: add dsa mode support
  net/mvpp2: adjust the number of unicast address
  net/mvpp2: use generic name for the 'cfg'
  net/mvpp2: flow: support generic pattern combinations
  net/mvpp2: flow: build table key along with rule
  net/mvpp2: move common functions to common location
  net/mvpp2: flow: add support for RAW type
  net/mvpp2: skip qos init if not requested
  net/mvpp2: support udf configuration
  net/mvpp2: rearrange functions order
  net/mvpp2: introduce fixup for fifo overrun
  net/mvpp2: propagate port-id in udata64
  net/mvpp2: expose max MTU size
  net/mvpp2: apply flow-ctrl after port init
  net/mvpp2: consider ptype in cksum info

Meir Levi (1):
  net/mvpp2: add 2.5G LINK info

Yuri Chipchev (11):
  net/mvpp2: fix stack corruption
  net/mvpp2: fix Rx/Tx bytes statistics
  net/mvpp2: update RSS tables reservation
  net/mvpp2: extend xstats support
  net/mvpp2: cosmetic changes to cookie usage
  net/mvpp2: align checking order
  net/mvpp2: save initial configuration
  net/mvpp2: add loopback support
  net/mvpp2: add VLAN offload support
  net/mvpp2: add Tx flow control
  net/mvpp2: autoneg disable handling

 doc/guides/nics/mvpp2.rst       |    1 +
 drivers/net/mvpp2/mrvl_ethdev.c |  811 +++++++++++-----
 drivers/net/mvpp2/mrvl_ethdev.h |   84 +-
 drivers/net/mvpp2/mrvl_flow.c   | 1522 +++++++------------------------
 drivers/net/mvpp2/mrvl_qos.c    |  400 ++++++--
 drivers/net/mvpp2/mrvl_qos.h    |   21 +-
 6 files changed, 1341 insertions(+), 1498 deletions(-)

Comments

Jerin Jacob Jan. 25, 2021, 6 p.m. UTC | #1
On Sat, Jan 23, 2021 at 12:49 AM <lironh@marvell.com> wrote:
>
> From: Liron Himi <lironh@marvell.com>
>
> This patch series align the mainline driver with all changes since 19.11
> some of the patches are fixes which should be pushed to stable
>
> v2:
> - fix commit msg styling
> - Addressed various review comments


Series applied to dpdk-next-net-mrvl/for-main. Thanks.



>
> Dana Vardi (5):
>   net/mvpp2: update start hdr name
>   net/mvpp2: support custom header before ethernet
>   net/mvpp2: forward bad packets support
>   net/mvpp2: update qos defaults parameter name
>   net/mvpp2: add fill buffs to configuration file
>
> Liron Himi (20):
>   net/mvpp2: remove debug log on fast-path
>   net/mvpp2: skip VLAN flush
>   net/mvpp2: remove CRC len from MRU validation
>   net/mvpp2: fix frame size checking
>   net/mvpp2: update Tx checksum
>   net/mvpp2: add dsa mode support
>   net/mvpp2: adjust the number of unicast address
>   net/mvpp2: use generic name for the 'cfg'
>   net/mvpp2: flow: support generic pattern combinations
>   net/mvpp2: flow: build table key along with rule
>   net/mvpp2: move common functions to common location
>   net/mvpp2: flow: add support for RAW type
>   net/mvpp2: skip qos init if not requested
>   net/mvpp2: support udf configuration
>   net/mvpp2: rearrange functions order
>   net/mvpp2: introduce fixup for fifo overrun
>   net/mvpp2: propagate port-id in udata64
>   net/mvpp2: expose max MTU size
>   net/mvpp2: apply flow-ctrl after port init
>   net/mvpp2: consider ptype in cksum info
>
> Meir Levi (1):
>   net/mvpp2: add 2.5G LINK info
>
> Yuri Chipchev (11):
>   net/mvpp2: fix stack corruption
>   net/mvpp2: fix Rx/Tx bytes statistics
>   net/mvpp2: update RSS tables reservation
>   net/mvpp2: extend xstats support
>   net/mvpp2: cosmetic changes to cookie usage
>   net/mvpp2: align checking order
>   net/mvpp2: save initial configuration
>   net/mvpp2: add loopback support
>   net/mvpp2: add VLAN offload support
>   net/mvpp2: add Tx flow control
>   net/mvpp2: autoneg disable handling
>
>  doc/guides/nics/mvpp2.rst       |    1 +
>  drivers/net/mvpp2/mrvl_ethdev.c |  811 +++++++++++-----
>  drivers/net/mvpp2/mrvl_ethdev.h |   84 +-
>  drivers/net/mvpp2/mrvl_flow.c   | 1522 +++++++------------------------
>  drivers/net/mvpp2/mrvl_qos.c    |  400 ++++++--
>  drivers/net/mvpp2/mrvl_qos.h    |   21 +-
>  6 files changed, 1341 insertions(+), 1498 deletions(-)
>
> --
> 2.28.0
>
Ferruh Yigit Jan. 26, 2021, 4:58 p.m. UTC | #2
On 1/25/2021 6:00 PM, Jerin Jacob wrote:
> On Sat, Jan 23, 2021 at 12:49 AM <lironh@marvell.com> wrote:
>>
>> From: Liron Himi <lironh@marvell.com>
>>
>> This patch series align the mainline driver with all changes since 19.11
>> some of the patches are fixes which should be pushed to stable
>>
>> v2:
>> - fix commit msg styling
>> - Addressed various review comments
> 
> 
> Series applied to dpdk-next-net-mrvl/for-main. Thanks.
> 

There were multiple review tag from "Michael Shamis <michaelsh@marvell.com>" to 
the first version, tags seems not carried to v2, should we add them to v2?

> 
>>
>> Dana Vardi (5):
>>    net/mvpp2: update start hdr name
>>    net/mvpp2: support custom header before ethernet
>>    net/mvpp2: forward bad packets support
>>    net/mvpp2: update qos defaults parameter name
>>    net/mvpp2: add fill buffs to configuration file
>>
>> Liron Himi (20):
>>    net/mvpp2: remove debug log on fast-path
>>    net/mvpp2: skip VLAN flush
>>    net/mvpp2: remove CRC len from MRU validation
>>    net/mvpp2: fix frame size checking
>>    net/mvpp2: update Tx checksum
>>    net/mvpp2: add dsa mode support
>>    net/mvpp2: adjust the number of unicast address
>>    net/mvpp2: use generic name for the 'cfg'
>>    net/mvpp2: flow: support generic pattern combinations
>>    net/mvpp2: flow: build table key along with rule
>>    net/mvpp2: move common functions to common location
>>    net/mvpp2: flow: add support for RAW type
>>    net/mvpp2: skip qos init if not requested
>>    net/mvpp2: support udf configuration
>>    net/mvpp2: rearrange functions order
>>    net/mvpp2: introduce fixup for fifo overrun
>>    net/mvpp2: propagate port-id in udata64
>>    net/mvpp2: expose max MTU size
>>    net/mvpp2: apply flow-ctrl after port init
>>    net/mvpp2: consider ptype in cksum info
>>
>> Meir Levi (1):
>>    net/mvpp2: add 2.5G LINK info
>>
>> Yuri Chipchev (11):
>>    net/mvpp2: fix stack corruption
>>    net/mvpp2: fix Rx/Tx bytes statistics
>>    net/mvpp2: update RSS tables reservation
>>    net/mvpp2: extend xstats support
>>    net/mvpp2: cosmetic changes to cookie usage
>>    net/mvpp2: align checking order
>>    net/mvpp2: save initial configuration
>>    net/mvpp2: add loopback support
>>    net/mvpp2: add VLAN offload support
>>    net/mvpp2: add Tx flow control
>>    net/mvpp2: autoneg disable handling
>>
>>   doc/guides/nics/mvpp2.rst       |    1 +
>>   drivers/net/mvpp2/mrvl_ethdev.c |  811 +++++++++++-----
>>   drivers/net/mvpp2/mrvl_ethdev.h |   84 +-
>>   drivers/net/mvpp2/mrvl_flow.c   | 1522 +++++++------------------------
>>   drivers/net/mvpp2/mrvl_qos.c    |  400 ++++++--
>>   drivers/net/mvpp2/mrvl_qos.h    |   21 +-
>>   6 files changed, 1341 insertions(+), 1498 deletions(-)
>>
>> --
>> 2.28.0
>>
Liron Himi Jan. 26, 2021, 6:07 p.m. UTC | #3
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com> 
Sent: Tuesday, 26 January 2021 18:59
To: Jerin Jacob <jerinjacobk@gmail.com>; Liron Himi <lironh@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; dpdk-dev <dev@dpdk.org>; Michael Shamis <michaelsh@marvell.com>
Subject: [EXT] Re: [dpdk-dev] [PATCH v2 00/37] net/mvpp2: misc updates

External Email

----------------------------------------------------------------------
On 1/25/2021 6:00 PM, Jerin Jacob wrote:
> On Sat, Jan 23, 2021 at 12:49 AM <lironh@marvell.com> wrote:
>>
>> From: Liron Himi <lironh@marvell.com>
>>
>> This patch series align the mainline driver with all changes since 
>> 19.11 some of the patches are fixes which should be pushed to stable
>>
>> v2:
>> - fix commit msg styling
>> - Addressed various review comments
> 
> 
> Series applied to dpdk-next-net-mrvl/for-main. Thanks.
> 

There were multiple review tag from "Michael Shamis <michaelsh@marvell.com>" to the first version, tags seems not carried to v2, should we add them to v2?
[L.H.] is this done automatically? If yes, lets add them. 

> 
>>
>> Dana Vardi (5):
>>    net/mvpp2: update start hdr name
>>    net/mvpp2: support custom header before ethernet
>>    net/mvpp2: forward bad packets support
>>    net/mvpp2: update qos defaults parameter name
>>    net/mvpp2: add fill buffs to configuration file
>>
>> Liron Himi (20):
>>    net/mvpp2: remove debug log on fast-path
>>    net/mvpp2: skip VLAN flush
>>    net/mvpp2: remove CRC len from MRU validation
>>    net/mvpp2: fix frame size checking
>>    net/mvpp2: update Tx checksum
>>    net/mvpp2: add dsa mode support
>>    net/mvpp2: adjust the number of unicast address
>>    net/mvpp2: use generic name for the 'cfg'
>>    net/mvpp2: flow: support generic pattern combinations
>>    net/mvpp2: flow: build table key along with rule
>>    net/mvpp2: move common functions to common location
>>    net/mvpp2: flow: add support for RAW type
>>    net/mvpp2: skip qos init if not requested
>>    net/mvpp2: support udf configuration
>>    net/mvpp2: rearrange functions order
>>    net/mvpp2: introduce fixup for fifo overrun
>>    net/mvpp2: propagate port-id in udata64
>>    net/mvpp2: expose max MTU size
>>    net/mvpp2: apply flow-ctrl after port init
>>    net/mvpp2: consider ptype in cksum info
>>
>> Meir Levi (1):
>>    net/mvpp2: add 2.5G LINK info
>>
>> Yuri Chipchev (11):
>>    net/mvpp2: fix stack corruption
>>    net/mvpp2: fix Rx/Tx bytes statistics
>>    net/mvpp2: update RSS tables reservation
>>    net/mvpp2: extend xstats support
>>    net/mvpp2: cosmetic changes to cookie usage
>>    net/mvpp2: align checking order
>>    net/mvpp2: save initial configuration
>>    net/mvpp2: add loopback support
>>    net/mvpp2: add VLAN offload support
>>    net/mvpp2: add Tx flow control
>>    net/mvpp2: autoneg disable handling
>>
>>   doc/guides/nics/mvpp2.rst       |    1 +
>>   drivers/net/mvpp2/mrvl_ethdev.c |  811 +++++++++++-----
>>   drivers/net/mvpp2/mrvl_ethdev.h |   84 +-
>>   drivers/net/mvpp2/mrvl_flow.c   | 1522 +++++++------------------------
>>   drivers/net/mvpp2/mrvl_qos.c    |  400 ++++++--
>>   drivers/net/mvpp2/mrvl_qos.h    |   21 +-
>>   6 files changed, 1341 insertions(+), 1498 deletions(-)
>>
>> --
>> 2.28.0
>>
Ferruh Yigit Jan. 26, 2021, 11:46 p.m. UTC | #4
On 1/26/2021 6:07 PM, Liron Himi wrote:
> 
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, 26 January 2021 18:59
> To: Jerin Jacob <jerinjacobk@gmail.com>; Liron Himi <lironh@marvell.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; dpdk-dev <dev@dpdk.org>; Michael Shamis <michaelsh@marvell.com>
> Subject: [EXT] Re: [dpdk-dev] [PATCH v2 00/37] net/mvpp2: misc updates
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 1/25/2021 6:00 PM, Jerin Jacob wrote:
>> On Sat, Jan 23, 2021 at 12:49 AM <lironh@marvell.com> wrote:
>>>
>>> From: Liron Himi <lironh@marvell.com>
>>>
>>> This patch series align the mainline driver with all changes since
>>> 19.11 some of the patches are fixes which should be pushed to stable
>>>
>>> v2:
>>> - fix commit msg styling
>>> - Addressed various review comments
>>
>>
>> Series applied to dpdk-next-net-mrvl/for-main. Thanks.
>>
> 
> There were multiple review tag from "Michael Shamis <michaelsh@marvell.com>" to the first version, tags seems not carried to v2, should we add them to v2?
> [L.H.] is this done automatically? If yes, lets add them.
> 

No, not manually unfortunately, but I can do it if this is requested.

>>
>>>
>>> Dana Vardi (5):
>>>     net/mvpp2: update start hdr name
>>>     net/mvpp2: support custom header before ethernet
>>>     net/mvpp2: forward bad packets support
>>>     net/mvpp2: update qos defaults parameter name
>>>     net/mvpp2: add fill buffs to configuration file
>>>
>>> Liron Himi (20):
>>>     net/mvpp2: remove debug log on fast-path
>>>     net/mvpp2: skip VLAN flush
>>>     net/mvpp2: remove CRC len from MRU validation
>>>     net/mvpp2: fix frame size checking
>>>     net/mvpp2: update Tx checksum
>>>     net/mvpp2: add dsa mode support
>>>     net/mvpp2: adjust the number of unicast address
>>>     net/mvpp2: use generic name for the 'cfg'
>>>     net/mvpp2: flow: support generic pattern combinations
>>>     net/mvpp2: flow: build table key along with rule
>>>     net/mvpp2: move common functions to common location
>>>     net/mvpp2: flow: add support for RAW type
>>>     net/mvpp2: skip qos init if not requested
>>>     net/mvpp2: support udf configuration
>>>     net/mvpp2: rearrange functions order
>>>     net/mvpp2: introduce fixup for fifo overrun
>>>     net/mvpp2: propagate port-id in udata64
>>>     net/mvpp2: expose max MTU size
>>>     net/mvpp2: apply flow-ctrl after port init
>>>     net/mvpp2: consider ptype in cksum info
>>>
>>> Meir Levi (1):
>>>     net/mvpp2: add 2.5G LINK info
>>>
>>> Yuri Chipchev (11):
>>>     net/mvpp2: fix stack corruption
>>>     net/mvpp2: fix Rx/Tx bytes statistics
>>>     net/mvpp2: update RSS tables reservation
>>>     net/mvpp2: extend xstats support
>>>     net/mvpp2: cosmetic changes to cookie usage
>>>     net/mvpp2: align checking order
>>>     net/mvpp2: save initial configuration
>>>     net/mvpp2: add loopback support
>>>     net/mvpp2: add VLAN offload support
>>>     net/mvpp2: add Tx flow control
>>>     net/mvpp2: autoneg disable handling
>>>
>>>    doc/guides/nics/mvpp2.rst       |    1 +
>>>    drivers/net/mvpp2/mrvl_ethdev.c |  811 +++++++++++-----
>>>    drivers/net/mvpp2/mrvl_ethdev.h |   84 +-
>>>    drivers/net/mvpp2/mrvl_flow.c   | 1522 +++++++------------------------
>>>    drivers/net/mvpp2/mrvl_qos.c    |  400 ++++++--
>>>    drivers/net/mvpp2/mrvl_qos.h    |   21 +-
>>>    6 files changed, 1341 insertions(+), 1498 deletions(-)
>>>
>>> --
>>> 2.28.0
>>>
>
Ferruh Yigit Jan. 27, 2021, 12:45 a.m. UTC | #5
On 1/25/2021 6:00 PM, Jerin Jacob wrote:
> On Sat, Jan 23, 2021 at 12:49 AM <lironh@marvell.com> wrote:
>>
>> From: Liron Himi <lironh@marvell.com>
>>
>> This patch series align the mainline driver with all changes since 19.11
>> some of the patches are fixes which should be pushed to stable
>>
>> v2:
>> - fix commit msg styling
>> - Addressed various review comments
> 
> 
> Series applied to dpdk-next-net-mrvl/for-main. Thanks.
> 
> 

I tried to partially get the set, but the refactoring and the function 
rearrangements in the middle is not helping.

Specially I tried to remove all config file patches because of missing 
documentation, but those also spread in the set.

It would be safer to get a new version of the set. Can you please send a new 
version of the set with updates?

Thanks,
ferruh

> 
>>
>> Dana Vardi (5):
>>    net/mvpp2: update start hdr name
>>    net/mvpp2: support custom header before ethernet
>>    net/mvpp2: forward bad packets support
>>    net/mvpp2: update qos defaults parameter name
>>    net/mvpp2: add fill buffs to configuration file
>>
>> Liron Himi (20):
>>    net/mvpp2: remove debug log on fast-path
>>    net/mvpp2: skip VLAN flush
>>    net/mvpp2: remove CRC len from MRU validation
>>    net/mvpp2: fix frame size checking
>>    net/mvpp2: update Tx checksum
>>    net/mvpp2: add dsa mode support
>>    net/mvpp2: adjust the number of unicast address
>>    net/mvpp2: use generic name for the 'cfg'
>>    net/mvpp2: flow: support generic pattern combinations
>>    net/mvpp2: flow: build table key along with rule
>>    net/mvpp2: move common functions to common location
>>    net/mvpp2: flow: add support for RAW type
>>    net/mvpp2: skip qos init if not requested
>>    net/mvpp2: support udf configuration
>>    net/mvpp2: rearrange functions order
>>    net/mvpp2: introduce fixup for fifo overrun
>>    net/mvpp2: propagate port-id in udata64
>>    net/mvpp2: expose max MTU size
>>    net/mvpp2: apply flow-ctrl after port init
>>    net/mvpp2: consider ptype in cksum info
>>
>> Meir Levi (1):
>>    net/mvpp2: add 2.5G LINK info
>>
>> Yuri Chipchev (11):
>>    net/mvpp2: fix stack corruption
>>    net/mvpp2: fix Rx/Tx bytes statistics
>>    net/mvpp2: update RSS tables reservation
>>    net/mvpp2: extend xstats support
>>    net/mvpp2: cosmetic changes to cookie usage
>>    net/mvpp2: align checking order
>>    net/mvpp2: save initial configuration
>>    net/mvpp2: add loopback support
>>    net/mvpp2: add VLAN offload support
>>    net/mvpp2: add Tx flow control
>>    net/mvpp2: autoneg disable handling
>>
>>   doc/guides/nics/mvpp2.rst       |    1 +
>>   drivers/net/mvpp2/mrvl_ethdev.c |  811 +++++++++++-----
>>   drivers/net/mvpp2/mrvl_ethdev.h |   84 +-
>>   drivers/net/mvpp2/mrvl_flow.c   | 1522 +++++++------------------------
>>   drivers/net/mvpp2/mrvl_qos.c    |  400 ++++++--
>>   drivers/net/mvpp2/mrvl_qos.h    |   21 +-
>>   6 files changed, 1341 insertions(+), 1498 deletions(-)
>>
>> --
>> 2.28.0
>>