mbox series

[v3,0/3] fix 'max-pkt-len' errors

Message ID 20210122090110.50453-1-stevex.yang@intel.com (mailing list archive)
Headers show
Series fix 'max-pkt-len' errors | expand

Message

Steve Yang Jan. 22, 2021, 9:01 a.m. UTC
Here fixed 3 issues for 'max-pkt-len':
1. When cmdline option '--max-pkt-len' set the value less then
   '1500 + overhead', the app/testpmd will force to resize the 'max-pkt-len'
   to '1500 + overhead'. However, the user really want to configure
   'max-pkt-len' to a specified value (< 1500 + overhead);

2. If the large value of '--max-pkt-len' gave (e.g.: 8000), and user want to
   reset the value to a small one (e.g.: 1400), it will became invalid due to
   JUMBO_FRAME offload state doesn't change before port started;

3. When rx/tx queue offloads capabilities aren't specified, the rx/tx queue
   setup will be failed once the port offloads changed.

---
v3:
 * rebased code to latest;
 * splited to 3 commits;

v2:
 * moved the update logic to 'rxtx_port_config';
 * added the 'tx_conf' part;
 * optimized the 'default' assignment;
---

Steve Yang (3):
  ethdev: fix MTU doesn't update when jumbo frame disabled
  app/testpmd: fix max-pkt-len option invalid
  app/testpmd: fix dynamic config error

 app/test-pmd/cmdline.c         |  1 +
 app/test-pmd/parameters.c      |  1 +
 app/test-pmd/testpmd.c         | 59 +++++++++++++++++++++++-----------
 app/test-pmd/testpmd.h         |  2 ++
 lib/librte_ethdev/rte_ethdev.c |  8 ++---
 5 files changed, 48 insertions(+), 23 deletions(-)