mbox series

[v2,0/4] lpm lookupx4 fixes

Message ID 20210114065926.1200855-1-ruifeng.wang@arm.com (mailing list archive)
Headers
Series lpm lookupx4 fixes |

Message

Ruifeng Wang Jan. 14, 2021, 6:59 a.m. UTC 
  This series fixed bug in lpm4 vector lookup implementations.
When more than 256 tbl8 groups are created, lookupx4 could
retrieve next hop data from wrong group.
The bug is there since next_hop field was expanded from
8-bit to 24-bit, and inherited by other implementations.

Also updated test case to improve coverage to detect such
failure.

Ruifeng Wang (4):
  lpm: fix vector lookup for Arm
  lpm: fix vector lookup for x86
  lpm: fix vector lookup for ppc64
  test/lpm: improve coverage on tbl8

 app/test/test_lpm.c              | 25 +++++++++++++++++--------
 lib/librte_lpm/rte_lpm_altivec.h |  8 ++++----
 lib/librte_lpm/rte_lpm_neon.h    |  8 ++++----
 lib/librte_lpm/rte_lpm_sse.h     |  8 ++++----
 4 files changed, 29 insertions(+), 20 deletions(-)

Comments

David Marchand Jan. 14, 2021, 3:25 p.m. UTC | #1 
On Thu, Jan 14, 2021 at 7:59 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote:
>
> This series fixed bug in lpm4 vector lookup implementations.
> When more than 256 tbl8 groups are created, lookupx4 could
> retrieve next hop data from wrong group.
> The bug is there since next_hop field was expanded from
> 8-bit to 24-bit, and inherited by other implementations.
>
> Also updated test case to improve coverage to detect such
> failure.
>
> Ruifeng Wang (4):
>   lpm: fix vector lookup for Arm
>   lpm: fix vector lookup for x86
>   lpm: fix vector lookup for ppc64
>   test/lpm: improve coverage on tbl8
>
>  app/test/test_lpm.c              | 25 +++++++++++++++++--------
>  lib/librte_lpm/rte_lpm_altivec.h |  8 ++++----
>  lib/librte_lpm/rte_lpm_neon.h    |  8 ++++----
>  lib/librte_lpm/rte_lpm_sse.h     |  8 ++++----
>  4 files changed, 29 insertions(+), 20 deletions(-)

Squashed patches 1-3 into one and applied the series, thanks.