mbox series

[v5,0/9] net/ionic: minor updates and documentation

Message ID 20201210025737.1057-1-aboyer@pensando.io (mailing list archive)
Headers
Series net/ionic: minor updates and documentation |

Message

Andrew Boyer Dec. 10, 2020, 2:57 a.m. UTC
  These patches make some minor changes to the ionic PMD.

Signed-off-by: Andrew Boyer <aboyer@pensando.io>

---
v5:
* Fix syntax error in .rst file

v4:
* Address additional reviewer comments

v3:
* Fixed up false-positives from codespell and gcc 8.3/9.3

v2:
* Address Ferruh's comments (thank you!)
* Switch to net/ionic: prefix
* Leave UNMAINTAINED flag for now
* Split patch 8 into patch 8 & 9; drop whitespace changes

Andrew Boyer (9):
  net/ionic: connect ionic to the build system
  net/ionic: update interface file to the latest version
  net/ionic: update documentation and MAINTAINERS
  net/ionic: check for cmd completion more frequently
  net/ionic: remove some unused fields
  net/ionic: convert 'deferred' boolean to a flag bit
  net/ionic: warn if loopback mode is requested
  net/ionic: minor refactorings and helper variables
  net/ionic: minor logging fixups

 MAINTAINERS                        |    2 +-
 doc/guides/nics/features/ionic.ini |    1 +
 doc/guides/nics/ionic.rst          |   13 +-
 drivers/net/ionic/ionic.h          |    2 +-
 drivers/net/ionic/ionic_dev.c      |   10 +-
 drivers/net/ionic/ionic_dev.h      |   13 +-
 drivers/net/ionic/ionic_ethdev.c   |    9 +-
 drivers/net/ionic/ionic_if.h       | 1343 +++++++++++++++++++---------
 drivers/net/ionic/ionic_lif.c      |   67 +-
 drivers/net/ionic/ionic_lif.h      |    4 +-
 drivers/net/ionic/ionic_main.c     |   86 +-
 drivers/net/ionic/ionic_osdep.h    |   10 -
 drivers/net/ionic/ionic_regs.h     |    9 -
 drivers/net/ionic/ionic_rxtx.c     |   51 +-
 drivers/net/meson.build            |    1 +
 15 files changed, 1061 insertions(+), 560 deletions(-)
  

Comments

Ferruh Yigit Dec. 10, 2020, 12:31 p.m. UTC | #1
On 12/10/2020 2:57 AM, Andrew Boyer wrote:
> These patches make some minor changes to the ionic PMD.
> 
> Signed-off-by: Andrew Boyer <aboyer@pensando.io>
> 
> ---
> v5:
> * Fix syntax error in .rst file
> 
> v4:
> * Address additional reviewer comments
> 
> v3:
> * Fixed up false-positives from codespell and gcc 8.3/9.3
> 
> v2:
> * Address Ferruh's comments (thank you!)
> * Switch to net/ionic: prefix
> * Leave UNMAINTAINED flag for now
> * Split patch 8 into patch 8 & 9; drop whitespace changes
> 
> Andrew Boyer (9):
>    net/ionic: connect ionic to the build system
>    net/ionic: update interface file to the latest version
>    net/ionic: update documentation and MAINTAINERS
>    net/ionic: check for cmd completion more frequently
>    net/ionic: remove some unused fields
>    net/ionic: convert 'deferred' boolean to a flag bit
>    net/ionic: warn if loopback mode is requested
>    net/ionic: minor refactorings and helper variables
>    net/ionic: minor logging fixups
> 

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied to dpdk-next-net/main, thanks.
  
Andrew Boyer Dec. 10, 2020, 2:44 p.m. UTC | #2
Ferruh,
'After sending a new version of a patch, developers should set the previous patch as “Superseded”.'

Did this happen automatically for v4 & friends or did you do it? (I did not). I will do it in future if it is not automatic.

'When a patch is applied, it is set to “Accepted”.'

Does that happen automatically, or do you want to do it, or can I help by doing it myself?
(Or do you wait until it reaches main?)

-Andrew

> On Dec 10, 2020, at 7:31 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> On 12/10/2020 2:57 AM, Andrew Boyer wrote:
>> These patches make some minor changes to the ionic PMD.
>> Signed-off-by: Andrew Boyer <aboyer@pensando.io>
>> ---
>> v5:
>> * Fix syntax error in .rst file
>> v4:
>> * Address additional reviewer comments
>> v3:
>> * Fixed up false-positives from codespell and gcc 8.3/9.3
>> v2:
>> * Address Ferruh's comments (thank you!)
>> * Switch to net/ionic: prefix
>> * Leave UNMAINTAINED flag for now
>> * Split patch 8 into patch 8 & 9; drop whitespace changes
>> Andrew Boyer (9):
>>   net/ionic: connect ionic to the build system
>>   net/ionic: update interface file to the latest version
>>   net/ionic: update documentation and MAINTAINERS
>>   net/ionic: check for cmd completion more frequently
>>   net/ionic: remove some unused fields
>>   net/ionic: convert 'deferred' boolean to a flag bit
>>   net/ionic: warn if loopback mode is requested
>>   net/ionic: minor refactorings and helper variables
>>   net/ionic: minor logging fixups
> 
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>>
> 
> Series applied to dpdk-next-net/main, thanks.
  
Ferruh Yigit Dec. 10, 2020, 3:06 p.m. UTC | #3
On 12/10/2020 2:44 PM, Andrew Boyer wrote:
> Ferruh,
> 'After sending a new version of a patch, developers should set the previous 
> patch as “Superseded”.'
> 
> Did this happen automatically for v4 & friends or did you do it? (I did not). I 
> will do it in future if it is not automatic.
> 
> 'When a patch is applied, it is set to “Accepted”.'
> 
> Does that happen automatically, or do you want to do it, or can I help by doing 
> it myself?
> (Or do you wait until it reaches main?)
> 

Patchwork updates are not automatic, all done manually.

When a new version of patch(set) is sent, author should update the status of the 
previous version as 'Superseded'.

When patch is merged, patchwork status set as 'Accepted' by committer, author 
doesn't need to do that.

If you think existing documentation is not clear enough, would you mind sending 
a web patch [1] to clarify it, this can help others too.

[1] https://git.dpdk.org/tools/dpdk-web/


> -Andrew
> 
>> On Dec 10, 2020, at 7:31 AM, Ferruh Yigit <ferruh.yigit@intel.com 
>> <mailto:ferruh.yigit@intel.com>> wrote:
>>
>> On 12/10/2020 2:57 AM, Andrew Boyer wrote:
>>> These patches make some minor changes to the ionic PMD.
>>> Signed-off-by: Andrew Boyer <aboyer@pensando.io <mailto:aboyer@pensando.io>>
>>> ---
>>> v5:
>>> * Fix syntax error in .rst file
>>> v4:
>>> * Address additional reviewer comments
>>> v3:
>>> * Fixed up false-positives from codespell and gcc 8.3/9.3
>>> v2:
>>> * Address Ferruh's comments (thank you!)
>>> * Switch to net/ionic: prefix
>>> * Leave UNMAINTAINED flag for now
>>> * Split patch 8 into patch 8 & 9; drop whitespace changes
>>> Andrew Boyer (9):
>>>   net/ionic: connect ionic to the build system
>>>   net/ionic: update interface file to the latest version
>>>   net/ionic: update documentation and MAINTAINERS
>>>   net/ionic: check for cmd completion more frequently
>>>   net/ionic: remove some unused fields
>>>   net/ionic: convert 'deferred' boolean to a flag bit
>>>   net/ionic: warn if loopback mode is requested
>>>   net/ionic: minor refactorings and helper variables
>>>   net/ionic: minor logging fixups
>>
>> For series,
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>>
>>
>> Series applied to dpdk-next-net/main, thanks.
>