mbox series

[0/6] update dpdk-setup.sh

Message ID 20201125191908.1867106-1-ferruh.yigit@intel.com (mailing list archive)
Headers show
Series update dpdk-setup.sh | expand

Message

Ferruh Yigit Nov. 25, 2020, 7:19 p.m. UTC
This is an effort to update the dpdk-setup.sh script and keep it one
more year until whole functionality of it is replaced.

Other option is to remove it completely, please comment.

Ferruh Yigit (6):
  usertools/setup: remove make based build
  usertools/setup: remove inserting custom kernel modules
  usertools/setup: remove running built applications
  usertools/setup: remove hugepage functions
  usertools/setup: fix loading vfio module
  usertools/setup: move removal target to 21.11

 doc/guides/rel_notes/deprecation.rst |   2 +-
 usertools/dpdk-setup.sh              | 332 ++-------------------------
 2 files changed, 15 insertions(+), 319 deletions(-)

Comments

Anatoly Burakov Nov. 27, 2020, 1:57 p.m. UTC | #1
On 25-Nov-20 7:19 PM, Ferruh Yigit wrote:
> This is an effort to update the dpdk-setup.sh script and keep it one
> more year until whole functionality of it is replaced.
> 
> Other option is to remove it completely, please comment.

This script has been largely unmaintained for a long time, so my 
personal opinion is that i'd rather see it removed.

That said, i know for a fact that users (especially non-expert ones) 
rely on this script, so removing it without providing a replacement is 
not practical. This patchset IMO is a good first step towards bringing 
the script up to date, but more work is needed as current usability of 
the script is atrocious.

> 
> Ferruh Yigit (6):
>    usertools/setup: remove make based build
>    usertools/setup: remove inserting custom kernel modules
>    usertools/setup: remove running built applications
>    usertools/setup: remove hugepage functions
>    usertools/setup: fix loading vfio module
>    usertools/setup: move removal target to 21.11
> 
>   doc/guides/rel_notes/deprecation.rst |   2 +-
>   usertools/dpdk-setup.sh              | 332 ++-------------------------
>   2 files changed, 15 insertions(+), 319 deletions(-)
>
Thomas Monjalon Nov. 27, 2020, 2:12 p.m. UTC | #2
27/11/2020 14:57, Burakov, Anatoly:
> On 25-Nov-20 7:19 PM, Ferruh Yigit wrote:
> > This is an effort to update the dpdk-setup.sh script and keep it one
> > more year until whole functionality of it is replaced.
> > 
> > Other option is to remove it completely, please comment.
> 
> This script has been largely unmaintained for a long time, so my 
> personal opinion is that i'd rather see it removed.
> 
> That said, i know for a fact that users (especially non-expert ones) 
> rely on this script, so removing it without providing a replacement is 
> not practical. This patchset IMO is a good first step towards bringing 
> the script up to date, but more work is needed as current usability of 
> the script is atrocious.

I take it as one more argument to remove as planned in 20.11.

Non-expert users should think before using this script.
If they absolutely want it back they will take it from old versions,
or they will complain, which is a kind of contribution,
a first step to think about something better.