mbox series

[v2,0/4] Enable Checksum Offloading for NEON vector

Message ID 20201118104859.29047-1-feifei.wang2@arm.com (mailing list archive)
Headers show
Series Enable Checksum Offloading for NEON vector | expand

Message

Feifei Wang Nov. 18, 2020, 10:48 a.m. UTC 
This patch series are mainly to enable checksum offloading for IXGBE NEON
vector PMD, including good and bad checksum flags. In the meanwhile, the
first patch enable VLAN stripping flag for Arm.
Following are the test results for the patches:

NICs: 82599(igb)
Driver: ixgbe(vector)
$:./app/dpdk-testpmd -c 0x3 -w 0002:f9:00.0 -- -i --port-topology=chained
test-pmd> set fwd rxonly
test-pmd> set verbose 1
test-pmd> start

With Patch a:
enable vlan stripping:
src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - length=70 - nb_segs=1 - VLAN tci=0x1
ol_flags: PKT_RX_VLAN PKT_RX_VLAN_STRIPPED

With Patch b:
Packet: IPv4_checksum = 0xee && UDP_checksum = 0xee
src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - length=70 - nb_segs=1
ol_flags: PKT_RX_L4_CKSUM_BAD PKT_RX_IP_CKSUM_BAD

With Patch c:
Packet: IPv4_checksum = correct value && UDP_checksum = correct value
ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD

v2:
1. update the commit message title to align the design (Wang, Haiyue)
2. make the commit message more descriptive and move the test results
   to the cover letter (Wang, Haiyue)

Feifei Wang (4):
 a). net/ixgbe: add new flag of stripped VLAN for NEON vector
 b). net/ixgbe: support bad checksum flag for NEON vector
 c). net/ixgbe: support good checksum flag for NEON vector
 d). net/ixgbe: enable IXGBE NEON vector when need to checksum

 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 94 ++++++++++++++++++-------
 1 file changed, 68 insertions(+), 26 deletions(-)

Comments

Ferruh Yigit Dec. 11, 2020, 12:06 p.m. UTC | #1 
On 11/18/2020 10:48 AM, Feifei Wang wrote:
> This patch series are mainly to enable checksum offloading for IXGBE NEON
> vector PMD, including good and bad checksum flags. In the meanwhile, the
> first patch enable VLAN stripping flag for Arm.
> Following are the test results for the patches:
> 
> NICs: 82599(igb)
> Driver: ixgbe(vector)
> $:./app/dpdk-testpmd -c 0x3 -w 0002:f9:00.0 -- -i --port-topology=chained
> test-pmd> set fwd rxonly
> test-pmd> set verbose 1
> test-pmd> start
> 
> With Patch a:
> enable vlan stripping:
> src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - length=70 - nb_segs=1 - VLAN tci=0x1
> ol_flags: PKT_RX_VLAN PKT_RX_VLAN_STRIPPED
> 
> With Patch b:
> Packet: IPv4_checksum = 0xee && UDP_checksum = 0xee
> src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - length=70 - nb_segs=1
> ol_flags: PKT_RX_L4_CKSUM_BAD PKT_RX_IP_CKSUM_BAD
> 
> With Patch c:
> Packet: IPv4_checksum = correct value && UDP_checksum = correct value
> ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD
> 
> v2:
> 1. update the commit message title to align the design (Wang, Haiyue)
> 2. make the commit message more descriptive and move the test results
>     to the cover letter (Wang, Haiyue)
> 
> Feifei Wang (4):
>   a). net/ixgbe: add new flag of stripped VLAN for NEON vector
>   b). net/ixgbe: support bad checksum flag for NEON vector
>   c). net/ixgbe: support good checksum flag for NEON vector
>   d). net/ixgbe: enable IXGBE NEON vector when need to checksum
> 
>   drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 94 ++++++++++++++++++-------
>   1 file changed, 68 insertions(+), 26 deletions(-)
> 

Merge note seems sent to different version, moving here:
Applied to dpdk-next-net-intel.

Pulling it to next-net.