mbox series

[0/8] net/ionic: minor updates and documentation

Message ID 20201102183527.69209-1-aboyer@pensando.io (mailing list archive)
Headers
Series net/ionic: minor updates and documentation |

Message

Andrew Boyer Nov. 2, 2020, 6:35 p.m. UTC 
  These patches make some minor changes to the ionic PMD. This is my first
patch submission to DPDK, so please let me know if there is anything amiss.

Andrew Boyer (8):
  ionic: update documentation and MAINTAINERS
  ionic: connect to the meson build system
  ionic: update ionic_if.h to the latest version
  ionic: check for devcmd/admincmd completion more frequently
  ionic: remove some unused fields
  ionic: convert 'deferred' boolean to a flag bit
  ionic: warn if RTE tries to enable loopback mode
  ionic: nits - whitespace, logging, helper variables

 MAINTAINERS                      |    5 +-
 doc/guides/nics/ionic.rst        |   13 +-
 drivers/net/ionic/ionic_dev.c    |    5 +-
 drivers/net/ionic/ionic_dev.h    |   11 +-
 drivers/net/ionic/ionic_ethdev.c |   13 +-
 drivers/net/ionic/ionic_if.h     | 1349 +++++++++++++++++++++---------
 drivers/net/ionic/ionic_lif.c    |   48 +-
 drivers/net/ionic/ionic_lif.h    |    4 +-
 drivers/net/ionic/ionic_main.c   |   40 +-
 drivers/net/ionic/ionic_osdep.h  |   10 -
 drivers/net/ionic/ionic_regs.h   |    3 -
 drivers/net/ionic/ionic_rxtx.c   |   43 +-
 drivers/net/meson.build          |    1 +
 13 files changed, 1014 insertions(+), 531 deletions(-)

Comments

Ferruh Yigit Nov. 3, 2020, 1:11 p.m. UTC | #1 
On 11/2/2020 6:35 PM, Andrew Boyer wrote:
> These patches make some minor changes to the ionic PMD. This is my first
> patch submission to DPDK, so please let me know if there is anything amiss.
> 
> Andrew Boyer (8):
>    ionic: update documentation and MAINTAINERS
>    ionic: connect to the meson build system
>    ionic: update ionic_if.h to the latest version
>    ionic: check for devcmd/admincmd completion more frequently
>    ionic: remove some unused fields
>    ionic: convert 'deferred' boolean to a flag bit
>    ionic: warn if RTE tries to enable loopback mode
>    ionic: nits - whitespace, logging, helper variables
> 

Hi Andrew,

Can you please use "net/ionic: " prefix for the patch titles.

Also please fix warnings of the following scripts:
./devtools/checkpatches.sh -n8
./devtools/check-git-log.sh -n8

checkpatch reports following typos, you need codespell to see them, I am pasting 
here for any case:

### ionic: update ionic_if.h to the latest version

WARNING:TYPO_SPELLING: 'Maximim' may be misspelled - perhaps 'Maximum'?
#355: FILE: drivers/net/ionic/ionic_if.h:404: 
 

+ *     @max_frame_size:     Maximim size of frames to be sent

WARNING:TYPO_SPELLING: 'tranceiver' may be misspelled - perhaps 'transceiver'?
#1158: FILE: drivers/net/ionic/ionic_if.h:1236:
+ * @xcvr:               tranceiver status

WARNING:TYPO_SPELLING: 'autonegotation' may be misspelled - perhaps 
'autonegotiation'?
#1219: FILE: drivers/net/ionic/ionic_if.h:1328:
+ * @IONIC_PORT_ATTR_AUTONEG:    Port autonegotation attribute
Andrew Boyer Nov. 3, 2020, 2:45 p.m. UTC | #2 
> On Nov 3, 2020, at 8:11 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> On 11/2/2020 6:35 PM, Andrew Boyer wrote:
>> These patches make some minor changes to the ionic PMD. This is my first
>> patch submission to DPDK, so please let me know if there is anything amiss.
>> Andrew Boyer (8):
>>   ionic: update documentation and MAINTAINERS
>>   ionic: connect to the meson build system
>>   ionic: update ionic_if.h to the latest version
>>   ionic: check for devcmd/admincmd completion more frequently
>>   ionic: remove some unused fields
>>   ionic: convert 'deferred' boolean to a flag bit
>>   ionic: warn if RTE tries to enable loopback mode
>>   ionic: nits - whitespace, logging, helper variables
> 
> Hi Andrew,
> 
> Can you please use "net/ionic: " prefix for the patch titles.
> 
> Also please fix warnings of the following scripts:
> ./devtools/checkpatches.sh -n8
> ./devtools/check-git-log.sh -n8
> 
> checkpatch reports following typos, you need codespell to see them, I am pasting here for any case:
> 
> ### ionic: update ionic_if.h to the latest version
> 
> WARNING:TYPO_SPELLING: 'Maximim' may be misspelled - perhaps 'Maximum'?
> #355: FILE: drivers/net/ionic/ionic_if.h:404: 
> + *     @max_frame_size:     Maximim size of frames to be sent
> 
> WARNING:TYPO_SPELLING: 'tranceiver' may be misspelled - perhaps 'transceiver'?
> #1158: FILE: drivers/net/ionic/ionic_if.h:1236:
> + * @xcvr:               tranceiver status
> 
> WARNING:TYPO_SPELLING: 'autonegotation' may be misspelled - perhaps 'autonegotiation'?
> #1219: FILE: drivers/net/ionic/ionic_if.h:1328:
> + * @IONIC_PORT_ATTR_AUTONEG:    Port autonegotation attribute

Thank you. Your bot responded immediately with the same spelling issues and Travis caught the 32-bit build issue (%#lx).

-Andrew