mbox series

[v5,0/5] compiling ethdev lib under windows

Message ID 20200811062424.14248-1-fady@mellanox.com (mailing list archive)
Headers
Series compiling ethdev lib under windows |

Message

Fady Bader Aug. 11, 2020, 6:24 a.m. UTC 
  Added needed changes in order to get ethdev compiling under windows.

Depends-on: series-10382 ("compile librte_net for windows")

v5: fixed style issues.

v4: added comments to #else and fixed code issue.

v3: rebased on current master, added more exports to export list

v2: fixed logging issue in telemetry lib.

Fady Bader (5):
  eal: added interrupts empty stubs
  eal: updated export list for Windows
  ethdev: remove structs from export list
  telemetry: implement empty stubs for Windows
  ethdev: compiling ethdev under Windows

 lib/librte_eal/rte_eal_exports.def       | 11 +++++++
 lib/librte_eal/windows/eal_interrupts.c  | 18 ++++++++++++
 lib/librte_eal/windows/meson.build       |  1 +
 lib/librte_ethdev/rte_ethdev_version.map |  2 --
 lib/librte_telemetry/rte_telemetry.h     |  4 +++
 lib/librte_telemetry/telemetry.c         | 50 ++++++++++++++++++++++++++++++++
 lib/librte_telemetry/telemetry_legacy.c  | 25 ++++++++++++++++
 lib/meson.build                          |  3 +-
 8 files changed, 111 insertions(+), 3 deletions(-)
 create mode 100644 lib/librte_eal/windows/eal_interrupts.c

Comments

Thomas Monjalon Aug. 13, 2020, 7:02 a.m. UTC | #1 
You got some acks in previous versions which should be reported in this patchset,
otherwise they are lost.


11/08/2020 08:24, Fady Bader:
> Added needed changes in order to get ethdev compiling under windows.
> 
> Depends-on: series-10382 ("compile librte_net for windows")
> 
> v5: fixed style issues.
> 
> v4: added comments to #else and fixed code issue.
> 
> v3: rebased on current master, added more exports to export list
> 
> v2: fixed logging issue in telemetry lib.
> 
> Fady Bader (5):
>   eal: added interrupts empty stubs
>   eal: updated export list for Windows
>   ethdev: remove structs from export list
>   telemetry: implement empty stubs for Windows
>   ethdev: compiling ethdev under Windows
> 
>  lib/librte_eal/rte_eal_exports.def       | 11 +++++++
>  lib/librte_eal/windows/eal_interrupts.c  | 18 ++++++++++++
>  lib/librte_eal/windows/meson.build       |  1 +
>  lib/librte_ethdev/rte_ethdev_version.map |  2 --
>  lib/librte_telemetry/rte_telemetry.h     |  4 +++
>  lib/librte_telemetry/telemetry.c         | 50 ++++++++++++++++++++++++++++++++
>  lib/librte_telemetry/telemetry_legacy.c  | 25 ++++++++++++++++
>  lib/meson.build                          |  3 +-
>  8 files changed, 111 insertions(+), 3 deletions(-)
>  create mode 100644 lib/librte_eal/windows/eal_interrupts.c
> 
>
Dmitry Kozlyuk Aug. 18, 2020, 4:13 p.m. UTC | #2 
On Tue, 11 Aug 2020 09:24:19 +0300, Fady Bader wrote:
> Added needed changes in order to get ethdev compiling under windows.
> 
> Depends-on: series-10382 ("compile librte_net for windows")
> 
> v5: fixed style issues.
> 
> v4: added comments to #else and fixed code issue.
> 
> v3: rebased on current master, added more exports to export list
> 
> v2: fixed logging issue in telemetry lib.
> 
> Fady Bader (5):
>   eal: added interrupts empty stubs
>   eal: updated export list for Windows
>   ethdev: remove structs from export list
>   telemetry: implement empty stubs for Windows
>   ethdev: compiling ethdev under Windows
> 
>  lib/librte_eal/rte_eal_exports.def       | 11 +++++++
>  lib/librte_eal/windows/eal_interrupts.c  | 18 ++++++++++++
>  lib/librte_eal/windows/meson.build       |  1 +
>  lib/librte_ethdev/rte_ethdev_version.map |  2 --
>  lib/librte_telemetry/rte_telemetry.h     |  4 +++
>  lib/librte_telemetry/telemetry.c         | 50 ++++++++++++++++++++++++++++++++
>  lib/librte_telemetry/telemetry_legacy.c  | 25 ++++++++++++++++
>  lib/meson.build                          |  3 +-
>  8 files changed, 111 insertions(+), 3 deletions(-)
>  create mode 100644 lib/librte_eal/windows/eal_interrupts.c
> 

Series-acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Menon, Ranjit Aug. 20, 2020, 9:40 p.m. UTC | #3 
On 8/10/2020 11:24 PM, Fady Bader wrote:
> Added needed changes in order to get ethdev compiling under windows.
>
> Depends-on: series-10382 ("compile librte_net for windows")
>
> v5: fixed style issues.
>
> v4: added comments to #else and fixed code issue.
>
> v3: rebased on current master, added more exports to export list
>
> v2: fixed logging issue in telemetry lib.
>
> Fady Bader (5):
>    eal: added interrupts empty stubs
>    eal: updated export list for Windows
>    ethdev: remove structs from export list
>    telemetry: implement empty stubs for Windows
>    ethdev: compiling ethdev under Windows
>
>   lib/librte_eal/rte_eal_exports.def       | 11 +++++++
>   lib/librte_eal/windows/eal_interrupts.c  | 18 ++++++++++++
>   lib/librte_eal/windows/meson.build       |  1 +
>   lib/librte_ethdev/rte_ethdev_version.map |  2 --
>   lib/librte_telemetry/rte_telemetry.h     |  4 +++
>   lib/librte_telemetry/telemetry.c         | 50 ++++++++++++++++++++++++++++++++
>   lib/librte_telemetry/telemetry_legacy.c  | 25 ++++++++++++++++
>   lib/meson.build                          |  3 +-
>   8 files changed, 111 insertions(+), 3 deletions(-)
>   create mode 100644 lib/librte_eal/windows/eal_interrupts.c


Acked-by: Ranjit Menon <ranjit.menon@intel.com>