mbox series

[v3,00/10] bnxt patches

Message ID 20200713094213.21410-1-somnath.kotur@broadcom.com (mailing list archive)
Headers show
Series bnxt patches | expand

Message

Somnath Kotur July 13, 2020, 9:42 a.m. UTC
Minor enhancments added to the TF-ULP/Core layers

Farah Smith (1):
  net/bnxt: add changes to support 2 table scopes

Jay Ding (2):
  net/bnxt: implement TF Identifier search
  net/bnxt: check index range in bulk get

Kishore Padmanabha (6):
  net/bnxt: add support to extract data from the ulp blob
  net/bnxt: ignore ipv4 TOS mask
  net/bnxt: add support for identifier search and ref count
  net/bnxt: consider VLAN fields for template match criteria
  net/bnxt: increase the number of egress flow entries
  net/bnxt: add support for decrement TTL action

Peter Spreadborough (1):
  net/bnxt: add option to delay EEM sysmem mapping

 drivers/net/bnxt/meson.build                    |   3 +-
 drivers/net/bnxt/tf_core/Makefile               |   1 +
 drivers/net/bnxt/tf_core/tf_core.c              |  78 +++++++-
 drivers/net/bnxt/tf_core/tf_core.h              |  78 +++++++-
 drivers/net/bnxt/tf_core/tf_device.h            |  20 +++
 drivers/net/bnxt/tf_core/tf_device_p4.c         |   2 +
 drivers/net/bnxt/tf_core/tf_em.h                |  11 ++
 drivers/net/bnxt/tf_core/tf_em_common.c         | 145 ++++++++++++++-
 drivers/net/bnxt/tf_core/tf_em_common.h         |  27 ++-
 drivers/net/bnxt/tf_core/tf_em_host.c           |  23 +--
 drivers/net/bnxt/tf_core/tf_em_internal.c       |   2 +-
 drivers/net/bnxt/tf_core/tf_em_system.c         |  25 +--
 drivers/net/bnxt/tf_core/tf_identifier.c        | 148 +++++++++++++++
 drivers/net/bnxt/tf_core/tf_identifier.h        |  47 +++++
 drivers/net/bnxt/tf_core/tf_msg.c               |   3 +-
 drivers/net/bnxt/tf_core/tf_rm.c                |  43 +++++
 drivers/net/bnxt/tf_core/tf_rm.h                |  45 +++++
 drivers/net/bnxt/tf_core/tf_shadow_identifier.c | 190 ++++++++++++++++++++
 drivers/net/bnxt/tf_core/tf_shadow_identifier.h | 229 ++++++++++++++++++++++++
 drivers/net/bnxt/tf_core/tf_tbl.c               |  40 ++---
 drivers/net/bnxt/tf_ulp/bnxt_ulp.c              |   2 +-
 drivers/net/bnxt/tf_ulp/ulp_mapper.c            | 117 +++++++++++-
 drivers/net/bnxt/tf_ulp/ulp_rte_parser.c        |  74 +++++++-
 drivers/net/bnxt/tf_ulp/ulp_rte_parser.h        |   5 +
 drivers/net/bnxt/tf_ulp/ulp_template_db_tbl.c   |   4 +-
 drivers/net/bnxt/tf_ulp/ulp_utils.c             |  76 ++++++++
 drivers/net/bnxt/tf_ulp/ulp_utils.h             |  17 ++
 27 files changed, 1367 insertions(+), 88 deletions(-)
 create mode 100644 drivers/net/bnxt/tf_core/tf_shadow_identifier.c
 create mode 100644 drivers/net/bnxt/tf_core/tf_shadow_identifier.h

Comments

Ajit Khaparde July 14, 2020, 10:36 p.m. UTC | #1
On Mon, Jul 13, 2020 at 2:47 AM Somnath Kotur <somnath.kotur@broadcom.com>
wrote:

> Minor enhancments added to the TF-ULP/Core layers
>
> Farah Smith (1):
>   net/bnxt: add changes to support 2 table scopes
>
> Jay Ding (2):
>   net/bnxt: implement TF Identifier search
>   net/bnxt: check index range in bulk get
>
> Kishore Padmanabha (6):
>   net/bnxt: add support to extract data from the ulp blob
>   net/bnxt: ignore ipv4 TOS mask
>   net/bnxt: add support for identifier search and ref count
>   net/bnxt: consider VLAN fields for template match criteria
>   net/bnxt: increase the number of egress flow entries
>   net/bnxt: add support for decrement TTL action
>
> Peter Spreadborough (1):
>   net/bnxt: add option to delay EEM sysmem mapping
>
>  drivers/net/bnxt/meson.build                    |   3 +-
>  drivers/net/bnxt/tf_core/Makefile               |   1 +
>  drivers/net/bnxt/tf_core/tf_core.c              |  78 +++++++-
>  drivers/net/bnxt/tf_core/tf_core.h              |  78 +++++++-
>  drivers/net/bnxt/tf_core/tf_device.h            |  20 +++
>  drivers/net/bnxt/tf_core/tf_device_p4.c         |   2 +
>  drivers/net/bnxt/tf_core/tf_em.h                |  11 ++
>  drivers/net/bnxt/tf_core/tf_em_common.c         | 145 ++++++++++++++-
>  drivers/net/bnxt/tf_core/tf_em_common.h         |  27 ++-
>  drivers/net/bnxt/tf_core/tf_em_host.c           |  23 +--
>  drivers/net/bnxt/tf_core/tf_em_internal.c       |   2 +-
>  drivers/net/bnxt/tf_core/tf_em_system.c         |  25 +--
>  drivers/net/bnxt/tf_core/tf_identifier.c        | 148 +++++++++++++++
>  drivers/net/bnxt/tf_core/tf_identifier.h        |  47 +++++
>  drivers/net/bnxt/tf_core/tf_msg.c               |   3 +-
>  drivers/net/bnxt/tf_core/tf_rm.c                |  43 +++++
>  drivers/net/bnxt/tf_core/tf_rm.h                |  45 +++++
>  drivers/net/bnxt/tf_core/tf_shadow_identifier.c | 190 ++++++++++++++++++++
>  drivers/net/bnxt/tf_core/tf_shadow_identifier.h | 229
> ++++++++++++++++++++++++
>  drivers/net/bnxt/tf_core/tf_tbl.c               |  40 ++---
>  drivers/net/bnxt/tf_ulp/bnxt_ulp.c              |   2 +-
>  drivers/net/bnxt/tf_ulp/ulp_mapper.c            | 117 +++++++++++-
>  drivers/net/bnxt/tf_ulp/ulp_rte_parser.c        |  74 +++++++-
>  drivers/net/bnxt/tf_ulp/ulp_rte_parser.h        |   5 +
>  drivers/net/bnxt/tf_ulp/ulp_template_db_tbl.c   |   4 +-
>  drivers/net/bnxt/tf_ulp/ulp_utils.c             |  76 ++++++++
>  drivers/net/bnxt/tf_ulp/ulp_utils.h             |  17 ++
>  27 files changed, 1367 insertions(+), 88 deletions(-)
>  create mode 100644 drivers/net/bnxt/tf_core/tf_shadow_identifier.c
>  create mode 100644 drivers/net/bnxt/tf_core/tf_shadow_identifier.h
>
> --
> v1->v2: Corrected some typos in patch 5 and 6
> v2->v3: Modified case of some words in commit summary as per
> git-check-log.sh
>
Patchset applied to dpdk-next-net-brcm. Thanks



> 2.7.4
>
>
Ferruh Yigit July 15, 2020, 12:50 p.m. UTC | #2
On 7/14/2020 11:36 PM, Ajit Khaparde wrote:
> 
> 
> On Mon, Jul 13, 2020 at 2:47 AM Somnath Kotur <somnath.kotur@broadcom.com
> <mailto:somnath.kotur@broadcom.com>> wrote:
> 
>     Minor enhancments added to the TF-ULP/Core layers
> 
>     Farah Smith (1):
>       net/bnxt: add changes to support 2 table scopes
> 
>     Jay Ding (2):
>       net/bnxt: implement TF Identifier search
>       net/bnxt: check index range in bulk get
> 
>     Kishore Padmanabha (6):
>       net/bnxt: add support to extract data from the ulp blob
>       net/bnxt: ignore ipv4 TOS mask
>       net/bnxt: add support for identifier search and ref count
>       net/bnxt: consider VLAN fields for template match criteria
>       net/bnxt: increase the number of egress flow entries
>       net/bnxt: add support for decrement TTL action
> 
>     Peter Spreadborough (1):
>       net/bnxt: add option to delay EEM sysmem mapping
> 
>      drivers/net/bnxt/meson.build                    |   3 +-
>      drivers/net/bnxt/tf_core/Makefile               |   1 +
>      drivers/net/bnxt/tf_core/tf_core.c              |  78 +++++++-
>      drivers/net/bnxt/tf_core/tf_core.h              |  78 +++++++-
>      drivers/net/bnxt/tf_core/tf_device.h            |  20 +++
>      drivers/net/bnxt/tf_core/tf_device_p4.c         |   2 +
>      drivers/net/bnxt/tf_core/tf_em.h                |  11 ++
>      drivers/net/bnxt/tf_core/tf_em_common.c         | 145 ++++++++++++++-
>      drivers/net/bnxt/tf_core/tf_em_common.h         |  27 ++-
>      drivers/net/bnxt/tf_core/tf_em_host.c           |  23 +--
>      drivers/net/bnxt/tf_core/tf_em_internal.c       |   2 +-
>      drivers/net/bnxt/tf_core/tf_em_system.c         |  25 +--
>      drivers/net/bnxt/tf_core/tf_identifier.c        | 148 +++++++++++++++
>      drivers/net/bnxt/tf_core/tf_identifier.h        |  47 +++++
>      drivers/net/bnxt/tf_core/tf_msg.c               |   3 +-
>      drivers/net/bnxt/tf_core/tf_rm.c                |  43 +++++
>      drivers/net/bnxt/tf_core/tf_rm.h                |  45 +++++
>      drivers/net/bnxt/tf_core/tf_shadow_identifier.c | 190 ++++++++++++++++++++
>      drivers/net/bnxt/tf_core/tf_shadow_identifier.h | 229 ++++++++++++++++++++++++
>      drivers/net/bnxt/tf_core/tf_tbl.c               |  40 ++---
>      drivers/net/bnxt/tf_ulp/bnxt_ulp.c              |   2 +-
>      drivers/net/bnxt/tf_ulp/ulp_mapper.c            | 117 +++++++++++-
>      drivers/net/bnxt/tf_ulp/ulp_rte_parser.c        |  74 +++++++-
>      drivers/net/bnxt/tf_ulp/ulp_rte_parser.h        |   5 +
>      drivers/net/bnxt/tf_ulp/ulp_template_db_tbl.c   |   4 +-
>      drivers/net/bnxt/tf_ulp/ulp_utils.c             |  76 ++++++++
>      drivers/net/bnxt/tf_ulp/ulp_utils.h             |  17 ++
>      27 files changed, 1367 insertions(+), 88 deletions(-)
>      create mode 100644 drivers/net/bnxt/tf_core/tf_shadow_identifier.c
>      create mode 100644 drivers/net/bnxt/tf_core/tf_shadow_identifier.h
> 
>     -- 
>     v1->v2: Corrected some typos in patch 5 and 6
>     v2->v3: Modified case of some words in commit summary as per git-check-log.sh
> 
> Patchset applied to dpdk-next-net-brcm. Thanks
> 

Hi Ajit,

The patch "net/bnxt: add support for identifier search and ref count" is causing
build error [1], can you please check it?

[1]
.../drivers/net/bnxt/tf_ulp/ulp_mapper.c: In function ‘ulp_mapper_ident_extract’:
.../drivers/net/bnxt/tf_ulp/ulp_mapper.c:723:8: error: implicit declaration of
function ‘tf_dir_2_str’ [-Werror=implicit-function-declaration]
  723 |        tf_dir_2_str(sparms.dir),
      |        ^~~~~~~~~~~~
.../drivers/net/bnxt/bnxt.h:867:16: note: in definition of macro ‘PMD_DRV_LOG_RAW’
  867 |   __func__, ## args)
      |                ^~~~
.../drivers/net/bnxt/tf_ulp/bnxt_tf_common.h:14:40: note: in expansion of macro
‘PMD_DRV_LOG’
   14 | #define BNXT_TF_DBG(lvl, fmt, args...) PMD_DRV_LOG(lvl, fmt, ## args)
      |                                        ^~~~~~~~~~~
.../drivers/net/bnxt/tf_ulp/ulp_mapper.c:722:3: note: in expansion of macro
‘BNXT_TF_DBG’
  722 |   BNXT_TF_DBG(ERR, "Search ident %s:%s:%x failed.\n",
      |   ^~~~~~~~~~~


      .../drivers/net/bnxt/bnxt.h:866:50: error: format ‘%s’ expects argument of
type ‘char *’, but argument 5 has type ‘int’ [-Werror=format=]
  866 |  rte_log(RTE_LOG_ ## level, bnxt_logtype_driver, "%s(): " fmt, \
      |                                                  ^~~~~~~~
.../drivers/net/bnxt/bnxt.h:870:4: note: in expansion of macro ‘PMD_DRV_LOG_RAW’
  870 |    PMD_DRV_LOG_RAW(level, fmt, ## args)
      |    ^~~~~~~~~~~~~~~
.../drivers/net/bnxt/tf_ulp/bnxt_tf_common.h:14:40: note: in expansion of macro
‘PMD_DRV_LOG’
   14 | #define BNXT_TF_DBG(lvl, fmt, args...) PMD_DRV_LOG(lvl, fmt, ## args)
      |                                        ^~~~~~~~~~~
.../drivers/net/bnxt/tf_ulp/ulp_mapper.c:722:3: note: in expansion of macro
‘BNXT_TF_DBG’
  722 |   BNXT_TF_DBG(ERR, "Search ident %s:%s:%x failed.\n",
      |   ^~~~~~~~~~~
.../drivers/net/bnxt/tf_ulp/ulp_mapper.c:722:35: note: format string is defined here
  722 |   BNXT_TF_DBG(ERR, "Search ident %s:%s:%x failed.\n",
      |                                  ~^
      |                                   |
      |                                   char *
      |                                  %d