mbox series

[v7,0/25] ethdev: allow unknown link speed

Message ID 20200710070226.6045-1-i.dyukov@samsung.com (mailing list archive)
Headers show
Series ethdev: allow unknown link speed | expand

Message

Ivan Dyukov July 10, 2020, 7:01 a.m. UTC
MAINTAINERS                                              |   1 +
 app/proc-info/main.c                                     |   9 ++----
 app/test-pipeline/init.c                                 |  11 ++++---
 app/test-pmd/config.c                                    |  20 ++++++++-----
 app/test-pmd/testpmd.c                                   |   9 +-----
 app/test/Makefile                                        |   3 ++
 app/test/meson.build                                     |   2 ++
 app/test/test_ethdev_link.c                              | 278 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 app/test/test_pmd_perf.c                                 |  17 +++++------
 doc/guides/sample_app_ug/link_status_intr.rst            |  10 +++----
 drivers/net/i40e/i40e_ethdev.c                           |   5 +++-
 drivers/net/i40e/i40e_ethdev_vf.c                        |  10 +++----
 drivers/net/ice/ice_ethdev.c                             |   5 +++-
 drivers/net/ixgbe/ixgbe_ethdev.c                         |   6 +---
 examples/bbdev_app/main.c                                |   8 ++---
 examples/ioat/ioatfwd.c                                  |  13 ++++----
 examples/ip_fragmentation/main.c                         |  13 ++++----
 examples/ip_pipeline/cli.c                               |  12 ++++----
 examples/ip_reassembly/main.c                            |  12 +++-----
 examples/ipsec-secgw/ipsec-secgw.c                       |  12 +++-----
 examples/ipv4_multicast/main.c                           |  12 +++-----
 examples/kni/main.c                                      |  26 ++++++----------
 examples/l2fwd-crypto/main.c                             |  12 +++-----
 examples/l2fwd-event/main.c                              |  12 +++-----
 examples/l2fwd-jobstats/main.c                           |  12 +++-----
 examples/l2fwd-keepalive/main.c                          |  12 +++-----
 examples/l2fwd/main.c                                    |  12 +++-----
 examples/l3fwd-acl/main.c                                |  12 +++-----
 examples/l3fwd-graph/main.c                              |  14 +++------
 examples/l3fwd-power/main.c                              |  13 +++-----
 examples/l3fwd/main.c                                    |  12 +++-----
 examples/link_status_interrupt/main.c                    |  30 ++++++++-----------
 examples/multi_process/client_server_mp/mp_server/init.c |  14 ++++-----
 examples/multi_process/symmetric_mp/main.c               |  12 +++-----
 examples/ntb/ntb_fwd.c                                   |  10 +++----
 examples/performance-thread/l3fwd-thread/main.c          |  12 +++-----
 examples/qos_sched/init.c                                |  10 ++-----
 examples/server_node_efd/server/init.c                   |  15 ++++------
 examples/vm_power_manager/main.c                         |  14 ++++-----
 lib/librte_ethdev/rte_ethdev.c                           | 169 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/librte_ethdev/rte_ethdev.h                           |  74 +++++++++++++++++++++++++++++++++++++++-------
 lib/librte_ethdev/rte_ethdev_version.map                 |   4 +++
 42 files changed, 687 insertions(+), 282 deletions(-)

v7 changes:
* fix meson build
* change _strf function. now it does not fails in case of unknown specifiers like %d. it just copy it to target string.
* remove invalid_fmt unit test.
* add unknown specifier test.
* fix codestyle

v6 changes:
* fix spelling in comments according to checkpatch warning

v5 changes:
* rename rte_eth_link_format to rte_eth_link_strf
* add '\n' to default strings
* update remaining examples. patch with subj 'examples: new link status print format' contains examples which have no maintainers.
TBD:
update remaining nic drivers with 'unknown' speed.  It should be provided in separate patchset.

v4 changes:
* refactor rte_eth_link_format using strlcat func instead of snprintf
* added new checks to unit tests
* few minor fixes according review comments
TBD:
update examples in 'example' folder with new status printing mechanism
update remaining nic drivers with 'unknown' speed

v3 changes:
* remove rte_eth_link_prepare_text function
* add rte_eth_link_format and rte_eth_link_printf functions
* added unit tests for rte_eth_link_format function
TBD:
update examples in 'example' folder with new status printing mechanism
update remaining nic drivers with 'unknown' speed

v2 changes:
* add function which format link status to textual representation
* update drivers for Intel nics with 'unknown' speed
TBD:
update examples in 'example' folder with new status printing mechanism
update remaining nic drivers with 'unknown' speed

v1 changes:
This is initial patchset which introduces UNKNOWN speed to dpdk
applications. Also it contains changes related to printf formating.
Patchset contains changes for app/ and doc/ folders.
examples/ folder will be provided later.

Comments

Thomas Monjalon July 10, 2020, 3:02 p.m. UTC | #1
There are still comments in this patchset which is doing two things:
	1/ declare unknown speed
	2/ format link infos

Could we merge the first part in 20.08-rc1,
while waiting to complete the second part in -rc2 or 20.11?
How much both parts are related?
Ferruh Yigit July 10, 2020, 3:47 p.m. UTC | #2
> Subject: Re: [dpdk-dev] [PATCH v7 0/25] ethdev: allow unknown link speed
> 
> There are still comments in this patchset which is doing two things:
> 	1/ declare unknown speed
> 	2/ format link infos
> 
> Could we merge the first part in 20.08-rc1, while waiting to complete the
> second part in -rc2 or 20.11?
> How much both parts are related?
> 

+1 to get the (1), but this will lead UNKNOWN speed printed as UINT_MAX in the logs, this is what (2) is fixing.

If we say printing UNKNOWN speed as UINT_MAX for this release is acceptable, I am OK to get only (1).
Thomas Monjalon July 10, 2020, 4 p.m. UTC | #3
10/07/2020 17:47, Yigit, Ferruh:
> > Subject: Re: [dpdk-dev] [PATCH v7 0/25] ethdev: allow unknown link speed
> > 
> > There are still comments in this patchset which is doing two things:
> > 	1/ declare unknown speed
> > 	2/ format link infos
> > 
> > Could we merge the first part in 20.08-rc1, while waiting to complete the
> > second part in -rc2 or 20.11?
> > How much both parts are related?
> > 
> 
> +1 to get the (1), but this will lead UNKNOWN speed printed as UINT_MAX in the logs, this is what (2) is fixing.
> 
> If we say printing UNKNOWN speed as UINT_MAX for this release is acceptable, I am OK to get only (1).

I think it's better to wait to have everything ready for 20.11.
Ivan Dyukov July 10, 2020, 7:23 p.m. UTC | #4
10.07.2020 18:02, Thomas Monjalon пишет:
> There are still comments in this patchset which is doing two things:
> 	1/ declare unknown speed
> 	2/ format link infos
3/ update drivers with unknown speed.

this patchset contains only Intel drivers. remaining drivers will be 
provided later.
> Could we merge the first part in 20.08-rc1,
> while waiting to complete the second part in -rc2 or 20.11?
> How much both parts are related?

>
>
>