mbox series

[0/5] compiling ethdev lib under windows

Message ID 20200625133038.25180-1-fady@mellanox.com (mailing list archive)
Headers show
Series compiling ethdev lib under windows | expand

Message

Fady Bader June 25, 2020, 1:30 p.m. UTC
Added needed changes in order to get ethdev compiling under windows.

Depends-on: series-10382 ("compile librte_net for windows")

Fady Bader (5):
  eal: added interrupts empty stubs
  eal: updated export list for Windows
  ethdev: remove structs from export list
  telemetry: implement empty stubs for Windows
  ethdev: compiling ethdev under Windows

 lib/librte_eal/rte_eal_exports.def       | 10 ++++++++
 lib/librte_eal/windows/eal_interrupts.c  | 17 +++++++++++++
 lib/librte_eal/windows/meson.build       |  1 +
 lib/librte_ethdev/rte_ethdev_version.map |  2 --
 lib/librte_telemetry/rte_telemetry.h     |  4 +++
 lib/librte_telemetry/telemetry.c         | 43 +++++++++++++++++++++++++++++++-
 lib/librte_telemetry/telemetry_legacy.c  | 26 ++++++++++++++++++-
 lib/meson.build                          |  7 ++++--
 8 files changed, 104 insertions(+), 6 deletions(-)
 create mode 100644 lib/librte_eal/windows/eal_interrupts.c

Comments

Narcisa Ana Maria Vasile July 29, 2020, 1:01 a.m. UTC | #1
On Thu, Jun 25, 2020 at 04:30:33PM +0300, Fady Bader wrote:
> Added needed changes in order to get ethdev compiling under windows.
> 
> Depends-on: series-10382 ("compile librte_net for windows")
> 
> Fady Bader (5):
>   eal: added interrupts empty stubs
>   eal: updated export list for Windows
>   ethdev: remove structs from export list
>   telemetry: implement empty stubs for Windows
>   ethdev: compiling ethdev under Windows
> 
>  lib/librte_eal/rte_eal_exports.def       | 10 ++++++++
>  lib/librte_eal/windows/eal_interrupts.c  | 17 +++++++++++++
>  lib/librte_eal/windows/meson.build       |  1 +
>  lib/librte_ethdev/rte_ethdev_version.map |  2 --
>  lib/librte_telemetry/rte_telemetry.h     |  4 +++
>  lib/librte_telemetry/telemetry.c         | 43 +++++++++++++++++++++++++++++++-
>  lib/librte_telemetry/telemetry_legacy.c  | 26 ++++++++++++++++++-
>  lib/meson.build                          |  7 ++++--
>  8 files changed, 104 insertions(+), 6 deletions(-)
>  create mode 100644 lib/librte_eal/windows/eal_interrupts.c
> 
Tested-by: Narcisa Vasile <navasile@linux.microsoft.com>

Compiled successfully with mingw and clang. It does need a rebase, as more changes have been added in telemetry.
Also, there's a missing export that needs to be added as well 'rte_log_register_type_and_pick_level' 


> -- 
> 2.16.1.windows.4
Fady Bader Aug. 3, 2020, 6:16 a.m. UTC | #2
> -----Original Message-----
> From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
> Sent: Wednesday, July 29, 2020 4:02 AM
> To: Fady Bader <fady@mellanox.com>
> Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Tasnim Bashar
> <tbashar@mellanox.com>; Tal Shnaiderman <talshn@mellanox.com>; Yohad Tor
> <yohadt@mellanox.com>; dmitry.kozliuk@gmail.com;
> harini.ramakrishnan@microsoft.com; ocardona@microsoft.com;
> ranjit.menon@intel.com; pallavi.kadam@intel.com; kevin.laatz@intel.com;
> ferruh.yigit@intel.com; arybchenko@solarflare.com
> Subject: Re: [dpdk-dev] [PATCH 0/5] compiling ethdev lib under windows
> 
> On Thu, Jun 25, 2020 at 04:30:33PM +0300, Fady Bader wrote:
> > Added needed changes in order to get ethdev compiling under windows.
> >
> > Depends-on: series-10382 ("compile librte_net for windows")
> >
> > Fady Bader (5):
> >   eal: added interrupts empty stubs
> >   eal: updated export list for Windows
> >   ethdev: remove structs from export list
> >   telemetry: implement empty stubs for Windows
> >   ethdev: compiling ethdev under Windows
> >
> >  lib/librte_eal/rte_eal_exports.def       | 10 ++++++++
> >  lib/librte_eal/windows/eal_interrupts.c  | 17 +++++++++++++
> >  lib/librte_eal/windows/meson.build       |  1 +
> >  lib/librte_ethdev/rte_ethdev_version.map |  2 --
> >  lib/librte_telemetry/rte_telemetry.h     |  4 +++
> >  lib/librte_telemetry/telemetry.c         | 43
> +++++++++++++++++++++++++++++++-
> >  lib/librte_telemetry/telemetry_legacy.c  | 26 ++++++++++++++++++-
> >  lib/meson.build                          |  7 ++++--
> >  8 files changed, 104 insertions(+), 6 deletions(-)  create mode
> > 100644 lib/librte_eal/windows/eal_interrupts.c
> >
> Tested-by: Narcisa Vasile <navasile@linux.microsoft.com>
> 
> Compiled successfully with mingw and clang. It does need a rebase, as more
> changes have been added in telemetry.
> Also, there's a missing export that needs to be added as well
> 'rte_log_register_type_and_pick_level'

Thanks Narcisa, I'll send a rebased patch.

> 
> 
> > --
> > 2.16.1.windows.4