Message ID | 20200427095737.11082-1-i.dyukov@samsung.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 560AFA00BE; Mon, 27 Apr 2020 11:57:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D01511C2F5; Mon, 27 Apr 2020 11:57:53 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 534511C214 for <dev@dpdk.org>; Mon, 27 Apr 2020 11:57:52 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200427095751euoutp01158347475d3aca525a0d37ff3e62147a~JpLwcd0cM2146821468euoutp017 for <dev@dpdk.org>; Mon, 27 Apr 2020 09:57:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200427095751euoutp01158347475d3aca525a0d37ff3e62147a~JpLwcd0cM2146821468euoutp017 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587981471; bh=/55xhp+z37GNyBMFbKuQ/S0g6CRJoEIciEYSSx9JdOE=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=EpoOEHrIO5efT/TaPPAmIVQScsz8QYXVefvdK5iNSi4SYB/2qn4VkZsq/kAK7CvrE jIcck81SfeSNSHtsBRyjGokhgOiwTAEDZh3p3rLhdCiqvhI+6lHViirHSx6XmeNLGw uf6I+BSXSUUPRUSklhqPXHg5rwOG6i159bqod8Qw= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200427095751eucas1p1cdbf3d59970ac5c820c344ae1bc947d0~JpLwLq9r41957819578eucas1p1N; Mon, 27 Apr 2020 09:57:51 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 34.E3.60679.F9CA6AE5; Mon, 27 Apr 2020 10:57:51 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200427095750eucas1p29d1b58cf0e55bf6bc50be3e42ccff159~JpLv7zGZU0048500485eucas1p2o; Mon, 27 Apr 2020 09:57:50 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200427095750eusmtrp1c419b56864c47fb59966a3314521d5e2~JpLv63i-02257022570eusmtrp1b; Mon, 27 Apr 2020 09:57:50 +0000 (GMT) X-AuditID: cbfec7f4-0cbff7000001ed07-03-5ea6ac9fe77e Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id AA.9F.07950.E9CA6AE5; Mon, 27 Apr 2020 10:57:50 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200427095750eusmtip1e53860a3479e7e890876282fe0b7e7ae~JpLvVAKwA1184111841eusmtip1s; Mon, 27 Apr 2020 09:57:50 +0000 (GMT) From: Ivan Dyukov <i.dyukov@samsung.com> To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Mon, 27 Apr 2020 12:57:22 +0300 Message-Id: <20200427095737.11082-1-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <4816966.qqrk5fENW1@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAKsWRmVeSWpSXmKPExsWy7djP87rz1yyLM7ixnMPiwZS7bBbbV3Sx Wbz7tJ3J4s7e0+wWsy41sVt8enCCxeL0zc3sDuwevxYsZfVYvOclk8exm9PYPd7vu8rm0bdl FaPH6ic/2ALYorhsUlJzMstSi/TtErgyJp5IL3jDWLH22kq2BsaDjF2MnBwSAiYSVxfcZwax hQRWMEq83u3bxcgFZH9hlNh04QgrhPOZUeLplW52mI6zU/exQnQsZ5R4vykBwv7KKNE13xHE ZhPQkDjdMY8JpFlEYBmjxPFXv8BWCAtYSKx5cAJsNYuAqsTTqYfBBvEKWEqcO3CFGWKBvMTq DQfAbE6gQZve3AOyOYAWKEt8vpoAUS4ocXLmExYQmxmovHnrbGaQXRICq9glntx5DvWai8TS +wvYIGxhiVfHt0A9ICNxenIPC4RdLfF903V2iOYORol7i1qhiuwltrw+xw6ymFlAU2L9Ln2I sKNE56EGFpCwhACfxI23ghA38ElM2jadGSLMK9HRJgRRrSRx4OQlqLCExN/fPBBhD4kjT64x TWBUnIXkmVlInpmFsHYBI/MqRvHU0uLc9NRio7zUcr3ixNzi0rx0veT83E2MwHRz+t/xLzsY d/1JOsQowMGoxMPLsX1pnBBrYllxZe4hRgkOZiUR3kcZy+KEeFMSK6tSi/Lji0pzUosPMUpz sCiJ8xovehkrJJCeWJKanZpakFoEk2Xi4JRqYEz4lPq7/uyGKCGnnlC7/ps3lhq2LNh4/rX8 WV7hrM2qa9vTV+wJv6oQYlnYsW5m+LXNKyxmtys/ztP8WLH1AsfiXe7z5ySVfjRki7XawcS4 6fDyQoMkkeuWT/9Hf9D7umnFkwdb8qX2GTlqCd/d6fC+ZJrXb4uEb9fXOpcuETy8bUKYcfhJ 9vtKLMUZiYZazEXFiQCANmNXMwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsVy+t/xu7rz1iyLMzh+zsDiwZS7bBbbV3Sx Wbz7tJ3J4s7e0+wWsy41sVt8enCCxeL0zc3sDuwevxYsZfVYvOclk8exm9PYPd7vu8rm0bdl FaPH6ic/2ALYovRsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstS i/TtEvQyJp5IL3jDWLH22kq2BsaDjF2MnBwSAiYSZ6fuY+1i5OIQEljKKPHv+0OgBAdQQkLi 9RNmiBphiT/Xutggaj4zSvw9f40NJMEmoCFxumMeE0hCRGAdo8THmW/AOoQFLCTWPDgBtoFF QFXi6dTDrCA2r4ClxLkDV6Cmykus3nAAzOYEGrTpzT0wW0hAXWLiiZfsIEcICShLfL6aANEq KHFy5hMWkDAzUMn6eUIgYWagKc1bZzNPYBSchaRqFkLVLCRVCxiZVzGKpJYW56bnFhvpFSfm Fpfmpesl5+duYgRG0rZjP7fsYOx6F3yIUYCDUYmHl2P70jgh1sSy4srcQ4wSHMxKIryPMpbF CfGmJFZWpRblxxeV5qQWH2I0BfpyIrOUaHI+MMrzSuINTQ3NLSwNzY3Njc0slMR5OwQOxggJ pCeWpGanphakFsH0MXFwSjUwzvf68fHKpNqbN9tfLY30Fg82yHhhK7YohPF83kWrVfUallon LTs81Mum+yZftGzS4l6aoG1wJ1PX4/ac62uv7OgVWqSyf8ZEwdcfqkUZTGa/3nuhj+PkcTHt t8rv3B+7ffU4/D/ZrXzX0u/RmoqWXezbIw9NyVhwbOLNpNb8A+HKM5bKnTirqsRSnJFoqMVc VJwIAH+DBm26AgAA X-CMS-MailID: 20200427095750eucas1p29d1b58cf0e55bf6bc50be3e42ccff159 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200427095750eucas1p29d1b58cf0e55bf6bc50be3e42ccff159 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200427095750eucas1p29d1b58cf0e55bf6bc50be3e42ccff159 References: <4816966.qqrk5fENW1@thomas> <CGME20200427095750eucas1p29d1b58cf0e55bf6bc50be3e42ccff159@eucas1p2.samsung.com> Subject: [dpdk-dev] [PATCH v1 0/6] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: 4816966.qqrk5fENW1@thomas.org List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
ethdev: allow unknown link speed
|
|
Message
Ivan Dyukov
April 27, 2020, 9:57 a.m. UTC
This is initial patchset which introduces UNKNOWN speed to dpdk applications. Also it contains changes related to printf formating. Patchset contains changes for app/ and doc/ folders. examples/ folder will be provided later.
Comments
On 4/27/2020 10:57 AM, Ivan Dyukov wrote: > This is initial patchset which introduces UNKNOWN speed to dpdk > applications. Also it contains changes related to printf formating. > Patchset contains changes for app/ and doc/ folders. > examples/ folder will be provided later. > > Also I can see there are some physical PMDs that are using 'ETH_SPEED_NUM_NONE' as unknown, can we fix them as part of this set?
06.05.2020 20:42, Ferruh Yigit пишет: > On 4/27/2020 10:57 AM, Ivan Dyukov wrote: >> This is initial patchset which introduces UNKNOWN speed to dpdk >> applications. Also it contains changes related to printf formating. >> Patchset contains changes for app/ and doc/ folders. >> examples/ folder will be provided later. >> >> > Also I can see there are some physical PMDs that are using 'ETH_SPEED_NUM_NONE' > as unknown, can we fix them as part of this set? > Initially, we had a plan to use UNKNOWN only for virtual devices. Thomas, could you please comment this?
07/05/2020 10:53, Ivan Dyukov: > 06.05.2020 20:42, Ferruh Yigit пишет: > > On 4/27/2020 10:57 AM, Ivan Dyukov wrote: > >> This is initial patchset which introduces UNKNOWN speed to dpdk > >> applications. Also it contains changes related to printf formating. > >> Patchset contains changes for app/ and doc/ folders. > >> examples/ folder will be provided later. > >> > >> > > Also I can see there are some physical PMDs that are using 'ETH_SPEED_NUM_NONE' > > as unknown, can we fix them as part of this set? > > > Initially, we had a plan to use UNKNOWN only for virtual devices. > > Thomas, could you please comment this? No I think UNKNOWN must be used also for HW devices which are not able to provide a speed value. In mlx5 case, it can be used to return the link status (up/down) even if speed query is failing (it happens with buggy kernel version).
07.05.2020 13:31, Thomas Monjalon пишет: > 07/05/2020 10:53, Ivan Dyukov: >> 06.05.2020 20:42, Ferruh Yigit пишет: >>> On 4/27/2020 10:57 AM, Ivan Dyukov wrote: >>>> This is initial patchset which introduces UNKNOWN speed to dpdk >>>> applications. Also it contains changes related to printf formating. >>>> Patchset contains changes for app/ and doc/ folders. >>>> examples/ folder will be provided later. >>>> >>>> >>> Also I can see there are some physical PMDs that are using 'ETH_SPEED_NUM_NONE' >>> as unknown, can we fix them as part of this set? >>> >> Initially, we had a plan to use UNKNOWN only for virtual devices. >> >> Thomas, could you please comment this? > No I think UNKNOWN must be used also for HW devices which are not able > to provide a speed value. > > In mlx5 case, it can be used to return the link status (up/down) > even if speed query is failing (it happens with buggy kernel version). > Ok. Is ETH_SPEED_NUM_NONE still needed then? could it be replaced by UNKNOWN everywhere? >
On 5/7/2020 2:55 PM, Ivan Dyukov wrote: > 07.05.2020 13:31, Thomas Monjalon пишет: >> 07/05/2020 10:53, Ivan Dyukov: >>> 06.05.2020 20:42, Ferruh Yigit пишет: >>>> On 4/27/2020 10:57 AM, Ivan Dyukov wrote: >>>>> This is initial patchset which introduces UNKNOWN speed to dpdk >>>>> applications. Also it contains changes related to printf formating. >>>>> Patchset contains changes for app/ and doc/ folders. >>>>> examples/ folder will be provided later. >>>>> >>>>> >>>> Also I can see there are some physical PMDs that are using 'ETH_SPEED_NUM_NONE' >>>> as unknown, can we fix them as part of this set? >>>> >>> Initially, we had a plan to use UNKNOWN only for virtual devices. >>> >>> Thomas, could you please comment this? >> No I think UNKNOWN must be used also for HW devices which are not able >> to provide a speed value. >> >> In mlx5 case, it can be used to return the link status (up/down) >> even if speed query is failing (it happens with buggy kernel version). >> > Ok. Is ETH_SPEED_NUM_NONE still needed then? could it be replaced by > UNKNOWN everywhere? It is needed, please don't replace it. For example when the link is down, device speed is 'ETH_SPEED_NUM_NONE', but when the link is up but driver doesn't know the speed, for some reason, device speed is 'ETH_SPEED_NUM_UNKNOWN'. First patch says 'ETH_SPEED_NUM_UNKNOWN' is for two cases: - speed is not known by the driver - device is virtual We are talking about first case above.