| Message ID | 20200416080947.55005-1-leyi.rong@intel.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C96E7A0588; Thu, 16 Apr 2020 10:19:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C57C1DB03; Thu, 16 Apr 2020 10:19:14 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9FB251DAFB for <dev@dpdk.org>; Thu, 16 Apr 2020 10:19:12 +0200 (CEST) IronPort-SDR: SFgfy7dNx4jrs699rEG4CGMSjXzIMxgLYUUL2AZYB+3litAAN1v9DQFmPw4CnasMtY6ml5KXtf NIYBFxgbkvHA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 01:19:12 -0700 IronPort-SDR: yCuwEZ4FtQiHwAzWKWKVfCZfnuAqbRTBF1B+1texISc7VYEMAxRXYMB8WQb5c3wDabYKEJjigR V5mpvQ4Ibfzw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="277913289" Received: from dpdk-lrong-srv-04.sh.intel.com ([10.67.119.221]) by fmsmga004.fm.intel.com with ESMTP; 16 Apr 2020 01:19:10 -0700 From: Leyi Rong <leyi.rong@intel.com> To: jingjing.wu@intel.com, qi.z.zhang@intel.com, beilei.xing@intel.com, xiaolong.ye@intel.com Cc: dev@dpdk.org, Leyi Rong <leyi.rong@intel.com> Date: Thu, 16 Apr 2020 16:09:36 +0800 Message-Id: <20200416080947.55005-1-leyi.rong@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200316074603.10998-1-leyi.rong@intel.com> References: <20200316074603.10998-1-leyi.rong@intel.com> Subject: [dpdk-dev] [PATCH v5 00/11] framework for advanced iAVF PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
framework for advanced iAVF PMD
|
|
Message
Leyi Rong
April 16, 2020, 8:09 a.m. UTC
This patchset enable framework for advanced iAVF, includes flexible descriptor support, FDIR mark id and RSS hash support. --- v5: - Set rxdid = 0 in iavf_configure_queues() when it's supported and RTE_LIBRTE_IAVF_16BYTE_RX_DESC is y. So the error can be captured explicitly as kernel PF does not support it yet. - Fix some build errors when RTE_LIBRTE_IAVF_16BYTE_RX_DESC is y. v4: - Avoid initial declaration in 'for' loop to backward-compatible with older gcc versions. v3: - Remove patch to query DDP package info as it's specific to DCF. - Specify fdir_ref_cnt as per VF value for enable/disable FDIR ID parse. - Move fdir_enabled flag to per Queue value for cache benefit when access in vector routines. - Store extracted flow_id value to mbuf without judgement to avoid branch speculation fail, which is benefit to performance. v2: - Revert macro RTE_LIBRTE_IAVF_16BYTE_RX_DESC deletion as it's defined in AVF spec. - Typo RTE_LIBRTE_ICE_16BYTE_RX_DESC fix in iavf_rxtx.c. - Move flex desc definitions into iavf_rxtx.h. - Up to date to match with the latest version of virtchnl.h. - Extract a new internal func iavf_update_rx_tail to call. - Remove iavf_dev_rxq_count_flex_rxd()/iavf_dev_rx_desc_status_flex_rxd(), as the accompanying legacy ones can deal with the flex desc cases. - Move rxq->rxdid assignment from iavf_configure_queues() to iavf_dev_rx_queue_setup(). - Unfold _mm_extract_epi32(fdir_id0_3, i) to fix build error when using GCC compile option -O0. Leyi Rong (11): net/iavf: flexible Rx descriptor definitions net/iavf: return error if opcode is mismatched net/iavf: flexible Rx descriptor support in normal path net/iavf: flexible Rx descriptor support in AVX path net/iavf: flexible Rx descriptor support in SSE path net/iavf: add flow director enabled switch value net/iavf: support flow mark in normal data path net/iavf: support flow mark in AVX path net/iavf: support flow mark in SSE path net/iavf: add RSS hash parsing in AVX path net/iavf: add RSS hash parsing in SSE path drivers/net/iavf/iavf.h | 6 + drivers/net/iavf/iavf_ethdev.c | 8 + drivers/net/iavf/iavf_rxtx.c | 546 ++++++++++++++++++-- drivers/net/iavf/iavf_rxtx.h | 250 +++++++++ drivers/net/iavf/iavf_rxtx_vec_avx2.c | 702 +++++++++++++++++++++++++- drivers/net/iavf/iavf_rxtx_vec_sse.c | 520 +++++++++++++++++++ drivers/net/iavf/iavf_vchnl.c | 59 ++- 7 files changed, 2042 insertions(+), 49 deletions(-)
Comments
> -----Original Message----- > From: Rong, Leyi <leyi.rong@intel.com> > Sent: Thursday, April 16, 2020 4:10 PM > To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Qi Z > <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Ye, Xiaolong > <xiaolong.ye@intel.com> > Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com> > Subject: [PATCH v5 00/11] framework for advanced iAVF PMD > > This patchset enable framework for advanced iAVF, includes flexible > descriptor support, FDIR mark id and RSS hash support. > > --- > v5: > - Set rxdid = 0 in iavf_configure_queues() when it's supported and > RTE_LIBRTE_IAVF_16BYTE_RX_DESC is y. So the error can be captured > explicitly as kernel PF does not support it yet. > - Fix some build errors when RTE_LIBRTE_IAVF_16BYTE_RX_DESC is y. > > v4: > - Avoid initial declaration in 'for' loop to backward-compatible > with older gcc versions. > > v3: > - Remove patch to query DDP package info as it's specific to DCF. > - Specify fdir_ref_cnt as per VF value for enable/disable FDIR ID parse. > - Move fdir_enabled flag to per Queue value for cache benefit when > access in vector routines. > - Store extracted flow_id value to mbuf without judgement to avoid > branch speculation fail, which is benefit to performance. > > v2: > - Revert macro RTE_LIBRTE_IAVF_16BYTE_RX_DESC deletion as > it's defined in AVF spec. > - Typo RTE_LIBRTE_ICE_16BYTE_RX_DESC fix in iavf_rxtx.c. > - Move flex desc definitions into iavf_rxtx.h. > - Up to date to match with the latest version of virtchnl.h. > - Extract a new internal func iavf_update_rx_tail to call. > - Remove > iavf_dev_rxq_count_flex_rxd()/iavf_dev_rx_desc_status_flex_rxd(), > as the accompanying legacy ones can deal with the flex desc cases. > - Move rxq->rxdid assignment from iavf_configure_queues() > to iavf_dev_rx_queue_setup(). > - Unfold _mm_extract_epi32(fdir_id0_3, i) to fix build error > when using GCC compile option -O0. > > Leyi Rong (11): > net/iavf: flexible Rx descriptor definitions > net/iavf: return error if opcode is mismatched > net/iavf: flexible Rx descriptor support in normal path > net/iavf: flexible Rx descriptor support in AVX path > net/iavf: flexible Rx descriptor support in SSE path > net/iavf: add flow director enabled switch value > net/iavf: support flow mark in normal data path > net/iavf: support flow mark in AVX path > net/iavf: support flow mark in SSE path > net/iavf: add RSS hash parsing in AVX path > net/iavf: add RSS hash parsing in SSE path > > drivers/net/iavf/iavf.h | 6 + > drivers/net/iavf/iavf_ethdev.c | 8 + > drivers/net/iavf/iavf_rxtx.c | 546 ++++++++++++++++++-- > drivers/net/iavf/iavf_rxtx.h | 250 +++++++++ > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 702 > +++++++++++++++++++++++++- drivers/net/iavf/iavf_rxtx_vec_sse.c | > 520 +++++++++++++++++++ > drivers/net/iavf/iavf_vchnl.c | 59 ++- > 7 files changed, 2042 insertions(+), 49 deletions(-) > > -- > 2.17.1 Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>
On 04/16, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Rong, Leyi <leyi.rong@intel.com> >> Sent: Thursday, April 16, 2020 4:10 PM >> To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Qi Z >> <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Ye, Xiaolong >> <xiaolong.ye@intel.com> >> Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com> >> Subject: [PATCH v5 00/11] framework for advanced iAVF PMD >> >> This patchset enable framework for advanced iAVF, includes flexible >> descriptor support, FDIR mark id and RSS hash support. >> >> --- >> v5: >> - Set rxdid = 0 in iavf_configure_queues() when it's supported and >> RTE_LIBRTE_IAVF_16BYTE_RX_DESC is y. So the error can be captured >> explicitly as kernel PF does not support it yet. >> - Fix some build errors when RTE_LIBRTE_IAVF_16BYTE_RX_DESC is y. >> >> v4: >> - Avoid initial declaration in 'for' loop to backward-compatible >> with older gcc versions. >> >> v3: >> - Remove patch to query DDP package info as it's specific to DCF. >> - Specify fdir_ref_cnt as per VF value for enable/disable FDIR ID parse. >> - Move fdir_enabled flag to per Queue value for cache benefit when >> access in vector routines. >> - Store extracted flow_id value to mbuf without judgement to avoid >> branch speculation fail, which is benefit to performance. >> >> v2: >> - Revert macro RTE_LIBRTE_IAVF_16BYTE_RX_DESC deletion as >> it's defined in AVF spec. >> - Typo RTE_LIBRTE_ICE_16BYTE_RX_DESC fix in iavf_rxtx.c. >> - Move flex desc definitions into iavf_rxtx.h. >> - Up to date to match with the latest version of virtchnl.h. >> - Extract a new internal func iavf_update_rx_tail to call. >> - Remove >> iavf_dev_rxq_count_flex_rxd()/iavf_dev_rx_desc_status_flex_rxd(), >> as the accompanying legacy ones can deal with the flex desc cases. >> - Move rxq->rxdid assignment from iavf_configure_queues() >> to iavf_dev_rx_queue_setup(). >> - Unfold _mm_extract_epi32(fdir_id0_3, i) to fix build error >> when using GCC compile option -O0. >> >> Leyi Rong (11): >> net/iavf: flexible Rx descriptor definitions >> net/iavf: return error if opcode is mismatched >> net/iavf: flexible Rx descriptor support in normal path >> net/iavf: flexible Rx descriptor support in AVX path >> net/iavf: flexible Rx descriptor support in SSE path >> net/iavf: add flow director enabled switch value >> net/iavf: support flow mark in normal data path >> net/iavf: support flow mark in AVX path >> net/iavf: support flow mark in SSE path >> net/iavf: add RSS hash parsing in AVX path >> net/iavf: add RSS hash parsing in SSE path >> >> drivers/net/iavf/iavf.h | 6 + >> drivers/net/iavf/iavf_ethdev.c | 8 + >> drivers/net/iavf/iavf_rxtx.c | 546 ++++++++++++++++++-- >> drivers/net/iavf/iavf_rxtx.h | 250 +++++++++ >> drivers/net/iavf/iavf_rxtx_vec_avx2.c | 702 >> +++++++++++++++++++++++++- drivers/net/iavf/iavf_rxtx_vec_sse.c | >> 520 +++++++++++++++++++ >> drivers/net/iavf/iavf_vchnl.c | 59 ++- >> 7 files changed, 2042 insertions(+), 49 deletions(-) >> >> -- >> 2.17.1 > >Reviewed-by: Qi Zhang <qi.z.zhang@intel.com> > > Applied to dpdk-next-net-intel, Thanks.