mbox series

[v3,0/3] mlx: fix build with -fno-common (gcc 10)

Message ID 20200408000900.61896-1-thomas@monjalon.net (mailing list archive)
Headers
Series mlx: fix build with -fno-common (gcc 10) |

Message

Thomas Monjalon April 8, 2020, 12:08 a.m. UTC 
  In GCC 10, -fno-common will be the default.
There are 2 ways of solving issues:
  - add -fcommon
  - stop allocating variables in .h files

In this patchset, the variables are declared extern,
because it is cleaner anyway.


v2: do not initialize global variables and Cc stable
v3: fix rebase


Thomas Monjalon (3):
  common/mlx5: split glue initialization
  common/mlx5: fix build with -fno-common
  net/mlx4: fix build with -fno-common

 drivers/common/mlx5/mlx5_common.c | 82 +++++++++++++++++++------------
 drivers/common/mlx5/mlx5_glue.h   |  2 +-
 drivers/net/mlx4/mlx4.c           |  4 ++
 drivers/net/mlx4/mlx4_glue.h      |  2 +-
 drivers/net/mlx4/mlx4_rxtx.h      |  2 +-
 5 files changed, 57 insertions(+), 35 deletions(-)

Comments

Raslan Darawsheh April 12, 2020, 3:51 p.m. UTC | #1 
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Wednesday, April 8, 2020 3:09 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 0/3] mlx: fix build with -fno-common (gcc 10)
> 
> In GCC 10, -fno-common will be the default.
> There are 2 ways of solving issues:
>   - add -fcommon
>   - stop allocating variables in .h files
> 
> In this patchset, the variables are declared extern,
> because it is cleaner anyway.
> 
> 
> v2: do not initialize global variables and Cc stable
> v3: fix rebase
> 
> 
> Thomas Monjalon (3):
>   common/mlx5: split glue initialization
>   common/mlx5: fix build with -fno-common
>   net/mlx4: fix build with -fno-common
> 
>  drivers/common/mlx5/mlx5_common.c | 82 +++++++++++++++++++--------
> ----
>  drivers/common/mlx5/mlx5_glue.h   |  2 +-
>  drivers/net/mlx4/mlx4.c           |  4 ++
>  drivers/net/mlx4/mlx4_glue.h      |  2 +-
>  drivers/net/mlx4/mlx4_rxtx.h      |  2 +-
>  5 files changed, 57 insertions(+), 35 deletions(-)
> 
> --
> 2.26.0

Series applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh