mbox series

[0/7] add switch filter support for intel DCF

Message ID 20200313010407.18286-1-wei.zhao1@intel.com (mailing list archive)
Headers show
Series add switch filter support for intel DCF | expand

Message

wei.zhao1@intel.com March 13, 2020, 1:04 a.m. UTC
A DCF (Device Config Function) framework has been add for intel device,
this patch set add add switch filter support for it, this set also fix
bugs which block this feature.

This patchset is based on:
[1] https://patchwork.dpdk.org/cover/66480/ : add Intel DCF PMD support

Depends-on: series-8859


wei zhao (7):
  net/ice: enable switch flow on DCF
  net/ice: support for more PPPoE input set
  net/ice: change swicth parser to support flexible mask
  net/ice: add support for MAC VLAN rule
  net/ice: change default tunnle type
  net/ice: add action number check for swicth
  net/ice: fix input set of VLAN item

 config/common_linux                 |   1 +
 drivers/net/ice/ice_dcf_ethdev.c    |  10 +-
 drivers/net/ice/ice_dcf_parent.c    |   7 +
 drivers/net/ice/ice_fdir_filter.c   |   6 +
 drivers/net/ice/ice_generic_flow.c  |  13 +
 drivers/net/ice/ice_generic_flow.h  |   9 +
 drivers/net/ice/ice_hash.c          |   6 +
 drivers/net/ice/ice_switch_filter.c | 461 ++++++++++++++++++----------
 8 files changed, 348 insertions(+), 165 deletions(-)

Comments

Stillwell Jr, Paul M March 13, 2020, 4:12 p.m. UTC | #1
This patch set is confusing to me. Only the DCF can deal with switch rules so why is the ice PMD trying to do anything with switch rules related to DCF?

Paul

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of wei.zhao1@intel.com
> Sent: Thursday, March 12, 2020 6:04 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong
> <xiaolong.ye@intel.com>
> Subject: [dpdk-dev] [PATCH 0/7] add switch filter support for intel DCF
> 
> A DCF (Device Config Function) framework has been add for intel device, this
> patch set add add switch filter support for it, this set also fix bugs which block
> this feature.
> 
> This patchset is based on:
> [1] https://patchwork.dpdk.org/cover/66480/ : add Intel DCF PMD support
> 
> Depends-on: series-8859
> 
> 
> wei zhao (7):
>   net/ice: enable switch flow on DCF
>   net/ice: support for more PPPoE input set
>   net/ice: change swicth parser to support flexible mask
>   net/ice: add support for MAC VLAN rule
>   net/ice: change default tunnle type
>   net/ice: add action number check for swicth
>   net/ice: fix input set of VLAN item
> 
>  config/common_linux                 |   1 +
>  drivers/net/ice/ice_dcf_ethdev.c    |  10 +-
>  drivers/net/ice/ice_dcf_parent.c    |   7 +
>  drivers/net/ice/ice_fdir_filter.c   |   6 +
>  drivers/net/ice/ice_generic_flow.c  |  13 +
>  drivers/net/ice/ice_generic_flow.h  |   9 +
>  drivers/net/ice/ice_hash.c          |   6 +
>  drivers/net/ice/ice_switch_filter.c | 461 ++++++++++++++++++----------
>  8 files changed, 348 insertions(+), 165 deletions(-)
> 
> --
> 2.19.1
Zhang, Qi Z March 15, 2020, 2:19 a.m. UTC | #2
> -----Original Message-----
> From: Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>
> Sent: Saturday, March 14, 2020 12:13 AM
> To: wei.zhao1@intel.com <"Wei Zhao"@dpdk.org>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 0/7] add switch filter support for intel DCF
> 
> This patch set is confusing to me. Only the DCF can deal with switch rules so
> why is the ice PMD trying to do anything with switch rules related to DCF?

Ice pf PMD already implemented the switch rule engine and some parsers for PF only usage
The ice DCF just share same engine and add some new parsers for DCF usage.
And as I explained in another email, it is the case that the same compiled code can support different usage at runtime.

Thanks
Qi

> 
> Paul
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of wei.zhao1@intel.com
> > Sent: Thursday, March 12, 2020 6:04 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong
> > <xiaolong.ye@intel.com>
> > Subject: [dpdk-dev] [PATCH 0/7] add switch filter support for intel
> > DCF
> >
> > A DCF (Device Config Function) framework has been add for intel
> > device, this patch set add add switch filter support for it, this set
> > also fix bugs which block this feature.
> >
> > This patchset is based on:
> > [1] https://patchwork.dpdk.org/cover/66480/ : add Intel DCF PMD
> > support
> >
> > Depends-on: series-8859
> >
> >
> > wei zhao (7):
> >   net/ice: enable switch flow on DCF
> >   net/ice: support for more PPPoE input set
> >   net/ice: change swicth parser to support flexible mask
> >   net/ice: add support for MAC VLAN rule
> >   net/ice: change default tunnle type
> >   net/ice: add action number check for swicth
> >   net/ice: fix input set of VLAN item
> >
> >  config/common_linux                 |   1 +
> >  drivers/net/ice/ice_dcf_ethdev.c    |  10 +-
> >  drivers/net/ice/ice_dcf_parent.c    |   7 +
> >  drivers/net/ice/ice_fdir_filter.c   |   6 +
> >  drivers/net/ice/ice_generic_flow.c  |  13 +
> >  drivers/net/ice/ice_generic_flow.h  |   9 +
> >  drivers/net/ice/ice_hash.c          |   6 +
> >  drivers/net/ice/ice_switch_filter.c | 461
> > ++++++++++++++++++----------
> >  8 files changed, 348 insertions(+), 165 deletions(-)
> >
> > --
> > 2.19.1
>