mbox series

[v3,0/4] Intel iavf and ice PMDs clean up

Message ID 20200115005028.21026-1-haiyue.wang@intel.com (mailing list archive)
Headers show
Series Intel iavf and ice PMDs clean up | expand

Message

Wang, Haiyue Jan. 15, 2020, 12:50 a.m. UTC
a. Remove the unused definitions in osdep.h.

b. Put the common definitions used by Intel net PMDs under the macro
__INTEL_NET_BASE_OSDEP__, which works as an include file, so that it
is easily maintained.

---
v3: update the commit message.
v2: add the osdep.h clean up, which depends on v1 to remove TRUE/FALSE.

Haiyue Wang (4):
  net/iavf: unify the bool type value
  net/ice: unify the bool type value
  common/iavf: osdep.h clean up
  net/ice/base: osdep.h clean up

 drivers/common/iavf/iavf_osdep.h | 107 ++++++++++++++-----------
 drivers/net/iavf/iavf_ethdev.c   |  31 ++++----
 drivers/net/iavf/iavf_rxtx.c     |  34 ++++----
 drivers/net/ice/base/ice_osdep.h | 132 ++++++++++++++++---------------
 drivers/net/ice/ice_ethdev.c     |  22 +++---
 drivers/net/ice/ice_rxtx.c       |  16 ++--
 6 files changed, 178 insertions(+), 164 deletions(-)

Comments

Zhang, Qi Z Jan. 15, 2020, 10:55 a.m. UTC | #1
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Wednesday, January 15, 2020 8:50 AM
> To: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Yang, Qiming <qiming.yang@intel.com>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>
> Subject: [PATCH v3 0/4] Intel iavf and ice PMDs clean up
> 
> a. Remove the unused definitions in osdep.h.
> 
> b. Put the common definitions used by Intel net PMDs under the macro
> __INTEL_NET_BASE_OSDEP__, which works as an include file, so that it is
> easily maintained.
> 
> ---
> v3: update the commit message.
> v2: add the osdep.h clean up, which depends on v1 to remove TRUE/FALSE.
> 
> Haiyue Wang (4):
>   net/iavf: unify the bool type value
>   net/ice: unify the bool type value
>   common/iavf: osdep.h clean up
>   net/ice/base: osdep.h clean up
> 
>  drivers/common/iavf/iavf_osdep.h | 107 ++++++++++++++-----------
>  drivers/net/iavf/iavf_ethdev.c   |  31 ++++----
>  drivers/net/iavf/iavf_rxtx.c     |  34 ++++----
>  drivers/net/ice/base/ice_osdep.h | 132 ++++++++++++++++---------------
>  drivers/net/ice/ice_ethdev.c     |  22 +++---
>  drivers/net/ice/ice_rxtx.c       |  16 ++--
>  6 files changed, 178 insertions(+), 164 deletions(-)
> 
> --
> 2.17.1

Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Ferruh Yigit Jan. 16, 2020, 6:20 p.m. UTC | #2
On 1/15/2020 10:55 AM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Wang, Haiyue <haiyue.wang@intel.com>
>> Sent: Wednesday, January 15, 2020 8:50 AM
>> To: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; Yang, Qiming <qiming.yang@intel.com>
>> Cc: Wang, Haiyue <haiyue.wang@intel.com>
>> Subject: [PATCH v3 0/4] Intel iavf and ice PMDs clean up
>>
>> a. Remove the unused definitions in osdep.h.
>>
>> b. Put the common definitions used by Intel net PMDs under the macro
>> __INTEL_NET_BASE_OSDEP__, which works as an include file, so that it is
>> easily maintained.
>>
>> ---
>> v3: update the commit message.
>> v2: add the osdep.h clean up, which depends on v1 to remove TRUE/FALSE.
>>
>> Haiyue Wang (4):
>>   net/iavf: unify the bool type value
>>   net/ice: unify the bool type value
>>   common/iavf: osdep.h clean up
>>   net/ice/base: osdep.h clean up
>>
>>  drivers/common/iavf/iavf_osdep.h | 107 ++++++++++++++-----------
>>  drivers/net/iavf/iavf_ethdev.c   |  31 ++++----
>>  drivers/net/iavf/iavf_rxtx.c     |  34 ++++----
>>  drivers/net/ice/base/ice_osdep.h | 132 ++++++++++++++++---------------
>>  drivers/net/ice/ice_ethdev.c     |  22 +++---
>>  drivers/net/ice/ice_rxtx.c       |  16 ++--
>>  6 files changed, 178 insertions(+), 164 deletions(-)
>>
>> --
>> 2.17.1
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> 

For record, this version (v3) seems merged to next-net-intel, although the merge
note is in v2 [1].


[1] https://mails.dpdk.org/archives/dev/2020-January/155356.html