From patchwork Mon Nov 11 13:19:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 62833 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 784B9A04B9; Mon, 11 Nov 2019 14:19:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0A16CF3; Mon, 11 Nov 2019 14:19:22 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 4D1FFB62 for ; Mon, 11 Nov 2019 14:19:21 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xABDFPWG001129; Mon, 11 Nov 2019 05:19:20 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pfpt0818; bh=v2VT21rO1Wx5P1FZpzWyPO/Qu//z3W7XFofbVNYqN/0=; b=htQXzC3ZfSiil95ThiGMQwle4gH98be5opzaaPRN2SYhNSxpgG9CKvv7nAwcgGoQXyJI iqt4c9bCgYW5q7dEYtjMS43DSQBOGil9ONFclJnzJCGmh7+8a4vrTKKWosZZ8MnQLj+B sTmRtYlgtIRb8dx1nrlKC71gd104M3k1Tp/2DmgygBHIsaQBIRFbOhta6T4NhTg1mieW XmP0So9sv9Qb4NeYfy7Cr5PGVgswWgt6Cnuh2A5UynkpY6L73oBQuQ2hgx5zKYaUlVMI NHXwSJc3FXWBNCi5W+XirJAr6+/wxXNR8Iaa+oZ4F+iRbyEWPJ9Tk3AwQknJUtaEJnKT Eg== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2w5upuxv6t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 11 Nov 2019 05:19:19 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 11 Nov 2019 05:19:18 -0800 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Mon, 11 Nov 2019 05:19:18 -0800 Received: from BG-LT7430.marvell.com (unknown [10.28.17.38]) by maili.marvell.com (Postfix) with ESMTP id 46DB93F703F; Mon, 11 Nov 2019 05:19:15 -0800 (PST) From: To: , , , CC: , Pavan Nikhilesh Date: Mon, 11 Nov 2019 18:49:04 +0530 Message-ID: <20191111131914.16559-1-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191106191803.15098-1-pbhagavatula@marvell.com> References: <20191106191803.15098-1-pbhagavatula@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-11_03:2019-11-11,2019-11-11 signatures=0 Subject: [dpdk-dev] [PATCH v17 00/10] ethdev: add new Rx offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavan Nikhilesh Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` These flags can be used to enable/disable PMD writes to rte_mbuf fields `hash.rss` and also `ol_flags:PKT_RX_RSS`. Add new packet type set function `rte_eth_dev_set_ptypes`, allows application to inform PMDs about the packet types it is interested in. Based on ptypes requested by application PMDs can optimize the Rx path. For example, if a given PMD doesn't support any packet types that the application is interested in then the application can disable[1] writes to `mbuf.packet_type` done by the PMD and use a software ptype parser. [1] rte_eth_dev_set_ptypes(*port_id*, RTE_PTYPE_UNKNOWN, NULL, 0); v17 Changes: ----------- - Split 8/8 into two patches. - Add rss_hash to port rx_offloads in testpmd. - Add log when set_ptype fails. - Fix few spell check. v16 Changes: ----------- - Fix testpmd documentation(Bernard). - s/rte_eth_dev_set_supported_ptypes/rte_eth_dev_set_ptypes. - Fix release notes placement. - Enhance offload validation(Andrew). - Remove if condition in drivers/net while enabling RSS_HASH by default. - Spilt 5/7 into two patches. v15 Changes: ----------- - Fix sfc RSS_HASH offload check. - Fix ethdev RSS_HASH offload check when mq_mode is configured with MQ_RX_NONE. - Extend offload validation to return error in the case where application has requested an offload to be enabled and PMD couldn't honor it. v14 Changes: ----------- - Remove log from drives - Add log in rte_eth_dev_configure when certain offloads are requested to be disabled and PMD cannot honor the request. - Make changes to default offloads in net/sfc.(Andrew) v13 Changes: ----------- - Remove DEV_RX_OFFLOAD_FLOW_MARK from this patchset to allow foreward progress will be sent as a seperate patch. - Use set_supported function only for l2fwd and testpmd. - Add info log in drivers which expose the DEV_RX_OFFLOAD_RSS_HASH indicating that disabling DEV_RX_OFFLOAD_RSS_HASH is not supported. - Few documentation changes. v12 Changes: ----------- - Rebase onto next-net. v11 Changes: ----------- - Use RTE_DIM to get array size. - Since we are using a list of MASKs to validate ptype_mask return -EINVAL if any unknown mask is set. - Rebase to TOT. v10 Changes: ----------- - Modify ptype_mask validation in set_supported_ptypes.(Andrew) v9 Changes: ---------- - Add ptype_mask validation in set_supported_ptypes.(Andrew) - Make description more verbose. v8 Changes: ---------- - Make description more verbose. - Set RTE_PTYPE_UNKNOWN in set_ptypes array when either get ot set ptypes is not supported by ethernet device. v7 Changes: ---------- - Fix unused variable in net/octeontx2 v6 Changes: ---------- - Add additional checks for set supported ptypes.(Andrew) - Clarify `rte_eth_dev_set_supported_ptypes` documentation. - Remove DEV_RX_OFFLOAD_FLOW_MARK emulation from net/octeontx2. v5 Changes: ---------- - Fix typos. v4 Changes: ---------- - Set the last element in set_ptype array as RTE_PTYPE_UNKNOWN to mark the end of array. - Fix invalid set ptype function call in examples. - Remove setting rte_eth_dev_set_supported_ptypes to UNKNOWN in l3fwd-power. v3 Changes: ---------- - Add missing release notes. (Andrew) - Re-word various descriptions. - Fix ptype set logic. v2 Changes: ---------- - Update release notes. (Andrew) - Redo commit logs. (Andrew) - Disable ptype parsing for unsupported examples. (Jerin) - Disable RSS write only in generic mode eventdev_pipeline. (Jerin) - Modify set_supported_ptypes function to return successfuly set mask instead of failure. - Dropped set_supported_ptypes to drivers by handling in library layer, interested PMD can add it in. Pavan Nikhilesh (10): ethdev: add set ptype function ethdev: add mbuf RSS update as an offload ethdev: add validation to offloads set by PMD drivers/net: update Rx RSS hash offload capabilities examples/eventdev_pipeline: split port init sequence examples/eventdev_pipeline: add new Rx RSS hash offload examples/l2fwd: disable ptype parsing app/testpmd: add command to set supported ptype mask app/testpmd: disable packet type parsing by default app/testpmd: add RSS hash offload to port Rx offload cmd app/test-pmd/cmdline.c | 90 ++++++++- app/test-pmd/testpmd.c | 12 ++ app/test-pmd/testpmd.h | 1 + doc/guides/nics/features.rst | 9 +- doc/guides/rel_notes/release_19_11.rst | 15 ++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +- drivers/net/bnxt/bnxt_ethdev.c | 6 +- drivers/net/cxgbe/cxgbe.h | 3 +- drivers/net/cxgbe/cxgbe_ethdev.c | 2 + drivers/net/dpaa/dpaa_ethdev.c | 3 +- drivers/net/dpaa2/dpaa2_ethdev.c | 1 + drivers/net/e1000/igb_ethdev.c | 4 + drivers/net/e1000/igb_rxtx.c | 3 +- drivers/net/enic/enic_ethdev.c | 2 + drivers/net/enic/enic_res.c | 3 +- drivers/net/fm10k/fm10k_ethdev.c | 5 +- drivers/net/hinic/hinic_pmd_ethdev.c | 5 +- drivers/net/i40e/i40e_ethdev.c | 5 +- drivers/net/iavf/iavf_ethdev.c | 5 +- drivers/net/ice/ice_ethdev.c | 5 +- drivers/net/ixgbe/ixgbe_ethdev.c | 5 + drivers/net/ixgbe/ixgbe_rxtx.c | 3 +- drivers/net/liquidio/lio_ethdev.c | 5 +- drivers/net/mlx4/mlx4.c | 2 + drivers/net/mlx4/mlx4_rxq.c | 3 +- drivers/net/mlx5/mlx5_ethdev.c | 3 + drivers/net/mlx5/mlx5_rxq.c | 3 +- drivers/net/netvsc/hn_ethdev.c | 2 + drivers/net/netvsc/hn_rndis.c | 3 +- drivers/net/nfp/nfp_net.c | 5 +- drivers/net/octeontx2/otx2_ethdev.c | 3 +- drivers/net/octeontx2/otx2_ethdev.h | 15 +- drivers/net/qede/qede_ethdev.c | 5 +- drivers/net/sfc/sfc_ef10_essb_rx.c | 3 +- drivers/net/sfc/sfc_ef10_rx.c | 3 +- drivers/net/sfc/sfc_rx.c | 7 +- drivers/net/thunderx/nicvf_ethdev.c | 2 + drivers/net/thunderx/nicvf_ethdev.h | 3 +- drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 +- examples/eventdev_pipeline/main.c | 128 ------------ .../pipeline_worker_generic.c | 132 +++++++++++++ .../eventdev_pipeline/pipeline_worker_tx.c | 128 ++++++++++++ examples/l2fwd/Makefile | 2 + examples/l2fwd/main.c | 5 + examples/l2fwd/meson.build | 2 + lib/librte_ethdev/rte_ethdev.c | 182 +++++++++++++++++- lib/librte_ethdev/rte_ethdev.h | 37 ++++ lib/librte_ethdev/rte_ethdev_core.h | 17 ++ lib/librte_ethdev/rte_ethdev_version.map | 1 + 49 files changed, 731 insertions(+), 171 deletions(-) Reviewed-by: Ferruh Yigit --- 2.17.1