mbox series

[v2,0/6] examples/ioat: sample app on ioat driver usage

Message ID 20190913143914.2332-1-marcinx.baran@intel.com (mailing list archive)
Headers
Series examples/ioat: sample app on ioat driver usage |

Message

Marcin Baran Sept. 13, 2019, 2:39 p.m. UTC 
  A new sample app demonstrating use of driver for CBDMA.
The app receives packets, performs software or hardware
copy, changes packets' MAC addresses (if enabled) and
forwards them. The patch includes sample application as
well as it's guide.

v2:
 - change printing total stats to be deltas
 - update documentation
 - fix 1 thread/sw copy/multiple Rx queues packet dropping
 - divide patch into several presenting functional change

Marcin Baran (4):
  examples/ioat: add software copy support
  examples/ioat: add rawdev copy mode support
  examples/ioat: add stats printing for each port
  doc/guides/: provide IOAT sample app guide

Pawel Modrak (2):
  examples/ioat: create sample app on ioat driver usage
  examples/ioat: add two threads configuration

 doc/guides/sample_app_ug/index.rst |    1 +
 doc/guides/sample_app_ug/intro.rst |    4 +
 doc/guides/sample_app_ug/ioat.rst  |  764 +++++++++++++++++++++
 examples/Makefile                  |    3 +
 examples/ioat/Makefile             |   54 ++
 examples/ioat/ioatfwd.c            | 1025 ++++++++++++++++++++++++++++
 examples/ioat/meson.build          |   13 +
 examples/meson.build               |    1 +
 8 files changed, 1865 insertions(+)
 create mode 100644 doc/guides/sample_app_ug/ioat.rst
 create mode 100644 examples/ioat/Makefile
 create mode 100644 examples/ioat/ioatfwd.c
 create mode 100644 examples/ioat/meson.build

Comments

Aaron Conole Sept. 13, 2019, 6:45 p.m. UTC | #1 
Marcin Baran <marcinx.baran@intel.com> writes:

> A new sample app demonstrating use of driver for CBDMA.
> The app receives packets, performs software or hardware
> copy, changes packets' MAC addresses (if enabled) and
> forwards them. The patch includes sample application as
> well as it's guide.

Please fix the dependencies:

https://travis-ci.com/ovsrobot/dpdk/jobs/234891633

examples/meson.build:89:4: ERROR: Problem encountered: Missing
dependency "pmd_ioat" for example "ioat"


> v2:
>  - change printing total stats to be deltas
>  - update documentation
>  - fix 1 thread/sw copy/multiple Rx queues packet dropping
>  - divide patch into several presenting functional change
>
> Marcin Baran (4):
>   examples/ioat: add software copy support
>   examples/ioat: add rawdev copy mode support
>   examples/ioat: add stats printing for each port
>   doc/guides/: provide IOAT sample app guide
>
> Pawel Modrak (2):
>   examples/ioat: create sample app on ioat driver usage
>   examples/ioat: add two threads configuration
>
>  doc/guides/sample_app_ug/index.rst |    1 +
>  doc/guides/sample_app_ug/intro.rst |    4 +
>  doc/guides/sample_app_ug/ioat.rst  |  764 +++++++++++++++++++++
>  examples/Makefile                  |    3 +
>  examples/ioat/Makefile             |   54 ++
>  examples/ioat/ioatfwd.c            | 1025 ++++++++++++++++++++++++++++
>  examples/ioat/meson.build          |   13 +
>  examples/meson.build               |    1 +
>  8 files changed, 1865 insertions(+)
>  create mode 100644 doc/guides/sample_app_ug/ioat.rst
>  create mode 100644 examples/ioat/Makefile
>  create mode 100644 examples/ioat/ioatfwd.c
>  create mode 100644 examples/ioat/meson.build
Marcin Baran Sept. 16, 2019, 9:42 a.m. UTC | #2 
-----Original Message-----
From: Aaron Conole <aconole@redhat.com> 
Sent: Friday, September 13, 2019 8:45 PM
To: Baran, MarcinX <marcinx.baran@intel.com>
Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/6] examples/ioat: sample app on ioat driver usage

Marcin Baran <marcinx.baran@intel.com> writes:

> A new sample app demonstrating use of driver for CBDMA.
> The app receives packets, performs software or hardware copy, changes 
> packets' MAC addresses (if enabled) and forwards them. The patch 
> includes sample application as well as it's guide.

Please fix the dependencies:

https://travis-ci.com/ovsrobot/dpdk/jobs/234891633

examples/meson.build:89:4: ERROR: Problem encountered: Missing dependency "pmd_ioat" for example "ioat"

[Marcin]: I will add check for dependency in example's  meson.build for v3:

	if not dpdk_conf.has('RTE_LIBRTE_PMD_IOAT_RAWDEV')
		build = false
		subdir_done()
	endif

> v2:
>  - change printing total stats to be deltas
>  - update documentation
>  - fix 1 thread/sw copy/multiple Rx queues packet dropping
>  - divide patch into several presenting functional change
>
> Marcin Baran (4):
>   examples/ioat: add software copy support
>   examples/ioat: add rawdev copy mode support
>   examples/ioat: add stats printing for each port
>   doc/guides/: provide IOAT sample app guide
>
> Pawel Modrak (2):
>   examples/ioat: create sample app on ioat driver usage
>   examples/ioat: add two threads configuration
>
>  doc/guides/sample_app_ug/index.rst |    1 +
>  doc/guides/sample_app_ug/intro.rst |    4 +
>  doc/guides/sample_app_ug/ioat.rst  |  764 +++++++++++++++++++++
>  examples/Makefile                  |    3 +
>  examples/ioat/Makefile             |   54 ++
>  examples/ioat/ioatfwd.c            | 1025 ++++++++++++++++++++++++++++
>  examples/ioat/meson.build          |   13 +
>  examples/meson.build               |    1 +
>  8 files changed, 1865 insertions(+)
>  create mode 100644 doc/guides/sample_app_ug/ioat.rst  create mode 
> 100644 examples/ioat/Makefile  create mode 100644 
> examples/ioat/ioatfwd.c  create mode 100644 examples/ioat/meson.build
Aaron Conole Sept. 19, 2019, 9:19 a.m. UTC | #3 
"Baran, MarcinX" <marcinx.baran@intel.com> writes:

> -----Original Message-----
> From: Aaron Conole <aconole@redhat.com> 
> Sent: Friday, September 13, 2019 8:45 PM
> To: Baran, MarcinX <marcinx.baran@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 0/6] examples/ioat: sample app on ioat driver usage
>
> Marcin Baran <marcinx.baran@intel.com> writes:
>
>> A new sample app demonstrating use of driver for CBDMA.
>> The app receives packets, performs software or hardware copy, changes 
>> packets' MAC addresses (if enabled) and forwards them. The patch 
>> includes sample application as well as it's guide.
>
> Please fix the dependencies:
>
> https://travis-ci.com/ovsrobot/dpdk/jobs/234891633
>
> examples/meson.build:89:4: ERROR: Problem encountered: Missing dependency "pmd_ioat" for example "ioat"
>
> [Marcin]: I will add check for dependency in example's  meson.build for v3:
>
> 	if not dpdk_conf.has('RTE_LIBRTE_PMD_IOAT_RAWDEV')
> 		build = false
> 		subdir_done()
> 	endif

Seems it didn't work in v3:

https://travis-ci.com/ovsrobot/dpdk/builds/128147569

-Aaron

>> v2:
>>  - change printing total stats to be deltas
>>  - update documentation
>>  - fix 1 thread/sw copy/multiple Rx queues packet dropping
>>  - divide patch into several presenting functional change
>>
>> Marcin Baran (4):
>>   examples/ioat: add software copy support
>>   examples/ioat: add rawdev copy mode support
>>   examples/ioat: add stats printing for each port
>>   doc/guides/: provide IOAT sample app guide
>>
>> Pawel Modrak (2):
>>   examples/ioat: create sample app on ioat driver usage
>>   examples/ioat: add two threads configuration
>>
>>  doc/guides/sample_app_ug/index.rst |    1 +
>>  doc/guides/sample_app_ug/intro.rst |    4 +
>>  doc/guides/sample_app_ug/ioat.rst  |  764 +++++++++++++++++++++
>>  examples/Makefile                  |    3 +
>>  examples/ioat/Makefile             |   54 ++
>>  examples/ioat/ioatfwd.c            | 1025 ++++++++++++++++++++++++++++
>>  examples/ioat/meson.build          |   13 +
>>  examples/meson.build               |    1 +
>>  8 files changed, 1865 insertions(+)
>>  create mode 100644 doc/guides/sample_app_ug/ioat.rst  create mode 
>> 100644 examples/ioat/Makefile  create mode 100644 
>> examples/ioat/ioatfwd.c  create mode 100644 examples/ioat/meson.build