From patchwork Thu Nov 1 19:53:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alejandro Lucero X-Patchwork-Id: 47690 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 773B71B146; Thu, 1 Nov 2018 20:53:34 +0100 (CET) Received: from netronome.com (host-79-78-33-110.static.as9105.net [79.78.33.110]) by dpdk.org (Postfix) with ESMTP id 2705A1B0FF for ; Thu, 1 Nov 2018 20:53:31 +0100 (CET) Received: from netronome.com (localhost [127.0.0.1]) by netronome.com (8.15.2/8.15.2/Debian-10) with ESMTP id wA1JrU0j019515 for ; Thu, 1 Nov 2018 19:53:30 GMT Received: (from root@localhost) by netronome.com (8.15.2/8.15.2/Submit) id wA1JrUXk019514 for dev@dpdk.org; Thu, 1 Nov 2018 19:53:30 GMT From: Alejandro Lucero To: dev@dpdk.org Date: Thu, 1 Nov 2018 19:53:23 +0000 Message-Id: <20181101195330.19464-1-alejandro.lucero@netronome.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH v2 0/7] fix DMA mask check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A patchset sent introducing DMA mask checks has several critical issues precluding apps to execute. The patchset was reviewed and finally accepted after three versions. Obviously it did not go through the proper testing what can be explained, at least from my side, due to the big changes to the memory initialization code these last months. It turns out the patchset did work with legacy memory and I'm afraid that was mainly my testing. This patchset should solve the main problems reported: - deadlock duriing initialization - segmentation fault with secondary processes For solving the deadlock, a new API is introduced: rte_mem_check_dma_mask_safe/unsafe making the previous rte_mem_check_dma_mask the one those new functions end calling. A boolean param is used for calling rte_memseg_walk thread safe or thread unsafe. This second option is needed for avoiding the deadlock. For the secondary processes problem, the call to check the dma mask is avoided from code being executed before the memory initialization. Instead, a new API function, rte_mem_set_dma_mask is introduced, which will be used in those cases. The dma mask check is done once the memory initialization is completed. This last change implies the IOVA mode can not be set depending on IOMMU hardware limitations, and it is assumed IOVA VA is possible. If the dma mask check reports a problem after memory initilization, the error message includes now advice for trying with --iova-mode option set to pa. The patchet also includes the dma mask check for legacy memory and the no hugepage option. Finally, all the DMA mask API has been updated for using the same prefix than other EAL memory code. An initial version of this patchset has been tested by Intel DPDK Validation team and it seems it solves all the problems reported. This final patchset has the same functionality with minor changes. I have successfully tested the patchset with my limited testbench. v2: - modify error messages with more descriptive information - change safe/unsafe versions for dma check to previous one plus a thread_unsafe version. - use rte_eal_using_phys_addr instead of getuid - fix comments - reorder patches Alejandro Lucero (7): mem: fix call to DMA mask check mem: use proper prefix mem: add function for setting DMA mask bus/pci: avoid call to DMA mask check mem: modify error message for DMA mask check eal/mem: use DMA mask check for legacy memory mem: add thread unsafe version for checking DMA mask doc/guides/rel_notes/release_18_11.rst | 2 +- drivers/bus/pci/linux/pci.c | 11 +++++- drivers/net/nfp/nfp_net.c | 2 +- lib/librte_eal/common/eal_common_memory.c | 42 +++++++++++++++++++-- lib/librte_eal/common/include/rte_memory.h | 41 ++++++++++++++++++++- lib/librte_eal/common/malloc_heap.c | 43 ++++++++++++++++++---- lib/librte_eal/linuxapp/eal/eal_memory.c | 20 ++++++++++ lib/librte_eal/rte_eal_version.map | 4 +- 8 files changed, 148 insertions(+), 17 deletions(-) Tested-by: Ferruh Yigit