mbox series

[v4,0/2] vhost: packed ring support completion

Message ID 20181031102640.15377-1-maxime.coquelin@redhat.com (mailing list archive)
Headers
Series vhost: packed ring support completion |

Message

Maxime Coquelin Oct. 31, 2018, 10:26 a.m. UTC 
  In this v4, it restores back to only save last avail index and
its wrap counter value at get time, and restore both used
and avail indexes to avail values at set time.
The change compared to v1 is that wrap counter value is
saved into bit 15, so that it is consistent with the event
suppression structure format.

Initial series ading packed ring layout support to the
vhost library was missing the save and restore of the
wrap counters and indexs on vring base requests used for
migration.

First patch saves/restores the used and avail indexes and their
wrap counters values into/from the vring state num field.

Maxime Coquelin (2):
  vhost: add packed ring support to vring base requests
  vhost: advertize packed ring layout support

 lib/librte_vhost/vhost.h      |  3 ++-
 lib/librte_vhost/vhost_user.c | 40 +++++++++++++++++++++++++++++------
 2 files changed, 36 insertions(+), 7 deletions(-)

Comments

Tiwei Bie Nov. 2, 2018, 1:42 p.m. UTC | #1 
On Wed, Oct 31, 2018 at 11:26:38AM +0100, Maxime Coquelin wrote:
> In this v4, it restores back to only save last avail index and
> its wrap counter value at get time, and restore both used
> and avail indexes to avail values at set time.
> The change compared to v1 is that wrap counter value is
> saved into bit 15, so that it is consistent with the event
> suppression structure format.
> 
> Initial series ading packed ring layout support to the
> vhost library was missing the save and restore of the
> wrap counters and indexs on vring base requests used for
> migration.
> 
> First patch saves/restores the used and avail indexes and their
> wrap counters values into/from the vring state num field.
> 
> Maxime Coquelin (2):
>   vhost: add packed ring support to vring base requests
>   vhost: advertize packed ring layout support
> 
>  lib/librte_vhost/vhost.h      |  3 ++-
>  lib/librte_vhost/vhost_user.c | 40 +++++++++++++++++++++++++++++------
>  2 files changed, 36 insertions(+), 7 deletions(-)
> 
> -- 
> 2.17.2
> 

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks!
Maxime Coquelin Nov. 2, 2018, 2:48 p.m. UTC | #2 
On 11/2/18 2:42 PM, Tiwei Bie wrote:
> On Wed, Oct 31, 2018 at 11:26:38AM +0100, Maxime Coquelin wrote:
>> In this v4, it restores back to only save last avail index and
>> its wrap counter value at get time, and restore both used
>> and avail indexes to avail values at set time.
>> The change compared to v1 is that wrap counter value is
>> saved into bit 15, so that it is consistent with the event
>> suppression structure format.
>>
>> Initial series ading packed ring layout support to the
>> vhost library was missing the save and restore of the
>> wrap counters and indexs on vring base requests used for
>> migration.
>>
>> First patch saves/restores the used and avail indexes and their
>> wrap counters values into/from the vring state num field.
>>
>> Maxime Coquelin (2):
>>    vhost: add packed ring support to vring base requests
>>    vhost: advertize packed ring layout support
>>
>>   lib/librte_vhost/vhost.h      |  3 ++-
>>   lib/librte_vhost/vhost_user.c | 40 +++++++++++++++++++++++++++++------
>>   2 files changed, 36 insertions(+), 7 deletions(-)
>>
>> -- 
>> 2.17.2
>>
> 
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
> 
> Thanks!
> 

Applied to dpdk-next-virtio/master

Maxime