mbox series

[v4,0/4] eal: allow hotplug to skip an already probed device

Message ID 20181011210251.7705-1-thomas@monjalon.net (mailing list archive)
Headers
Series eal: allow hotplug to skip an already probed device |

Message

Thomas Monjalon Oct. 11, 2018, 9:02 p.m. UTC
  This is a follow-up of an idea presented at Dublin
during the "hotplug talk".

The idea is to ease probing of range of ports attached
to the same rte_device.
I becomes possible to allow probing again the same device
but with a bigger range of ports in the devargs.

Instead of adding a parameter to the hotplug functions, as in the RFC,
the check of an already probed device is moved to the bus and enabled PMDs.
It gives flexibility to drivers for managing range of ports.


Changes in v4 - after Andrew's review:
  - remove access to rte_device.driver during probing (patch 1)

Changes in v3 - after Declan's review:
  - return error in all buses but PCI
  - add a PCI driver flag to enable feature per driver
  - return -EEXIST if probing again is not supported


Thomas Monjalon (4):
  ethdev: rename memzones allocated for DMA
  drivers/bus: move driver assignment to end of probing
  eal: add function to query device status
  eal: allow probing a device again

 drivers/bus/dpaa/dpaa_bus.c             |  3 ++
 drivers/bus/fslmc/fslmc_bus.c           |  3 ++
 drivers/bus/ifpga/ifpga_bus.c           | 21 +++++++-------
 drivers/bus/pci/pci_common.c            | 38 ++++++++++++++++---------
 drivers/bus/pci/rte_bus_pci.h           |  6 ++--
 drivers/bus/vdev/vdev.c                 | 12 +++++---
 drivers/bus/vmbus/vmbus_common.c        |  5 ++--
 drivers/net/i40e/i40e_vf_representor.c  |  3 --
 drivers/net/mlx4/mlx4.c                 |  1 -
 drivers/net/mlx5/mlx5.c                 |  1 -
 lib/librte_eal/common/eal_common_dev.c  | 14 +++++----
 lib/librte_eal/common/include/rte_dev.h | 18 ++++++++++--
 lib/librte_eal/rte_eal_version.map      |  1 +
 lib/librte_ethdev/rte_ethdev.c          |  5 ++--
 14 files changed, 84 insertions(+), 47 deletions(-)
  

Comments

Andrew Rybchenko Oct. 12, 2018, 9:26 a.m. UTC | #1
On 10/12/18 12:02 AM, Thomas Monjalon wrote:
> This is a follow-up of an idea presented at Dublin
> during the "hotplug talk".
>
> The idea is to ease probing of range of ports attached
> to the same rte_device.
> I becomes possible to allow probing again the same device
> but with a bigger range of ports in the devargs.
>
> Instead of adding a parameter to the hotplug functions, as in the RFC,
> the check of an already probed device is moved to the bus and enabled PMDs.
> It gives flexibility to drivers for managing range of ports.

For the series:
Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>

As I underestand it requires fix for szedata2 and has open
questions for mlx5, bnx2x, cxgbe and testpmd.