Message ID | 20180719083959.41480-1-pablo.de.lara.guarch@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 63DF65681; Thu, 19 Jul 2018 18:46:37 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D326D160 for <dev@dpdk.org>; Thu, 19 Jul 2018 18:46:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 09:46:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,375,1526367600"; d="scan'208";a="247109919" Received: from silpixa00399466.ir.intel.com (HELO silpixa00399466.ger.corp.intel.com) ([10.237.223.220]) by fmsmga006.fm.intel.com with ESMTP; 19 Jul 2018 09:46:08 -0700 From: Pablo de Lara <pablo.de.lara.guarch@intel.com> To: declan.doherty@intel.com, fiona.trahe@intel.com Cc: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com> Date: Thu, 19 Jul 2018 09:39:54 +0100 Message-Id: <20180719083959.41480-1-pablo.de.lara.guarch@intel.com> X-Mailer: git-send-email 2.14.4 In-Reply-To: <20180717103815.26841-1-pablo.de.lara.guarch@intel.com> References: <20180717103815.26841-1-pablo.de.lara.guarch@intel.com> Subject: [dpdk-dev] [PATCH v2 0/5] L2fwd-crypto fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
L2fwd-crypto fixes
|
|
Message
De Lara Guarch, Pablo
July 19, 2018, 8:39 a.m. UTC
v2 changes: - Split patch into multiple patches for better review - First two patches are fixes for previous releases Pablo de Lara (5): examples/l2fwd-crypto: check return value on IV size check examples/l2fwd-crypto: skip device not supporting operation examples/l2fwd-crypto: separate IV check from xform setting examples/l2fwd-crypto: fix session mempool size examples/l2fwd-crypto: remove duplicated capability check examples/l2fwd-crypto/main.c | 539 +++++++++++++++++++++++++++---------------- 1 file changed, 340 insertions(+), 199 deletions(-)
Comments
Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Thursday, July 19, 2018 9:40 AM > To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona <fiona.trahe@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> > Subject: [PATCH v2 0/5] L2fwd-crypto fixes > > v2 changes: > - Split patch into multiple patches for better review > - First two patches are fixes for previous releases > > Pablo de Lara (5): > examples/l2fwd-crypto: check return value on IV size check > examples/l2fwd-crypto: skip device not supporting operation > examples/l2fwd-crypto: separate IV check from xform setting > examples/l2fwd-crypto: fix session mempool size > examples/l2fwd-crypto: remove duplicated capability check > > examples/l2fwd-crypto/main.c | 539 +++++++++++++++++++++++++++---------------- > 1 file changed, 340 insertions(+), 199 deletions(-) > > -- > 2.14.4 One minor comment in patch 4, apart from that Series-acked-by: Fiona Trahe <fiona.trahe@intel.com>
Hi Fiona, > -----Original Message----- > From: Trahe, Fiona > Sent: Friday, July 20, 2018 10:02 AM > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan > <declan.doherty@intel.com> > Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com> > Subject: RE: [PATCH v2 0/5] L2fwd-crypto fixes > > Hi Pablo, > > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Thursday, July 19, 2018 9:40 AM > > To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona > <fiona.trahe@intel.com> > > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> > > Subject: [PATCH v2 0/5] L2fwd-crypto fixes > > > > v2 changes: > > - Split patch into multiple patches for better review > > - First two patches are fixes for previous releases > > > > Pablo de Lara (5): > > examples/l2fwd-crypto: check return value on IV size check > > examples/l2fwd-crypto: skip device not supporting operation > > examples/l2fwd-crypto: separate IV check from xform setting > > examples/l2fwd-crypto: fix session mempool size > > examples/l2fwd-crypto: remove duplicated capability check > > > > examples/l2fwd-crypto/main.c | 539 +++++++++++++++++++++++++++--------- > ------- > > 1 file changed, 340 insertions(+), 199 deletions(-) > > > > -- > > 2.14.4 > One minor comment in patch 4, apart from that > Series-acked-by: Fiona Trahe <fiona.trahe@intel.com> Thanks for the review. I will make that change on the fly when applying the patchset, as it is a minor change, to avoid spam.
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, July 20, 2018 11:41 AM > To: Trahe, Fiona <fiona.trahe@intel.com>; Doherty, Declan > <declan.doherty@intel.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/5] L2fwd-crypto fixes > > Hi Fiona, > > > -----Original Message----- > > From: Trahe, Fiona > > Sent: Friday, July 20, 2018 10:02 AM > > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, > > Declan <declan.doherty@intel.com> > > Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com> > > Subject: RE: [PATCH v2 0/5] L2fwd-crypto fixes > > > > Hi Pablo, > > > > > -----Original Message----- > > > From: De Lara Guarch, Pablo > > > Sent: Thursday, July 19, 2018 9:40 AM > > > To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona > > <fiona.trahe@intel.com> > > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > > <pablo.de.lara.guarch@intel.com> > > > Subject: [PATCH v2 0/5] L2fwd-crypto fixes > > > > > > v2 changes: > > > - Split patch into multiple patches for better review > > > - First two patches are fixes for previous releases > > > > > > Pablo de Lara (5): > > > examples/l2fwd-crypto: check return value on IV size check > > > examples/l2fwd-crypto: skip device not supporting operation > > > examples/l2fwd-crypto: separate IV check from xform setting > > > examples/l2fwd-crypto: fix session mempool size > > > examples/l2fwd-crypto: remove duplicated capability check > > > > > > examples/l2fwd-crypto/main.c | 539 > > > +++++++++++++++++++++++++++--------- > > ------- > > > 1 file changed, 340 insertions(+), 199 deletions(-) > > > > > > -- > > > 2.14.4 > > One minor comment in patch 4, apart from that > > Series-acked-by: Fiona Trahe <fiona.trahe@intel.com> > > Thanks for the review. I will make that change on the fly when applying the > patchset, as it is a minor change, to avoid spam. Series applied to dpdk-next-crypto, with change requested. Pablo