From patchwork Thu Jun 7 23:54:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Gora X-Patchwork-Id: 40788 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 64BA85F2F; Fri, 8 Jun 2018 01:54:36 +0200 (CEST) Received: from mail-qt0-f194.google.com (mail-qt0-f194.google.com [209.85.216.194]) by dpdk.org (Postfix) with ESMTP id 187702F7D for ; Fri, 8 Jun 2018 01:54:35 +0200 (CEST) Received: by mail-qt0-f194.google.com with SMTP id h5-v6so11755441qtm.13 for ; Thu, 07 Jun 2018 16:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=NXwvrF9Uv9lZvw6QejyznCPaJpWE7aDFoD2/IQj7XBQ=; b=cpkddJwypGw7uOmJcnXuSuQ4Tp+LFL+kRePZXlP2wDAbET6mPxT3jOzVAlZH/bGVsJ 6P8kXVIQJDd7z3WhdFOTIjsm7aw+wLHTSs6pKFMqiP9b5HD7zsh9Xlpek1zEpU/tli0j fPSZorVXk20D4TivpfMlRjuY5GTU3c9kcHH1u6/Lex2hYxL/jSsKfbwsLE6Pt9Z+S9xB V3KOBK6rFU48x4OPD+TriE/2Yxsr6+1POKj1GTRxsxi8TishEwoHMs77t3r1SdCgOo6j SCBTMkbifjwSRxxNABRQWsp9c/DE6klN5hqOrRTHD7TUPDy9am1J6T6rfJF3euC/Msbb 0JXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=NXwvrF9Uv9lZvw6QejyznCPaJpWE7aDFoD2/IQj7XBQ=; b=QjzZmm5pzSli7BS+1i4H6VmCDHkrbvdtbO87Qxwj+R2HPRITUnoqe1TaVi0Nca6+aR 93jWO4jZNds9nmc6yW58nIfYzpTjqoeYFLWFInRNwQSs9zGDiJ701i4hOxJXiwGSdgLQ zHA7kTMwY5wCRz9gJPdBpvjvZe3nPi2fbCAK2bYdf4Q/c82yGlBj0O19CIy8OFJ9E/r5 /lJS0DBqaE9mu4+xJn/J/N5oHoR562rzOFZ/bNknM4ZWgJE6cOCwUd7qfsHP85BUsVtR 8Ar3aRPyJCfZvs15EJ+JxIrzbPIzTbBPq6Phr0Hi9unQwUjbe0h/vuHPsjpMGUMUPfyO h6xA== X-Gm-Message-State: APt69E0Ba4egtwc539B5QbfqFoyAfpHu7/qy1/oATXCBwW1ZphvJOWcT iFK3vAEGU7VfcjFOdDZliBxdUQ== X-Google-Smtp-Source: ADUXVKIJK4LEm4UL3Mbl6Az2UtRxtp00AEh77YzjTHDTtD2dpMtSe+0Lv1iR2KjQAJB8txZJMbp7Yw== X-Received: by 2002:ac8:1b9a:: with SMTP id z26-v6mr3891165qtj.344.1528415673999; Thu, 07 Jun 2018 16:54:33 -0700 (PDT) Received: from snappy.local.lan (201-1-204-188.dsl.telesp.net.br. [201.1.204.188]) by smtp.gmail.com with ESMTPSA id e96-v6sm29293257qtb.69.2018.06.07.16.54.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 Jun 2018 16:54:33 -0700 (PDT) From: Dan Gora To: dev@dpdk.org Cc: Dan Gora Date: Thu, 7 Jun 2018 20:54:15 -0300 Message-Id: <20180607235415.27744-1-dg@adax.com> X-Mailer: git-send-email 2.17.0.582.gccdcbd54c4 Subject: [dpdk-dev] [PATCH 0/4] mbuf: Add new private data area accessor function. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi All, Below is a series of patches to add a new API function to allow DPDK applications to access the private data area of the mbuf, if one exists. This eliminates the repeated code in applications to access the private data area and makes the API a bit more complete, since there are already accessor functions to access the start of the buffer, the start of data, etc. One question I had about was the name... What are the rules for naming mbuf APIs? When should rte_mbuf_XX vs. rte_pktmbuf_XX be used? The first patch [1 of 4] adds the accessor function to rte_mbuf.h. The other three patches clean up other code to use this new function. Please let me know what you think. thanks dan Dan Gora (4): mbuf: add accessor function for private data area examples/ipsec-secgw: use rte fcn to access private area examples/ipsec-secgw: use ipsec fcn to access private area vhost/crypto: use rte fcn to access private area examples/ipsec-secgw/ipsec.h | 2 +- examples/ipsec-secgw/sa.c | 2 +- lib/librte_mbuf/rte_mbuf.h | 19 +++++++++++++++++++ lib/librte_vhost/vhost_crypto.c | 6 ++---- 4 files changed, 23 insertions(+), 6 deletions(-)