mbox series

[v2,0/3] remove __typeof__ from expansion of per lcore macros

Message ID 1704239102-31044-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
Headers
Series remove __typeof__ from expansion of per lcore macros |

Message

Tyler Retzlaff Jan. 2, 2024, 11:44 p.m. UTC 
  The design of the macros requires a type to be provided to the macro.

By expanding the type parameter inside of typeof it also inadvertently
allows an expression to be used which appears not to have been intended
after evaluating the parameter name and existing macro use.

Technically this is an API break but only for applications that were
using these macros outside of the original design intent.

v2:
  * add additional patch to adjust usage for crypto/ipsec_mb 

Tyler Retzlaff (3):
  eal: provide type to per lcore macro
  crypto/ipsec_mb: provide type to per lcore macro
  eal: remove typeof from per lcore macros

 drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h | 2 +-
 lib/eal/common/eal_common_errno.c            | 2 +-
 lib/eal/include/rte_per_lcore.h              | 8 ++++----
 3 files changed, 6 insertions(+), 6 deletions(-)

Comments

Bruce Richardson Jan. 8, 2024, 10:45 a.m. UTC | #1 
On Tue, Jan 02, 2024 at 03:44:59PM -0800, Tyler Retzlaff wrote:
> The design of the macros requires a type to be provided to the macro.
> 
> By expanding the type parameter inside of typeof it also inadvertently
> allows an expression to be used which appears not to have been intended
> after evaluating the parameter name and existing macro use.
> 
> Technically this is an API break but only for applications that were
> using these macros outside of the original design intent.
> 
> v2:
>   * add additional patch to adjust usage for crypto/ipsec_mb 
> 
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>