mbox series

[v2,0/2] eal: provide leading and trailing zero bit count

Message ID 1669246997-30592-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
Headers
Series eal: provide leading and trailing zero bit count |

Message

Tyler Retzlaff Nov. 23, 2022, 11:43 p.m. UTC 
  Provide leading and trailing zero bit count functions to abstract away
compiler specific implementations.

Include basic unit test for new leading/trailing zero bit count functions.

v2:
  * use unsigned int instead of unsigned (checkpatches)
  * match multiple include guard naming convention to rte_common.h
  * add explicit extern "C" linkage to rte_bitcount.h
    note: not really needed but checkpatches required
  * add missing space around '-'

Tyler Retzlaff (2):
  eal: provide leading and trailing zero bit count abstraction
  test/bitcount: add bitcount tests

 app/test/meson.build           |   2 +
 app/test/test_bitcount.c       |  92 ++++++++++++++
 lib/eal/include/meson.build    |   1 +
 lib/eal/include/rte_bitcount.h | 265 +++++++++++++++++++++++++++++++++++++++++
 4 files changed, 360 insertions(+)
 create mode 100644 app/test/test_bitcount.c
 create mode 100644 lib/eal/include/rte_bitcount.h

Comments

Tyler Retzlaff Jan. 4, 2023, 11:46 p.m. UTC | #1 
hi just adding a few extra folks to the to line to try and get some
reviewer attention since this patch has been sitting here for a while.

the change is fairly straight forward, would just like to get it
cleared.

feedback is appreciated!

thanks

On Wed, Nov 23, 2022 at 03:43:15PM -0800, Tyler Retzlaff wrote:
> Provide leading and trailing zero bit count functions to abstract away
> compiler specific implementations.
> 
> Include basic unit test for new leading/trailing zero bit count functions.
> 
> v2:
>   * use unsigned int instead of unsigned (checkpatches)
>   * match multiple include guard naming convention to rte_common.h
>   * add explicit extern "C" linkage to rte_bitcount.h
>     note: not really needed but checkpatches required
>   * add missing space around '-'
> 
> Tyler Retzlaff (2):
>   eal: provide leading and trailing zero bit count abstraction
>   test/bitcount: add bitcount tests
> 
>  app/test/meson.build           |   2 +
>  app/test/test_bitcount.c       |  92 ++++++++++++++
>  lib/eal/include/meson.build    |   1 +
>  lib/eal/include/rte_bitcount.h | 265 +++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 360 insertions(+)
>  create mode 100644 app/test/test_bitcount.c
>  create mode 100644 lib/eal/include/rte_bitcount.h
> 
> -- 
> 1.8.3.1