[v10,00/13] preparation for the rte_flow offload of nfp PMD

  This is the first patch series to add the support of rte_flow offload for
nfp PMD, includes:
Add the support of flower firmware application
Add the support of representor port
Add the flower service infrastructure
Add the cmsg interactive channels between pmd and fw

* Changes since v9
- Remove the use of rte_eth_tx_burst()
- Remove the logics rely on OvS

* Changes since v8
- Update the nfp.rst
- Fix the 'app_hw' to 'app_fw'
- Remove the ovs compatible header file
- Remove the use of rte_eth_dev_configure()/rte_eth_rx_burst()/rte_eth_dev_start() API

* Changes since v7
- Adjust the logics to make sure not break the pci probe process
- Change 'app' to 'app_fw' in all logics to avoid confuse
- Fix problem about log level

* Changes since v6
- Fix the compile error

* Changes since v5
- Compare integer with 0 explicitly
- Change helper macro to function
- Implement the dummy functions
- Remove some unnecessary logics

* Changes since v4
- Remove the unneeded '__rte_unused' attribute
- Fixup a potential memory leak problem

* Changes since v3
- Add the 'Depends-on' tag

* Changes since v2
- Remove the use of rte_panic()

* Changes since v1
- Fix the compile error

Depends-on: series-23707 ("Add support of NFP3800 chip and firmware with NFDk")

Chaoyong He (13):
  net/nfp: move app specific attributes to own struct
  net/nfp: simplify initialization and remove dead code
  net/nfp: move app specific init logic to own function
  net/nfp: add initial flower firmware support
  net/nfp: add flower PF setup logic
  net/nfp: add flower ctrl VNIC related logics
  net/nfp: move common rxtx function for flower use
  net/nfp: add flower ctrl VNIC rxtx logic
  net/nfp: add flower representor framework
  net/nfp: add flower PF related routines
  net/nfp: move rxtx function to header file
  net/nfp: add flower PF rxtx logic
  net/nfp: add the representor port rxtx logic

 doc/guides/nics/nfp.rst                         |   32 +
 doc/guides/rel_notes/release_22_11.rst          |    9 +
 drivers/net/nfp/flower/nfp_flower.c             | 1204 +++++++++++++++++++++++
 drivers/net/nfp/flower/nfp_flower.h             |   65 ++
 drivers/net/nfp/flower/nfp_flower_cmsg.c        |  179 ++++
 drivers/net/nfp/flower/nfp_flower_cmsg.h        |  173 ++++
 drivers/net/nfp/flower/nfp_flower_ctrl.c        |  250 +++++
 drivers/net/nfp/flower/nfp_flower_ctrl.h        |   13 +
 drivers/net/nfp/flower/nfp_flower_representor.c |  925 +++++++++++++++++
 drivers/net/nfp/flower/nfp_flower_representor.h |   39 +
 drivers/net/nfp/meson.build                     |    4 +
 drivers/net/nfp/nfp_common.c                    |    2 +-
 drivers/net/nfp/nfp_common.h                    |   41 +-
 drivers/net/nfp/nfp_cpp_bridge.c                |   88 +-
 drivers/net/nfp/nfp_cpp_bridge.h                |    6 +-
 drivers/net/nfp/nfp_ethdev.c                    |  347 ++++---
 drivers/net/nfp/nfp_ethdev_vf.c                 |    2 +-
 drivers/net/nfp/nfp_rxtx.c                      |  123 +--
 drivers/net/nfp/nfp_rxtx.h                      |  121 +++
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c      |   31 +-
 20 files changed, 3370 insertions(+), 284 deletions(-)
 create mode 100644 drivers/net/nfp/flower/nfp_flower.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower.h
 create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.h
 create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.h
 create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.h
  

On 9/26/2022 7:59 AM, Chaoyong He wrote:
> This is the first patch series to add the support of rte_flow offload for
> nfp PMD, includes:
> Add the support of flower firmware application
> Add the support of representor port
> Add the flower service infrastructure
> Add the cmsg interactive channels between pmd and fw
> 
> * Changes since v9
> - Remove the use of rte_eth_tx_burst()
> - Remove the logics rely on OvS
> 
> * Changes since v8
> - Update the nfp.rst
> - Fix the 'app_hw' to 'app_fw'
> - Remove the ovs compatible header file
> - Remove the use of rte_eth_dev_configure()/rte_eth_rx_burst()/rte_eth_dev_start() API
> 
> * Changes since v7
> - Adjust the logics to make sure not break the pci probe process
> - Change 'app' to 'app_fw' in all logics to avoid confuse
> - Fix problem about log level
> 
> * Changes since v6
> - Fix the compile error
> 
> * Changes since v5
> - Compare integer with 0 explicitly
> - Change helper macro to function
> - Implement the dummy functions
> - Remove some unnecessary logics
> 
> * Changes since v4
> - Remove the unneeded '__rte_unused' attribute
> - Fixup a potential memory leak problem
> 
> * Changes since v3
> - Add the 'Depends-on' tag
> 
> * Changes since v2
> - Remove the use of rte_panic()
> 
> * Changes since v1
> - Fix the compile error
> 
> Depends-on: series-23707 ("Add support of NFP3800 chip and firmware with NFDk")
> 
> Chaoyong He (13):
>    net/nfp: move app specific attributes to own struct
>    net/nfp: simplify initialization and remove dead code
>    net/nfp: move app specific init logic to own function
>    net/nfp: add initial flower firmware support
>    net/nfp: add flower PF setup logic
>    net/nfp: add flower ctrl VNIC related logics
>    net/nfp: move common rxtx function for flower use
>    net/nfp: add flower ctrl VNIC rxtx logic
>    net/nfp: add flower representor framework
>    net/nfp: add flower PF related routines
>    net/nfp: move rxtx function to header file
>    net/nfp: add flower PF rxtx logic
>    net/nfp: add the representor port rxtx logic
> 

Series applied to dpdk-next-net/main, thanks.
  

On 10/5/2022 12:34 PM, Ferruh Yigit wrote:
> On 9/26/2022 7:59 AM, Chaoyong He wrote:
>> This is the first patch series to add the support of rte_flow offload for
>> nfp PMD, includes:
>> Add the support of flower firmware application
>> Add the support of representor port
>> Add the flower service infrastructure
>> Add the cmsg interactive channels between pmd and fw
>>
>> * Changes since v9
>> - Remove the use of rte_eth_tx_burst()
>> - Remove the logics rely on OvS
>>
>> * Changes since v8
>> - Update the nfp.rst
>> - Fix the 'app_hw' to 'app_fw'
>> - Remove the ovs compatible header file
>> - Remove the use of 
>> rte_eth_dev_configure()/rte_eth_rx_burst()/rte_eth_dev_start() API
>>
>> * Changes since v7
>> - Adjust the logics to make sure not break the pci probe process
>> - Change 'app' to 'app_fw' in all logics to avoid confuse
>> - Fix problem about log level
>>
>> * Changes since v6
>> - Fix the compile error
>>
>> * Changes since v5
>> - Compare integer with 0 explicitly
>> - Change helper macro to function
>> - Implement the dummy functions
>> - Remove some unnecessary logics
>>
>> * Changes since v4
>> - Remove the unneeded '__rte_unused' attribute
>> - Fixup a potential memory leak problem
>>
>> * Changes since v3
>> - Add the 'Depends-on' tag
>>
>> * Changes since v2
>> - Remove the use of rte_panic()
>>
>> * Changes since v1
>> - Fix the compile error
>>
>> Depends-on: series-23707 ("Add support of NFP3800 chip and firmware 
>> with NFDk")
>>
>> Chaoyong He (13):
>>    net/nfp: move app specific attributes to own struct
>>    net/nfp: simplify initialization and remove dead code
>>    net/nfp: move app specific init logic to own function
>>    net/nfp: add initial flower firmware support
>>    net/nfp: add flower PF setup logic
>>    net/nfp: add flower ctrl VNIC related logics
>>    net/nfp: move common rxtx function for flower use
>>    net/nfp: add flower ctrl VNIC rxtx logic
>>    net/nfp: add flower representor framework
>>    net/nfp: add flower PF related routines
>>    net/nfp: move rxtx function to header file
>>    net/nfp: add flower PF rxtx logic
>>    net/nfp: add the representor port rxtx logic
>>
> 
> Series applied to dpdk-next-net/main, thanks.
> 

Ahh, this has a small conflict with other set [1], and other one is fix.
To keep fix patch backportable to stable trees, I will get that series 
first and apply this set on top of it, by force push to next-net.

Please highlight these kind of dependencies in advance, in commit log etc.

And can you please double check final code in next-net head?

[1]
https://patches.dpdk.org/project/dpdk/patch/20220922130314.694790-2-niklas.soderlund@corigine.com/
[1/2] net/nfp: fix return value of nfp card init function
  

Hi Ferruh,

Thanks for your feedback.

On 2022-10-05 17:52:14 +0100, Ferruh Yigit wrote:
> > 
> > Series applied to dpdk-next-net/main, thanks.
> > 
> 
> Ahh, this has a small conflict with other set [1], and other one is fix.
> To keep fix patch backportable to stable trees, I will get that series
> first and apply this set on top of it, by force push to next-net.
> 
> Please highlight these kind of dependencies in advance, in commit log etc.

Sorry about that, we will improve our usage of the Depends-on tag.

> 
> And can you please double check final code in next-net head?

It looks good, thanks for sorting that out.

> 
> [1]
> https://patches.dpdk.org/project/dpdk/patch/20220922130314.694790-2-niklas.soderlund@corigine.com/
> [1/2] net/nfp: fix return value of nfp card init function
> 
>