Message ID | 1619693609-28244-1-git-send-email-humin29@huawei.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CB5DA0547; Thu, 29 Apr 2021 12:53:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42E0D41194; Thu, 29 Apr 2021 12:53:29 +0200 (CEST) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id C755741125 for <dev@dpdk.org>; Thu, 29 Apr 2021 12:53:27 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FWC3c0KqVzjcL5 for <dev@dpdk.org>; Thu, 29 Apr 2021 18:51:24 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Thu, 29 Apr 2021 18:53:21 +0800 From: "Min Hu (Connor)" <humin29@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@intel.com> Date: Thu, 29 Apr 2021 18:53:27 +0800 Message-ID: <1619693609-28244-1-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH V1 0/2] examples/ethtool: fix MTU set and add MTU query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
examples/ethtool: fix MTU set and add MTU query
|
|
Message
humin (Q)
April 29, 2021, 10:53 a.m. UTC
From: Huisong Li <lihuisong@huawei.com>
This patchset fixes MTU data type when set MTU, and supports the query
of MTU.
Huisong Li (2):
examples/ethtool: fix data type of MTU
examples/ethtool: support the query of MTU
examples/ethtool/ethtool-app/ethapp.c | 54 ++++++++++++++++++----------
examples/ethtool/lib/rte_ethtool.c | 16 ++++++++---
examples/ethtool/lib/rte_ethtool.h | 16 ++++++++++-
3 files changed, 63 insertions(+), 23 deletions(-)
Comments
Hi, all, any comments? 在 2021/4/29 18:53, Min Hu (Connor) 写道: > From: Huisong Li <lihuisong@huawei.com> > > This patchset fixes MTU data type when set MTU, and supports the query > of MTU. > > Huisong Li (2): > examples/ethtool: fix data type of MTU > examples/ethtool: support the query of MTU > > examples/ethtool/ethtool-app/ethapp.c | 54 ++++++++++++++++++---------- > examples/ethtool/lib/rte_ethtool.c | 16 ++++++++--- > examples/ethtool/lib/rte_ethtool.h | 16 ++++++++++- > 3 files changed, 63 insertions(+), 23 deletions(-) >
On Mon, 28 Jun 2021 11:23:12 +0800 "Min Hu (Connor)" <humin29@huawei.com> wrote: > Hi, all, > any comments? > > 在 2021/4/29 18:53, Min Hu (Connor) 写道: > > From: Huisong Li <lihuisong@huawei.com> > > > > This patchset fixes MTU data type when set MTU, and supports the query > > of MTU. > > > > Huisong Li (2): > > examples/ethtool: fix data type of MTU > > examples/ethtool: support the query of MTU > > > > examples/ethtool/ethtool-app/ethapp.c | 54 ++++++++++++++++++---------- > > examples/ethtool/lib/rte_ethtool.c | 16 ++++++++--- > > examples/ethtool/lib/rte_ethtool.h | 16 ++++++++++- > > 3 files changed, 63 insertions(+), 23 deletions(-) > > There were several review comments. In patch 1, the comment was that strtoul will return unsigned long. Therefore new_mtu should be of type unsigned long, and check that is is less than UINT16_MAX. For the second patch, David's comment was that get and set should logically be separate functions. The overlap was poor design in original ethtool program, and lets not repeat that. Overall, not many people looked at this patch because the ethtool example is one of those "throw it over the wall and forget it" applications that originally came from Cisco, and has seen little interest since then.