mbox series

[v3,0/3] fix check of port and core

Message ID 1619657448-57567-1-git-send-email-humin29@huawei.com (mailing list archive)
Headers
Series fix check of port and core |

Message

humin (Q) April 29, 2021, 12:50 a.m. UTC 
  Currently, some examples check that the port is on the same NUMA
node as the polling thread for best performance. The method is
to compare the socket id of port and that of current core. If the
result is different, warning info will be given.

But it ignores the port which is from numa node 0, that is, no
warning info will be given if the port is from numa node 0, and
this set of patches will fix it.
---
v3:
* change "-w" to "-a".

v2:
* add more commit info.

Min Hu (Connor) (3):
  examples/flow_classify: fix check of port and core
  examples/l2fwd-cat: fix check of port and core
  examples/skeleton: fix check of port and core

 examples/flow_classify/flow_classify.c | 2 +-
 examples/l2fwd-cat/l2fwd-cat.c         | 2 +-
 examples/skeleton/basicfwd.c           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Ferruh Yigit May 12, 2021, 4:52 p.m. UTC | #1 
On 4/29/2021 1:50 AM, Min Hu (Connor) wrote:
> Currently, some examples check that the port is on the same NUMA
> node as the polling thread for best performance. The method is
> to compare the socket id of port and that of current core. If the
> result is different, warning info will be given.
> 
> But it ignores the port which is from numa node 0, that is, no
> warning info will be given if the port is from numa node 0, and
> this set of patches will fix it.
> ---
> v3:
> * change "-w" to "-a".
> 
> v2:
> * add more commit info.
> 
> Min Hu (Connor) (3):
>   examples/flow_classify: fix check of port and core
>   examples/l2fwd-cat: fix check of port and core
>   examples/skeleton: fix check of port and core
> 

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Only I am not sure if it is confusing to mention from 'flow_classify' in the
commit log of 'l2fwd-cat' or 'skeleton' patches.
Thomas Monjalon May 12, 2021, 7:16 p.m. UTC | #2 
12/05/2021 18:52, Ferruh Yigit:
> On 4/29/2021 1:50 AM, Min Hu (Connor) wrote:
> > Currently, some examples check that the port is on the same NUMA
> > node as the polling thread for best performance. The method is
> > to compare the socket id of port and that of current core. If the
> > result is different, warning info will be given.
> > 
> > But it ignores the port which is from numa node 0, that is, no
> > warning info will be given if the port is from numa node 0, and
> > this set of patches will fix it.
> > ---
> > v3:
> > * change "-w" to "-a".
> > 
> > v2:
> > * add more commit info.
> > 
> > Min Hu (Connor) (3):
> >   examples/flow_classify: fix check of port and core
> >   examples/l2fwd-cat: fix check of port and core
> >   examples/skeleton: fix check of port and core
> > 
> 
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Only I am not sure if it is confusing to mention from 'flow_classify' in the
> commit log of 'l2fwd-cat' or 'skeleton' patches.

Yes it is confusing, I'll drop these comments.
The commits are still not explaining the issue is for devices on node 0,
I'll reword a bit.

Applied, thanks.