mbox series

[v6,0/2] single flow dump

Message ID 1618395600-215396-1-git-send-email-haifeil@nvidia.com (mailing list archive)
Headers
Series single flow dump |

Message

Haifei Luo April 14, 2021, 10:19 a.m. UTC
  Dump internal representation information of all flows is supported.
It is useful to dump one flow. To implement this requirement,
add this CLI to dump one rule: flow dump PORT rule ID
      and the CLI to dump all: flow dump PORT all
Examples:
    testpmd> flow dump 0 all
    testpmd> flow dump 0 rule 0
The first 0 is for port. The second one is for rule id.

For RTE API, add one arg rte_flow in rte_flow_dev_dump.
If rte_flow is null, it will dump information for all flows.
Otherwise, it will dump one.
Accordingly, add this arg in related dev_dump and driver APIs.

V2: fix comments about rte API. V1 has one API rte_flow_dump,
remove it and update rte_flow_dev_dump by adding one arg rte_flow.

V3: split into two series. One is for ethdev/testpmd/doc, the other is
for drivers.

V4: Fix comments. Remove "Flow dump" from features/default.ini and
features/mlx5.ini.

V5: Fix comments. Modify title and enhance API's description.

V6: Distribute the release notes updates to the patches that 
introduces the change. 

Haifei Luo (2):
  ethdev: dump single flow rule
  app/testpmd: add CLIs for single flow dump feature

 app/test-pmd/cmdline_flow.c                 | 55 +++++++++++++++++++++++++----
 app/test-pmd/config.c                       | 38 ++++++++++++++++++--
 app/test-pmd/testpmd.h                      |  3 +-
 doc/guides/nics/mlx5.rst                    |  9 +++--
 doc/guides/rel_notes/release_21_05.rst      |  5 +++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  6 +++-
 drivers/net/mlx5/linux/mlx5_socket.c        |  2 +-
 drivers/net/mlx5/mlx5.h                     |  4 +--
 drivers/net/mlx5/mlx5_flow.c                |  9 +++--
 drivers/net/octeontx2/otx2_flow.c           |  9 ++++-
 lib/librte_ethdev/rte_flow.c                |  5 +--
 lib/librte_ethdev/rte_flow.h                |  5 ++-
 lib/librte_ethdev/rte_flow_driver.h         |  1 +
 13 files changed, 126 insertions(+), 25 deletions(-)
  

Comments

Ferruh Yigit April 14, 2021, 11:26 a.m. UTC | #1
On 4/14/2021 11:19 AM, Haifei Luo wrote:
> Dump internal representation information of all flows is supported.
> It is useful to dump one flow. To implement this requirement,
> add this CLI to dump one rule: flow dump PORT rule ID
>        and the CLI to dump all: flow dump PORT all
> Examples:
>      testpmd> flow dump 0 all
>      testpmd> flow dump 0 rule 0
> The first 0 is for port. The second one is for rule id.
> 
> For RTE API, add one arg rte_flow in rte_flow_dev_dump.
> If rte_flow is null, it will dump information for all flows.
> Otherwise, it will dump one.
> Accordingly, add this arg in related dev_dump and driver APIs.
> 
> V2: fix comments about rte API. V1 has one API rte_flow_dump,
> remove it and update rte_flow_dev_dump by adding one arg rte_flow.
> 
> V3: split into two series. One is for ethdev/testpmd/doc, the other is
> for drivers.
> 
> V4: Fix comments. Remove "Flow dump" from features/default.ini and
> features/mlx5.ini.
> 
> V5: Fix comments. Modify title and enhance API's description.
> 
> V6: Distribute the release notes updates to the patches that
> introduces the change.
> 
> Haifei Luo (2):
>    ethdev: dump single flow rule
>    app/testpmd: add CLIs for single flow dump feature
> 

Series applied to dpdk-next-net/main, thanks.