mbox series

[0/3] fix check of port and core

Message ID 1616830818-3127-1-git-send-email-humin29@huawei.com (mailing list archive)
Headers
Series fix check of port and core |

Message

humin (Q) March 27, 2021, 7:40 a.m. UTC 
  Currently, some examples check that the port is on the same NUMA
node as the polling thread for best performance. The method is
to compare the socket id of port and that of current core. If the
result is different, warning info will be given.

But it ignores the port which is from numa node 0, that is, no
warning info will be given if the port is from numa node 0, and
this set of patches will fix it.

Min Hu (Connor) (3):
  examples/flow_classify: fix check of port and core
  examples/l2fwd-cat: fix check of port and core
  examples/skeleton: fix check of port and core

 examples/flow_classify/flow_classify.c | 2 +-
 examples/l2fwd-cat/l2fwd-cat.c         | 2 +-
 examples/skeleton/basicfwd.c           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

humin (Q) April 10, 2021, 9:14 a.m. UTC | #1 
Hi,Ferruh, bernard, tomasz, bruce and all,
	Any comments about this set of patches?

在 2021/3/27 15:40, Min Hu (Connor) 写道:
> Currently, some examples check that the port is on the same NUMA
> node as the polling thread for best performance. The method is
> to compare the socket id of port and that of current core. If the
> result is different, warning info will be given.
> 
> But it ignores the port which is from numa node 0, that is, no
> warning info will be given if the port is from numa node 0, and
> this set of patches will fix it.
> 
> Min Hu (Connor) (3):
>    examples/flow_classify: fix check of port and core
>    examples/l2fwd-cat: fix check of port and core
>    examples/skeleton: fix check of port and core
> 
>   examples/flow_classify/flow_classify.c | 2 +-
>   examples/l2fwd-cat/l2fwd-cat.c         | 2 +-
>   examples/skeleton/basicfwd.c           | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
humin (Q) April 19, 2021, 7:44 a.m. UTC | #2 
Hi,Ferruh, bernard, tomasz, bruce and all,
     Any comments about this set of patches?

在 2021/4/10 17:14, Min Hu (Connor) 写道:
> Hi,Ferruh, bernard, tomasz, bruce and all,
>      Any comments about this set of patches?
> 
> 在 2021/3/27 15:40, Min Hu (Connor) 写道:
>> Currently, some examples check that the port is on the same NUMA
>> node as the polling thread for best performance. The method is
>> to compare the socket id of port and that of current core. If the
>> result is different, warning info will be given.
>>
>> But it ignores the port which is from numa node 0, that is, no
>> warning info will be given if the port is from numa node 0, and
>> this set of patches will fix it.
>>
>> Min Hu (Connor) (3):
>>    examples/flow_classify: fix check of port and core
>>    examples/l2fwd-cat: fix check of port and core
>>    examples/skeleton: fix check of port and core
>>
>>   examples/flow_classify/flow_classify.c | 2 +-
>>   examples/l2fwd-cat/l2fwd-cat.c         | 2 +-
>>   examples/skeleton/basicfwd.c           | 2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>
> .