mbox series

[v1,0/2] Fix coverity issues reported in DPDK-26381

Message ID 1615969417-17118-1-git-send-email-wei.huang@intel.com (mailing list archive)
Headers
Series Fix coverity issues reported in DPDK-26381 |

Message

Wei Huang March 17, 2021, 8:23 a.m. UTC
  Below coverity issues are fixed in this patch set.
367480, 367482

Wei Huang (2):
  raw/ifpga/base: use untained variable as argument
  raw/ifpga/base: add argument to use untained variable

 drivers/raw/ifpga/base/ifpga_fme.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
  

Comments

Qi Zhang April 1, 2021, 12:17 p.m. UTC | #1
> -----Original Message-----
> From: Huang, Wei <wei.huang@intel.com>
> Sent: Wednesday, March 17, 2021 4:24 PM
> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Huang, Wei
> <wei.huang@intel.com>
> Subject: [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
> 
> Below coverity issues are fixed in this patch set.
> 367480, 367482
> 
> Wei Huang (2):
>   raw/ifpga/base: use untained variable as argument
>   raw/ifpga/base: add argument to use untained variable
> 
>  drivers/raw/ifpga/base/ifpga_fme.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> --
> 2.29.2

Applied to dpdk-next-net-intel.

Thanks
Qi
  
Ferruh Yigit April 20, 2021, 8:09 a.m. UTC | #2
On 4/1/2021 1:17 PM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Huang, Wei <wei.huang@intel.com>
>> Sent: Wednesday, March 17, 2021 4:24 PM
>> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Huang, Wei
>> <wei.huang@intel.com>
>> Subject: [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
>>
>> Below coverity issues are fixed in this patch set.
>> 367480, 367482
>>
>> Wei Huang (2):
>>    raw/ifpga/base: use untained variable as argument
>>    raw/ifpga/base: add argument to use untained variable
>>
>>   drivers/raw/ifpga/base/ifpga_fme.c | 15 ++++++++-------
>>   1 file changed, 8 insertions(+), 7 deletions(-)
>>
>> --
>> 2.29.2
> 
> Applied to dpdk-next-net-intel.
> 

Hi Qi,

What is the status of this set?
It is not merged to your tree, and its patchwork status is 'Rejected'.
  
Qi Zhang April 20, 2021, 9:12 a.m. UTC | #3
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Tuesday, April 20, 2021 4:10 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Huang, Wei <wei.huang@intel.com>;
> dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>
> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in
> DPDK-26381
> 
> On 4/1/2021 1:17 PM, Zhang, Qi Z wrote:
> >
> >
> >> -----Original Message-----
> >> From: Huang, Wei <wei.huang@intel.com>
> >> Sent: Wednesday, March 17, 2021 4:24 PM
> >> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
> >> <qi.z.zhang@intel.com>
> >> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Huang,
> >> Wei <wei.huang@intel.com>
> >> Subject: [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
> >>
> >> Below coverity issues are fixed in this patch set.
> >> 367480, 367482
> >>
> >> Wei Huang (2):
> >>    raw/ifpga/base: use untained variable as argument
> >>    raw/ifpga/base: add argument to use untained variable
> >>
> >>   drivers/raw/ifpga/base/ifpga_fme.c | 15 ++++++++-------
> >>   1 file changed, 8 insertions(+), 7 deletions(-)
> >>
> >> --
> >> 2.29.2
> >
> > Applied to dpdk-next-net-intel.
> >
> 
> Hi Qi,
> 
> What is the status of this set?
> It is not merged to your tree, and its patchwork status is 'Rejected'.

I think the status is wrong updated, and the patches are just dropped after re-sync with next-net, thanks for capture this.
  
Qi Zhang April 20, 2021, 9:29 a.m. UTC | #4
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Tuesday, April 20, 2021 5:13 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Huang, Wei
> <wei.huang@intel.com>; dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>
> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in
> DPDK-26381
> 
> 
> 
> > -----Original Message-----
> > From: Yigit, Ferruh <ferruh.yigit@intel.com>
> > Sent: Tuesday, April 20, 2021 4:10 PM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Huang, Wei
> > <wei.huang@intel.com>; dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>
> > Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in
> > DPDK-26381
> >
> > On 4/1/2021 1:17 PM, Zhang, Qi Z wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Huang, Wei <wei.huang@intel.com>
> > >> Sent: Wednesday, March 17, 2021 4:24 PM
> > >> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
> > >> <qi.z.zhang@intel.com>
> > >> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>;
> > >> Huang, Wei <wei.huang@intel.com>
> > >> Subject: [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
> > >>
> > >> Below coverity issues are fixed in this patch set.
> > >> 367480, 367482
> > >>
> > >> Wei Huang (2):
> > >>    raw/ifpga/base: use untained variable as argument
> > >>    raw/ifpga/base: add argument to use untained variable
> > >>
> > >>   drivers/raw/ifpga/base/ifpga_fme.c | 15 ++++++++-------
> > >>   1 file changed, 8 insertions(+), 7 deletions(-)
> > >>
> > >> --
> > >> 2.29.2
> > >
> > > Applied to dpdk-next-net-intel.
> > >
> >
> > Hi Qi,
> >
> > What is the status of this set?
> > It is not merged to your tree, and its patchwork status is 'Rejected'.
> 
> I think the status is wrong updated, and the patches are just dropped after
> re-sync with next-net, thanks for capture this.

OK, the patch set should be rejected, as they already be covered by below patch. 
http://patchwork.dpdk.org/project/dpdk/patch/20210408085151.54996-2-wei.huang@intel.com/
So there is no miss operation in path work, just can't remember what happened :)

We are OK now.