Message ID | 1614249901-307665-1-git-send-email-matan@nvidia.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 298BEA034F; Thu, 25 Feb 2021 11:45:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BCB440692; Thu, 25 Feb 2021 11:45:41 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by mails.dpdk.org (Postfix) with ESMTP id 1D8D94067B for <dev@dpdk.org>; Thu, 25 Feb 2021 11:45:39 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from matan@nvidia.com) with SMTP; 25 Feb 2021 12:45:36 +0200 Received: from pegasus25.mtr.labs.mlnx. (pegasus25.mtr.labs.mlnx [10.210.16.10]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 11PAjafT010995; Thu, 25 Feb 2021 12:45:36 +0200 From: Matan Azrad <matan@nvidia.com> To: dev@dpdk.org Cc: Viacheslav Ovsiienko <viacheslavo@nvidia.com> Date: Thu, 25 Feb 2021 10:44:57 +0000 Message-Id: <1614249901-307665-1-git-send-email-matan@nvidia.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH 0/4] net/mlx5: fix imissed statistic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | net/mlx5: fix imissed statistic | |
Message
Matan Azrad
Feb. 25, 2021, 10:44 a.m. UTC
The imissed port statistic counts packets that were dropped by the device Rx queues. In mlx5, the imissed counter summarizes 2 counters: - packets dropped by the SW queue handling counted by SW. - packets dropped by the HW queues due to "out of buffer" events detected when no SW buffer is available for the incoming packets. There is HW counter object that should be created per device, and all the Rx queues should be assigned to this counter in configuration time. This part was missed when the Rx queues were created by DevX what remained the "out of buffer" counter clean forever in this case. Add 2 options to assign the DevX Rx queues to queue counter: - Create queue counter per device by DevX and assign all the queues to it. - Query the kernel counter and assign all the queues to it. Use the first option by default and if it is failed, fallback to the second option. Matan Azrad (4): common/mlx5/linux: add glue function to query WQ common/mlx5: add DevX command to query WQ common/mlx5: add DevX commands for queue counters net/mlx5: fix imissed statistics Series-acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> drivers/common/mlx5/linux/mlx5_glue.c | 18 ++++++ drivers/common/mlx5/linux/mlx5_glue.h | 2 + drivers/common/mlx5/mlx5_devx_cmds.c | 100 ++++++++++++++++++++++++++++++++++ drivers/common/mlx5/mlx5_devx_cmds.h | 9 +++ drivers/common/mlx5/mlx5_prm.h | 100 ++++++++++++++++++++++++++++++++++ drivers/common/mlx5/version.map | 5 +- drivers/net/mlx5/linux/mlx5_os.c | 52 ++++++++++++++++++ drivers/net/mlx5/mlx5.c | 4 ++ drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_devx.c | 2 + 10 files changed, 293 insertions(+), 1 deletion(-)
Comments
Hi, > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad > Sent: Thursday, February 25, 2021 12:45 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko <viacheslavo@nvidia.com> > Subject: [dpdk-dev] [PATCH 0/4] net/mlx5: fix imissed statistic > > The imissed port statistic counts packets that were dropped > by the device Rx queues. > > In mlx5, the imissed counter summarizes 2 counters: > - packets dropped by the SW queue handling counted by SW. > - packets dropped by the HW queues due to "out of buffer" events > detected when no SW buffer is available for the incoming > packets. > > There is HW counter object that should be created per device, and all > the Rx queues should be assigned to this counter in configuration time. > > This part was missed when the Rx queues were created by DevX what > remained the "out of buffer" counter clean forever in this case. > > Add 2 options to assign the DevX Rx queues to queue counter: > - Create queue counter per device by DevX and assign all the > queues to it. > - Query the kernel counter and assign all the queues to it. > > Use the first option by default and if it is failed, fallback to the > second option. > > Matan Azrad (4): > common/mlx5/linux: add glue function to query WQ > common/mlx5: add DevX command to query WQ > common/mlx5: add DevX commands for queue counters > net/mlx5: fix imissed statistics > > Series-acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> > > > drivers/common/mlx5/linux/mlx5_glue.c | 18 ++++++ > drivers/common/mlx5/linux/mlx5_glue.h | 2 + > drivers/common/mlx5/mlx5_devx_cmds.c | 100 > ++++++++++++++++++++++++++++++++++ > drivers/common/mlx5/mlx5_devx_cmds.h | 9 +++ > drivers/common/mlx5/mlx5_prm.h | 100 > ++++++++++++++++++++++++++++++++++ > drivers/common/mlx5/version.map | 5 +- > drivers/net/mlx5/linux/mlx5_os.c | 52 ++++++++++++++++++ > drivers/net/mlx5/mlx5.c | 4 ++ > drivers/net/mlx5/mlx5.h | 2 + > drivers/net/mlx5/mlx5_devx.c | 2 + > 10 files changed, 293 insertions(+), 1 deletion(-) > > -- > 1.8.3.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh