mbox series

[v13,0/4] raw/ifpga: add extra OPAE APIs

Message ID 1612921738-26208-1-git-send-email-wei.huang@intel.com (mailing list archive)
Headers show
Series raw/ifpga: add extra OPAE APIs | expand

Message

Wei Huang Feb. 10, 2021, 1:48 a.m. UTC
Cyborg is part of OpenStack, it needs some OPAE APIs to manage
devices with Intel FPGA. The first three patches implement extra
APIs to meet Cyborg requirement. The last patch add an example
to show how to use these APIs.

Main changes from v12:
- implement ifpga APIs in rte_pmd_ifpga.c

Wei Huang (4):
  raw/ifpga: add fpga rsu APIs
  raw/ifpga: add APIs to get fpga information
  raw/ifpga: add miscellaneous APIs
  examples/ifpga: add example for ifpga APIs

 MAINTAINERS                                |    3 +
 doc/api/doxy-api-index.md                  |    3 +-
 doc/guides/sample_app_ug/ifpga.rst         |  387 +++++
 doc/guides/sample_app_ug/index.rst         |    1 +
 drivers/raw/ifpga/base/ifpga_api.c         |   34 +
 drivers/raw/ifpga/base/ifpga_defines.h     |    1 +
 drivers/raw/ifpga/base/ifpga_feature_dev.c |   21 +
 drivers/raw/ifpga/base/ifpga_feature_dev.h |    1 +
 drivers/raw/ifpga/base/ifpga_fme.c         |   36 +-
 drivers/raw/ifpga/base/ifpga_fme_rsu.c     |  428 +++++
 drivers/raw/ifpga/base/ifpga_hw.h          |    1 +
 drivers/raw/ifpga/base/ifpga_sec_mgr.c     |  639 ++++++++
 drivers/raw/ifpga/base/ifpga_sec_mgr.h     |   93 ++
 drivers/raw/ifpga/base/meson.build         |    2 +
 drivers/raw/ifpga/base/opae_hw_api.c       |   77 +
 drivers/raw/ifpga/base/opae_hw_api.h       |   12 +
 drivers/raw/ifpga/base/opae_ifpga_hw_api.h |    1 +
 drivers/raw/ifpga/base/opae_intel_max10.c  |   48 +
 drivers/raw/ifpga/base/opae_intel_max10.h  |   44 +
 drivers/raw/ifpga/ifpga_rawdev.c           |   30 +
 drivers/raw/ifpga/ifpga_rawdev.h           |    7 +-
 drivers/raw/ifpga/meson.build              |    4 +-
 drivers/raw/ifpga/rte_pmd_ifpga.c          |  429 +++++
 drivers/raw/ifpga/rte_pmd_ifpga.h          |  308 ++++
 drivers/raw/ifpga/version.map              |   18 +
 examples/ifpga/Makefile                    |   43 +
 examples/ifpga/commands.c                  | 1294 ++++++++++++++++
 examples/ifpga/commands.h                  |   16 +
 examples/ifpga/main.c                      |   38 +
 examples/ifpga/meson.build                 |   20 +
 examples/ifpga/opae_api.c                  | 1632 ++++++++++++++++++++
 examples/ifpga/opae_api.h                  |  244 +++
 examples/meson.build                       |    2 +-
 33 files changed, 5911 insertions(+), 6 deletions(-)
 create mode 100644 doc/guides/sample_app_ug/ifpga.rst
 create mode 100644 drivers/raw/ifpga/base/ifpga_fme_rsu.c
 create mode 100644 drivers/raw/ifpga/base/ifpga_sec_mgr.c
 create mode 100644 drivers/raw/ifpga/base/ifpga_sec_mgr.h
 create mode 100644 drivers/raw/ifpga/rte_pmd_ifpga.c
 create mode 100644 drivers/raw/ifpga/rte_pmd_ifpga.h
 create mode 100644 examples/ifpga/Makefile
 create mode 100644 examples/ifpga/commands.c
 create mode 100644 examples/ifpga/commands.h
 create mode 100644 examples/ifpga/main.c
 create mode 100644 examples/ifpga/meson.build
 create mode 100644 examples/ifpga/opae_api.c
 create mode 100644 examples/ifpga/opae_api.h

Comments

Thomas Monjalon Feb. 10, 2021, 9:37 a.m. UTC | #1
10/02/2021 02:48, Wei Huang:
> Cyborg is part of OpenStack, it needs some OPAE APIs to manage
> devices with Intel FPGA. The first three patches implement extra
> APIs to meet Cyborg requirement. The last patch add an example
> to show how to use these APIs.
> 
> Main changes from v12:
> - implement ifpga APIs in rte_pmd_ifpga.c
> 
> Wei Huang (4):
>   raw/ifpga: add fpga rsu APIs
>   raw/ifpga: add APIs to get fpga information
>   raw/ifpga: add miscellaneous APIs
>   examples/ifpga: add example for ifpga APIs

Not sure we want to add an example for a driver-specific API.

PS: please use --in-reply-to to keep all versions in the same thread.
Wei Huang Feb. 22, 2021, 1:59 a.m. UTC | #2
-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Wednesday, February 10, 2021 17:38
To: Huang, Wei <wei.huang@intel.com>
Cc: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [PATCH v13 0/4] raw/ifpga: add extra OPAE APIs

10/02/2021 02:48, Wei Huang:
> Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices 
> with Intel FPGA. The first three patches implement extra APIs to meet 
> Cyborg requirement. The last patch add an example to show how to use 
> these APIs.
> 
> Main changes from v12:
> - implement ifpga APIs in rte_pmd_ifpga.c
> 
> Wei Huang (4):
>   raw/ifpga: add fpga rsu APIs
>   raw/ifpga: add APIs to get fpga information
>   raw/ifpga: add miscellaneous APIs
>   examples/ifpga: add example for ifpga APIs

Not sure we want to add an example for a driver-specific API.
Thomas, this example has two purposes, one is for how to use ifpga API, the other is to create static library for Cyborg application.
PS: please use --in-reply-to to keep all versions in the same thread.
Thomas Monjalon Feb. 22, 2021, 9:12 a.m. UTC | #3
22/02/2021 02:59, Huang, Wei:
> 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net> 
> Sent: Wednesday, February 10, 2021 17:38
> To: Huang, Wei <wei.huang@intel.com>
> Cc: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [dpdk-stable] [PATCH v13 0/4] raw/ifpga: add extra OPAE APIs
> 
> 10/02/2021 02:48, Wei Huang:
> > Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices 
> > with Intel FPGA. The first three patches implement extra APIs to meet 
> > Cyborg requirement. The last patch add an example to show how to use 
> > these APIs.
> > 
> > Main changes from v12:
> > - implement ifpga APIs in rte_pmd_ifpga.c
> > 
> > Wei Huang (4):
> >   raw/ifpga: add fpga rsu APIs
> >   raw/ifpga: add APIs to get fpga information
> >   raw/ifpga: add miscellaneous APIs
> >   examples/ifpga: add example for ifpga APIs
> 
> Not sure we want to add an example for a driver-specific API.
> Thomas, this example has two purposes, one is for how to use ifpga API, the other is to create static library for Cyborg application.
> PS: please use --in-reply-to to keep all versions in the same thread.

It seems you are missing my and your reply together
without distinction.
Please take care your email client is well configured
to prefix lines with >

About the example, I still think it is a no-go,
but it should be a techboard decision.