mbox series

[0/2] meson build fixes for hns3

Message ID 1612356396-21309-1-git-send-email-oulijun@huawei.com (mailing list archive)
Headers
Series meson build fixes for hns3 |

Message

Lijun Ou Feb. 3, 2021, 12:46 p.m. UTC
  This series fix meson build for kunpeng920 and
kunpeng930 boards.

Chengchang Tang (2):
  config/arm: fix Hisilicon kunpeng920 SoC build
  config/arm: fix Hisilicon kunpeng930 Soc build

 config/arm/arm64_kunpeng920_linux_gcc              | 19 +++++++++++++++
 config/arm/arm64_kunpeng930_linux_gcc              | 19 +++++++++++++++
 config/arm/meson.build                             | 27 ++++++++++++++++++++++
 .../linux_gsg/cross_build_dpdk_for_arm64.rst       |  5 ++++
 4 files changed, 70 insertions(+)
 create mode 100644 config/arm/arm64_kunpeng920_linux_gcc
 create mode 100644 config/arm/arm64_kunpeng930_linux_gcc
  

Comments

Lijun Ou March 5, 2021, 1:38 a.m. UTC | #1
Hi, Thomas Monjalon && Ferruh
   Is the patchset used for integration or resending? What's your opinion?

Thanks
Lijun Ou

在 2021/2/3 20:46, Lijun Ou 写道:
> This series fix meson build for kunpeng920 and
> kunpeng930 boards.
> 
> Chengchang Tang (2):
>    config/arm: fix Hisilicon kunpeng920 SoC build
>    config/arm: fix Hisilicon kunpeng930 Soc build
> 
>   config/arm/arm64_kunpeng920_linux_gcc              | 19 +++++++++++++++
>   config/arm/arm64_kunpeng930_linux_gcc              | 19 +++++++++++++++
>   config/arm/meson.build                             | 27 ++++++++++++++++++++++
>   .../linux_gsg/cross_build_dpdk_for_arm64.rst       |  5 ++++
>   4 files changed, 70 insertions(+)
>   create mode 100644 config/arm/arm64_kunpeng920_linux_gcc
>   create mode 100644 config/arm/arm64_kunpeng930_linux_gcc
>
  
Lijun Ou March 25, 2021, 1:26 p.m. UTC | #2
在 2021/3/25 20:19, Thomas Monjalon 写道:
> 25/03/2021 12:17, oulijun:
>> Ruifeng has reviewed-by. Does anyone else have any comments? Is it
>> necessary to send the V2?
> 
> v2 for what? There is a change?
> 
No. no change.
> 
>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
>>> 25/03/2021 09:54, oulijun:
>>>> Hi, Thomas&&Ferruh
>>>>
>>>> Do I need to send a patchset?
>>>
>>> ???
>>> What do you mean?
>>>
>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
>>>>> This series add meson build for Hisilicon kunpeng CPU.
>>>>>
>>>>> Lijun Ou (4):
>>>>>      config/arm: add Hisilicon kunpeng920 implementer
>>>>>      config/arm: add Hisilicon kunpeng930 implementer
>>>>>      config/arm: add kunpeng920 meson cross compile target
>>>>>      config/arm: add kunpeng930 meson cross compile target
>>>
>>>
>>>
>>> .
>>>
>>
> 
> 
> 
> 
> 
> .
>
  
Thomas Monjalon March 25, 2021, 2:40 p.m. UTC | #3
25/03/2021 14:26, oulijun:
> 在 2021/3/25 20:19, Thomas Monjalon 写道:
> > 25/03/2021 12:17, oulijun:
> >> Ruifeng has reviewed-by. Does anyone else have any comments? Is it
> >> necessary to send the V2?
> > 
> > v2 for what? There is a change?
> > 
> No. no change.

So why are you asking to send a v2?


> >> 在 2021/3/25 17:07, Thomas Monjalon 写道:
> >>> 25/03/2021 09:54, oulijun:
> >>>> Hi, Thomas&&Ferruh
> >>>>
> >>>> Do I need to send a patchset?
> >>>
> >>> ???
> >>> What do you mean?
> >>>
> >>>> 在 2021/3/10 9:35, Lijun Ou 写道:
> >>>>> This series add meson build for Hisilicon kunpeng CPU.
> >>>>>
> >>>>> Lijun Ou (4):
> >>>>>      config/arm: add Hisilicon kunpeng920 implementer
> >>>>>      config/arm: add Hisilicon kunpeng930 implementer
> >>>>>      config/arm: add kunpeng920 meson cross compile target
> >>>>>      config/arm: add kunpeng930 meson cross compile target
  
Lijun Ou March 26, 2021, 12:41 a.m. UTC | #4
在 2021/3/25 22:40, Thomas Monjalon 写道:
> 25/03/2021 14:26, oulijun:
>> 在 2021/3/25 20:19, Thomas Monjalon 写道:
>>> 25/03/2021 12:17, oulijun:
>>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is it
>>>> necessary to send the V2?
>>>
>>> v2 for what? There is a change?
>>>
>> No. no change.
> 
> So why are you asking to send a v2?
> 
Sorry. My suggestion is to ask if you need to reset the patch based on 
the latest date. If not, wait for other's reviews and to incorporate the 
patch.
> 
>>>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
>>>>> 25/03/2021 09:54, oulijun:
>>>>>> Hi, Thomas&&Ferruh
>>>>>>
>>>>>> Do I need to send a patchset?
>>>>>
>>>>> ???
>>>>> What do you mean?
>>>>>
>>>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
>>>>>>> This series add meson build for Hisilicon kunpeng CPU.
>>>>>>>
>>>>>>> Lijun Ou (4):
>>>>>>>       config/arm: add Hisilicon kunpeng920 implementer
>>>>>>>       config/arm: add Hisilicon kunpeng930 implementer
>>>>>>>       config/arm: add kunpeng920 meson cross compile target
>>>>>>>       config/arm: add kunpeng930 meson cross compile target
> 
> 
> 
> .
>
  
Honnappa Nagarahalli April 5, 2021, 7:50 p.m. UTC | #5
<snip>

> 
> 在 2021/3/25 22:40, Thomas Monjalon 写道:
> > 25/03/2021 14:26, oulijun:
> >> 在 2021/3/25 20:19, Thomas Monjalon 写道:
> >>> 25/03/2021 12:17, oulijun:
> >>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is it
> >>>> necessary to send the V2?
> >>>
> >>> v2 for what? There is a change?
> >>>
> >> No. no change.
> >
> > So why are you asking to send a v2?
> >
> Sorry. My suggestion is to ask if you need to reset the patch based on the
> latest date. If not, wait for other's reviews and to incorporate the patch.
> >
I suggest to rework this patch once [1] is merged.

[1] http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send-email-juraj.linkes@pantheon.tech/

> >>>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
> >>>>> 25/03/2021 09:54, oulijun:
> >>>>>> Hi, Thomas&&Ferruh
> >>>>>>
> >>>>>> Do I need to send a patchset?
> >>>>>
> >>>>> ???
> >>>>> What do you mean?
> >>>>>
> >>>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
> >>>>>>> This series add meson build for Hisilicon kunpeng CPU.
> >>>>>>>
> >>>>>>> Lijun Ou (4):
> >>>>>>>       config/arm: add Hisilicon kunpeng920 implementer
> >>>>>>>       config/arm: add Hisilicon kunpeng930 implementer
> >>>>>>>       config/arm: add kunpeng920 meson cross compile target
> >>>>>>>       config/arm: add kunpeng930 meson cross compile target
> >
> >
> >
> > .
> >
  
Lijun Ou April 6, 2021, 1 a.m. UTC | #6
在 2021/4/6 3:50, Honnappa Nagarahalli 写道:
> <snip>
> 
>>
>> 在 2021/3/25 22:40, Thomas Monjalon 写道:
>>> 25/03/2021 14:26, oulijun:
>>>> 在 2021/3/25 20:19, Thomas Monjalon 写道:
>>>>> 25/03/2021 12:17, oulijun:
>>>>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is it
>>>>>> necessary to send the V2?
>>>>>
>>>>> v2 for what? There is a change?
>>>>>
>>>> No. no change.
>>>
>>> So why are you asking to send a v2?
>>>
>> Sorry. My suggestion is to ask if you need to reset the patch based on the
>> latest date. If not, wait for other's reviews and to incorporate the patch.
>>>
> I suggest to rework this patch once [1] is merged.
> 
> [1] http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send-email-juraj.linkes@pantheon.tech/
> 
I checked it out, and this series has not been received, and I don't 
think it can be reworked based on it.
>>>>>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
>>>>>>> 25/03/2021 09:54, oulijun:
>>>>>>>> Hi, Thomas&&Ferruh
>>>>>>>>
>>>>>>>> Do I need to send a patchset?
>>>>>>>
>>>>>>> ???
>>>>>>> What do you mean?
>>>>>>>
>>>>>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
>>>>>>>>> This series add meson build for Hisilicon kunpeng CPU.
>>>>>>>>>
>>>>>>>>> Lijun Ou (4):
>>>>>>>>>        config/arm: add Hisilicon kunpeng920 implementer
>>>>>>>>>        config/arm: add Hisilicon kunpeng930 implementer
>>>>>>>>>        config/arm: add kunpeng920 meson cross compile target
>>>>>>>>>        config/arm: add kunpeng930 meson cross compile target
>>>
>>>
>>>
>>> .
>>>
  
Honnappa Nagarahalli April 7, 2021, 2:19 a.m. UTC | #7
<snip>

> >>
> >> 在 2021/3/25 22:40, Thomas Monjalon 写道:
> >>> 25/03/2021 14:26, oulijun:
> >>>> 在 2021/3/25 20:19, Thomas Monjalon 写道:
> >>>>> 25/03/2021 12:17, oulijun:
> >>>>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is
> >>>>>> it necessary to send the V2?
> >>>>>
> >>>>> v2 for what? There is a change?
> >>>>>
> >>>> No. no change.
> >>>
> >>> So why are you asking to send a v2?
> >>>
> >> Sorry. My suggestion is to ask if you need to reset the patch based
> >> on the latest date. If not, wait for other's reviews and to incorporate the
> patch.
> >>>
> > I suggest to rework this patch once [1] is merged.
> >
> > [1]
> > http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send
> > -email-juraj.linkes@pantheon.tech/
> >
> I checked it out, and this series has not been received, and I don't think it can
> be reworked based on it.
It would be good to review the series, test it on your platform and provide any comments you might have. It will help make progress on the series.

> >>>>>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
> >>>>>>> 25/03/2021 09:54, oulijun:
> >>>>>>>> Hi, Thomas&&Ferruh
> >>>>>>>>
> >>>>>>>> Do I need to send a patchset?
> >>>>>>>
> >>>>>>> ???
> >>>>>>> What do you mean?
> >>>>>>>
> >>>>>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
> >>>>>>>>> This series add meson build for Hisilicon kunpeng CPU.
> >>>>>>>>>
> >>>>>>>>> Lijun Ou (4):
> >>>>>>>>>        config/arm: add Hisilicon kunpeng920 implementer
> >>>>>>>>>        config/arm: add Hisilicon kunpeng930 implementer
> >>>>>>>>>        config/arm: add kunpeng920 meson cross compile target
> >>>>>>>>>        config/arm: add kunpeng930 meson cross compile target
> >>>
> >>>
> >>>
> >>> .
> >>>
  
Lijun Ou April 8, 2021, 3:30 a.m. UTC | #8
在 2021/4/7 10:19, Honnappa Nagarahalli 写道:
> <snip>
> 
>>>>
>>>> 在 2021/3/25 22:40, Thomas Monjalon 写道:
>>>>> 25/03/2021 14:26, oulijun:
>>>>>> 在 2021/3/25 20:19, Thomas Monjalon 写道:
>>>>>>> 25/03/2021 12:17, oulijun:
>>>>>>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is
>>>>>>>> it necessary to send the V2?
>>>>>>>
>>>>>>> v2 for what? There is a change?
>>>>>>>
>>>>>> No. no change.
>>>>>
>>>>> So why are you asking to send a v2?
>>>>>
>>>> Sorry. My suggestion is to ask if you need to reset the patch based
>>>> on the latest date. If not, wait for other's reviews and to incorporate the
>> patch.
>>>>>
>>> I suggest to rework this patch once [1] is merged.
>>>
>>> [1]
>>> http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send
>>> -email-juraj.linkes@pantheon.tech/
>>>
>> I checked it out, and this series has not been received, and I don't think it can
>> be reworked based on it.
> It would be good to review the series, test it on your platform and provide any comments you might have. It will help make progress on the series.
> 
Hi, Thomas && Ferruh Yigit
   What's your opinion?

Thanks
>>>>>>>> 在 2021/3/25 17:07, Thomas Monjalon 写道:
>>>>>>>>> 25/03/2021 09:54, oulijun:
>>>>>>>>>> Hi, Thomas&&Ferruh
>>>>>>>>>>
>>>>>>>>>> Do I need to send a patchset?
>>>>>>>>>
>>>>>>>>> ???
>>>>>>>>> What do you mean?
>>>>>>>>>
>>>>>>>>>> 在 2021/3/10 9:35, Lijun Ou 写道:
>>>>>>>>>>> This series add meson build for Hisilicon kunpeng CPU.
>>>>>>>>>>>
>>>>>>>>>>> Lijun Ou (4):
>>>>>>>>>>>         config/arm: add Hisilicon kunpeng920 implementer
>>>>>>>>>>>         config/arm: add Hisilicon kunpeng930 implementer
>>>>>>>>>>>         config/arm: add kunpeng920 meson cross compile target
>>>>>>>>>>>         config/arm: add kunpeng930 meson cross compile target
>>>>>
>>>>>
>>>>>
>>>>> .
>>>>>
  
Thomas Monjalon April 8, 2021, 8:01 a.m. UTC | #9
08/04/2021 05:30, oulijun:
> 在 2021/4/7 10:19, Honnappa Nagarahalli 写道:
> >>>> 在 2021/3/25 22:40, Thomas Monjalon 写道:
> >>>>> 25/03/2021 14:26, oulijun:
> >>>>>> 在 2021/3/25 20:19, Thomas Monjalon 写道:
> >>>>>>> 25/03/2021 12:17, oulijun:
> >>>>>>>> Ruifeng has reviewed-by. Does anyone else have any comments? Is
> >>>>>>>> it necessary to send the V2?
> >>>>>>>
> >>>>>>> v2 for what? There is a change?
> >>>>>>>
> >>>>>> No. no change.
> >>>>>
> >>>>> So why are you asking to send a v2?
> >>>>>
> >>>> Sorry. My suggestion is to ask if you need to reset the patch based
> >>>> on the latest date. If not, wait for other's reviews and to incorporate the
> >> patch.
> >>>>>
> >>> I suggest to rework this patch once [1] is merged.
> >>>
> >>> [1]
> >>> http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send
> >>> -email-juraj.linkes@pantheon.tech/
> >>>
> >> I checked it out, and this series has not been received, and I don't think it can
> >> be reworked based on it.
> > It would be good to review the series, test it on your platform and provide any comments you might have. It will help make progress on the series.
> > 
> Hi, Thomas && Ferruh Yigit
>    What's your opinion?

Help in review is always good.
Please review what you can.