mbox series

[0/4] hns3 fixes

Message ID 1605871656-51819-1-git-send-email-oulijun@huawei.com (mailing list archive)
Headers show
Series hns3 fixes | expand

Message

oulijun Nov. 20, 2020, 11:27 a.m. UTC
Here series are fixes for hns3 PMD driver.

Chengchang Tang (1):
  net/hns3: fix unused queues with not disabled

Huisong Li (1):
  net/hns3: fix segment fault with the multi-TC

Lijun Ou (1):
  net/hns3: adjust printing MAC addresses in log

Min Hu (Conor) (1):
  net/hns3: fix FEC state query

 drivers/net/hns3/hns3_dcb.c       |  6 +++
 drivers/net/hns3/hns3_ethdev.c    | 91 +++++++++++++++++++++++----------------
 drivers/net/hns3/hns3_ethdev.h    |  2 +
 drivers/net/hns3/hns3_ethdev_vf.c | 32 +++++++-------
 drivers/net/hns3/hns3_rxtx.c      | 35 +++++++++++----
 5 files changed, 106 insertions(+), 60 deletions(-)

Comments

Ferruh Yigit Nov. 20, 2020, 2:38 p.m. UTC | #1
On 11/20/2020 11:27 AM, Lijun Ou wrote:
> Here series are fixes for hns3 PMD driver.
> 
> Chengchang Tang (1):
>    net/hns3: fix unused queues with not disabled
> 
> Huisong Li (1):
>    net/hns3: fix segment fault with the multi-TC
> 
> Lijun Ou (1):
>    net/hns3: adjust printing MAC addresses in log
> 
> Min Hu (Conor) (1):
>    net/hns3: fix FEC state query
> 

Hi Lijun,

How critical these fixes are?
We have -rc5 today, and release this Wednesday, so these will be last minute 
fixes, if these are not critical I suggest postponing to next release and fixes 
can be backported from there to LTS.
oulijun Nov. 20, 2020, 2:58 p.m. UTC | #2
Hi,Ferruh
the first and second patch are critical.
Ferruh Yigit Nov. 20, 2020, 3:38 p.m. UTC | #3
On 11/20/2020 2:58 PM, oulijun wrote:

< Moved to the bottom, please do not top post >

>> 
>> --------------------------------------------------------------------------------
>> 
>> 欧丽军
>> Mobile:+86-18899774289 <tel:+86-18899774289>
>> Email:oulijun@huawei.com <mailto:oulijun@huawei.com>
>> 
>> 
>> *发件人: *Ferruh Yigit<ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>>
>> *收件人: *oulijun<oulijun@huawei.com <mailto:oulijun@huawei.com>>
>> *抄送: *dev<dev@dpdk.org <mailto:dev@dpdk.org>>;Linuxarm<linuxarm@huawei.com 
>> <mailto:linuxarm@huawei.com>>
>> *主题: *Re: [PATCH 0/4] hns3 fixes
>> *时间: *2020-11-20 22:39:13
>> 
>> On 11/20/2020 11:27 AM, Lijun Ou wrote:
>>> Here series are fixes for hns3 PMD driver.
>>> 
>>> Chengchang Tang (1):
>>>    net/hns3: fix unused queues with not disabled
>>> 
>>> Huisong Li (1):
>>>    net/hns3: fix segment fault with the multi-TC
>>> 
>>> Lijun Ou (1):
>>>    net/hns3: adjust printing MAC addresses in log
>>> 
>>> Min Hu (Conor) (1):
>>>    net/hns3: fix FEC state query
>>> 
>> 
>> Hi Lijun,
>> 
>> How critical these fixes are?
>> We have -rc5 today, and release this Wednesday, so these will be last minute
>> fixes, if these are not critical I suggest postponing to next release and fixes
>> can be backported from there to LTS.
 >
 > Hi,Ferruh
 > the first and second patch are critical.
 >

OK, lets target first two patches for this release and defer rest.
Ferruh Yigit Nov. 20, 2020, 5:53 p.m. UTC | #4
On 11/20/2020 3:38 PM, Ferruh Yigit wrote:
> On 11/20/2020 2:58 PM, oulijun wrote:
> 
> < Moved to the bottom, please do not top post >
> 
>>>
>>> --------------------------------------------------------------------------------
>>>
>>> 欧丽军
>>> Mobile:+86-18899774289 <tel:+86-18899774289>
>>> Email:oulijun@huawei.com <mailto:oulijun@huawei.com>
>>>
>>>
>>> *发件人: *Ferruh Yigit<ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>>
>>> *收件人: *oulijun<oulijun@huawei.com <mailto:oulijun@huawei.com>>
>>> *抄送: *dev<dev@dpdk.org <mailto:dev@dpdk.org>>;Linuxarm<linuxarm@huawei.com 
>>> <mailto:linuxarm@huawei.com>>
>>> *主题: *Re: [PATCH 0/4] hns3 fixes
>>> *时间: *2020-11-20 22:39:13
>>>
>>> On 11/20/2020 11:27 AM, Lijun Ou wrote:
>>>> Here series are fixes for hns3 PMD driver.
>>>>
>>>> Chengchang Tang (1):
>>>>    net/hns3: fix unused queues with not disabled
>>>>
>>>> Huisong Li (1):
>>>>    net/hns3: fix segment fault with the multi-TC
>>>>
>>>> Lijun Ou (1):
>>>>    net/hns3: adjust printing MAC addresses in log
>>>>
>>>> Min Hu (Conor) (1):
>>>>    net/hns3: fix FEC state query
>>>>
>>>
>>> Hi Lijun,
>>>
>>> How critical these fixes are?
>>> We have -rc5 today, and release this Wednesday, so these will be last minute
>>> fixes, if these are not critical I suggest postponing to next release and fixes
>>> can be backported from there to LTS.
>  >
>  > Hi,Ferruh
>  > the first and second patch are critical.
>  >
> 
> OK, lets target first two patches for this release and defer rest.

1/4 & 2/4 applied to dpdk-next-net/main, thanks.

3/4 & 4/4 deferred to next release and patchwork status updated accordingly.
oulijun Dec. 7, 2020, 2:54 p.m. UTC | #5
在 2020/11/20 23:38, Ferruh Yigit 写道:
> On 11/20/2020 2:58 PM, oulijun wrote:
> 
> < Moved to the bottom, please do not top post >
> 
>>>
>>> -------------------------------------------------------------------------------- 
>>>
>>>
>>> 欧丽军
>>> Mobile:+86-18899774289 <tel:+86-18899774289>
>>> Email:oulijun@huawei.com <mailto:oulijun@huawei.com>
>>>
>>>
>>> *发件人: *Ferruh Yigit<ferruh.yigit@intel.com 
>>> <mailto:ferruh.yigit@intel.com>>
>>> *收件人: *oulijun<oulijun@huawei.com <mailto:oulijun@huawei.com>>
>>> *抄送: *dev<dev@dpdk.org 
>>> <mailto:dev@dpdk.org>>;Linuxarm<linuxarm@huawei.com 
>>> <mailto:linuxarm@huawei.com>>
>>> *主题: *Re: [PATCH 0/4] hns3 fixes
>>> *时间: *2020-11-20 22:39:13
>>>
>>> On 11/20/2020 11:27 AM, Lijun Ou wrote:
>>>> Here series are fixes for hns3 PMD driver.
>>>>
>>>> Chengchang Tang (1):
>>>>    net/hns3: fix unused queues with not disabled
>>>>
>>>> Huisong Li (1):
>>>>    net/hns3: fix segment fault with the multi-TC
>>>>
>>>> Lijun Ou (1):
>>>>    net/hns3: adjust printing MAC addresses in log
>>>>
>>>> Min Hu (Conor) (1):
>>>>    net/hns3: fix FEC state query
>>>>
>>>
>>> Hi Lijun,
>>>
>>> How critical these fixes are?
>>> We have -rc5 today, and release this Wednesday, so these will be last 
>>> minute
>>> fixes, if these are not critical I suggest postponing to next release 
>>> and fixes
>>> can be backported from there to LTS.
>  >
>  > Hi,Ferruh
>  > the first and second patch are critical.
>  >
> 
> OK, lets target first two patches for this release and defer rest.
> .
Hi, Ferruh Yigit
     Do I directly send a patchv2 package containing the two repaired 
patches or send a new patchset package?

Thanks.
Lijun Ou
>
Ferruh Yigit Dec. 7, 2020, 4:17 p.m. UTC | #6
On 12/7/2020 2:54 PM, oulijun wrote:
> 
> 
> 在 2020/11/20 23:38, Ferruh Yigit 写道:
>> On 11/20/2020 2:58 PM, oulijun wrote:
>>
>> < Moved to the bottom, please do not top post >
>>
>>>>
>>>> -------------------------------------------------------------------------------- 
>>>>
>>>>
>>>> 欧丽军
>>>> Mobile:+86-18899774289 <tel:+86-18899774289>
>>>> Email:oulijun@huawei.com <mailto:oulijun@huawei.com>
>>>>
>>>>
>>>> *发件人: *Ferruh Yigit<ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>>
>>>> *收件人: *oulijun<oulijun@huawei.com <mailto:oulijun@huawei.com>>
>>>> *抄送: *dev<dev@dpdk.org 
>>>> <mailto:dev@dpdk.org>>;Linuxarm<linuxarm@huawei.com 
>>>> <mailto:linuxarm@huawei.com>>
>>>> *主题: *Re: [PATCH 0/4] hns3 fixes
>>>> *时间: *2020-11-20 22:39:13
>>>>
>>>> On 11/20/2020 11:27 AM, Lijun Ou wrote:
>>>>> Here series are fixes for hns3 PMD driver.
>>>>>
>>>>> Chengchang Tang (1):
>>>>>    net/hns3: fix unused queues with not disabled
>>>>>
>>>>> Huisong Li (1):
>>>>>    net/hns3: fix segment fault with the multi-TC
>>>>>
>>>>> Lijun Ou (1):
>>>>>    net/hns3: adjust printing MAC addresses in log
>>>>>
>>>>> Min Hu (Conor) (1):
>>>>>    net/hns3: fix FEC state query
>>>>>
>>>>
>>>> Hi Lijun,
>>>>
>>>> How critical these fixes are?
>>>> We have -rc5 today, and release this Wednesday, so these will be last minute
>>>> fixes, if these are not critical I suggest postponing to next release and fixes
>>>> can be backported from there to LTS.
>>  >
>>  > Hi,Ferruh
>>  > the first and second patch are critical.
>>  >
>>
>> OK, lets target first two patches for this release and defer rest.
>> .
> Hi, Ferruh Yigit
>      Do I directly send a patchv2 package containing the two repaired patches or 
> send a new patchset package?
> 

Hi Lijun,

Sending a v2 with two patches is better, it enables us to see the history of 
patches and comments to previous version easier.

> Thanks.
> Lijun Ou
>>