mbox series

[v3,0/6] vhost: improve ready state

Message ID 1593439701-136089-1-git-send-email-matan@mellanox.com (mailing list archive)
Headers show
Series vhost: improve ready state | expand

Message

Matan Azrad June 29, 2020, 2:08 p.m. UTC
Due to the issue described in "vhost: improve device ready definition"
patch here, we need to change the ready state definition in vhost device.

To support the suggestion improvement there is update for the host notifier control API.

Also need to skip access lock when vDPA device is configured.

Add also support for configuration change when the device is ready.

v3:
Rebase.
Add missing commit: vhost: support host notifier queue configuration.

Matan Azrad (6):
  vhost: support host notifier queue configuration
  vhost: skip access lock when vDPA is configured
  vhost: improve device readiness notifications
  vhost: handle memory hotplug with vDPA devices
  vhost: notify virtq file descriptor update
  vdpa/mlx5: support queue update

 doc/guides/rel_notes/release_20_08.rst |  3 ++
 drivers/vdpa/ifc/ifcvf_vdpa.c          |  6 +--
 drivers/vdpa/mlx5/mlx5_vdpa.c          | 24 ---------
 drivers/vdpa/mlx5/mlx5_vdpa.h          |  8 ++-
 drivers/vdpa/mlx5/mlx5_vdpa_virtq.c    | 80 +++++++++++++++++++--------
 lib/librte_vhost/rte_vdpa.h            |  8 ++-
 lib/librte_vhost/rte_vhost.h           |  1 -
 lib/librte_vhost/vhost.h               |  1 +
 lib/librte_vhost/vhost_user.c          | 99 +++++++++++++++++++++++++---------
 9 files changed, 152 insertions(+), 78 deletions(-)

Comments

Maxime Coquelin June 29, 2020, 5:24 p.m. UTC | #1
On 6/29/20 4:08 PM, Matan Azrad wrote:
> Due to the issue described in "vhost: improve device ready definition"
> patch here, we need to change the ready state definition in vhost device.
> 
> To support the suggestion improvement there is update for the host notifier control API.
> 
> Also need to skip access lock when vDPA device is configured.
> 
> Add also support for configuration change when the device is ready.
> 
> v3:
> Rebase.
> Add missing commit: vhost: support host notifier queue configuration.
> 
> Matan Azrad (6):
>   vhost: support host notifier queue configuration
>   vhost: skip access lock when vDPA is configured
>   vhost: improve device readiness notifications
>   vhost: handle memory hotplug with vDPA devices
>   vhost: notify virtq file descriptor update
>   vdpa/mlx5: support queue update
> 
>  doc/guides/rel_notes/release_20_08.rst |  3 ++
>  drivers/vdpa/ifc/ifcvf_vdpa.c          |  6 +--
>  drivers/vdpa/mlx5/mlx5_vdpa.c          | 24 ---------
>  drivers/vdpa/mlx5/mlx5_vdpa.h          |  8 ++-
>  drivers/vdpa/mlx5/mlx5_vdpa_virtq.c    | 80 +++++++++++++++++++--------
>  lib/librte_vhost/rte_vdpa.h            |  8 ++-
>  lib/librte_vhost/rte_vhost.h           |  1 -
>  lib/librte_vhost/vhost.h               |  1 +
>  lib/librte_vhost/vhost_user.c          | 99 +++++++++++++++++++++++++---------
>  9 files changed, 152 insertions(+), 78 deletions(-)
> 

Applied to dpdk-next-virtio/master

Thanks,
Maxime
Wang, Yinan July 17, 2020, 1:41 a.m. UTC | #2
Hi Matan,

In our daily regression test, we found this patch set will decrease virtio performance and causes virtio interrupt not working properly in multi queue scenarios.  
Could you help to take a look?
Details in Bugzilla  https://bugs.dpdk.org/show_bug.cgi?id=507, btw, pls use low qemu version(qemu<4.1) to reproduce the second issue since the case blocked by one qemu bug with high qemu version.

BR,
Yinan

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Maxime Coquelin
> Sent: 2020年6月30日 1:24
> To: Matan Azrad <matan@mellanox.com>
> Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3 0/6] vhost: improve ready state
> 
> 
> 
> On 6/29/20 4:08 PM, Matan Azrad wrote:
> > Due to the issue described in "vhost: improve device ready definition"
> > patch here, we need to change the ready state definition in vhost device.
> >
> > To support the suggestion improvement there is update for the host notifier
> control API.
> >
> > Also need to skip access lock when vDPA device is configured.
> >
> > Add also support for configuration change when the device is ready.
> >
> > v3:
> > Rebase.
> > Add missing commit: vhost: support host notifier queue configuration.
> >
> > Matan Azrad (6):
> >   vhost: support host notifier queue configuration
> >   vhost: skip access lock when vDPA is configured
> >   vhost: improve device readiness notifications
> >   vhost: handle memory hotplug with vDPA devices
> >   vhost: notify virtq file descriptor update
> >   vdpa/mlx5: support queue update
> >
> >  doc/guides/rel_notes/release_20_08.rst |  3 ++
> >  drivers/vdpa/ifc/ifcvf_vdpa.c          |  6 +--
> >  drivers/vdpa/mlx5/mlx5_vdpa.c          | 24 ---------
> >  drivers/vdpa/mlx5/mlx5_vdpa.h          |  8 ++-
> >  drivers/vdpa/mlx5/mlx5_vdpa_virtq.c    | 80 +++++++++++++++++++--------
> >  lib/librte_vhost/rte_vdpa.h            |  8 ++-
> >  lib/librte_vhost/rte_vhost.h           |  1 -
> >  lib/librte_vhost/vhost.h               |  1 +
> >  lib/librte_vhost/vhost_user.c          | 99 +++++++++++++++++++++++++---------
> >  9 files changed, 152 insertions(+), 78 deletions(-)
> >
> 
> Applied to dpdk-next-virtio/master
> 
> Thanks,
> Maxime