Message ID | 1593439701-136089-1-git-send-email-matan@mellanox.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C51A1A0350; Mon, 29 Jun 2020 16:08:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 06B781BED9; Mon, 29 Jun 2020 16:08:33 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 1DDB51BED0 for <dev@dpdk.org>; Mon, 29 Jun 2020 16:08:32 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from matan@mellanox.com) with SMTP; 29 Jun 2020 17:08:27 +0300 Received: from pegasus25.mtr.labs.mlnx. (pegasus25.mtr.labs.mlnx [10.210.16.10]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 05TE8RgN029797; Mon, 29 Jun 2020 17:08:27 +0300 From: Matan Azrad <matan@mellanox.com> To: Maxime Coquelin <maxime.coquelin@redhat.com> Cc: dev@dpdk.org, Xiao Wang <xiao.w.wang@intel.com> Date: Mon, 29 Jun 2020 14:08:15 +0000 Message-Id: <1593439701-136089-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1593092298-52257-1-git-send-email-matan@mellanox.com> References: <1593092298-52257-1-git-send-email-matan@mellanox.com> Subject: [dpdk-dev] [PATCH v3 0/6] vhost: improve ready state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
vhost: improve ready state
|
|
Message
Matan Azrad
June 29, 2020, 2:08 p.m. UTC
Due to the issue described in "vhost: improve device ready definition" patch here, we need to change the ready state definition in vhost device. To support the suggestion improvement there is update for the host notifier control API. Also need to skip access lock when vDPA device is configured. Add also support for configuration change when the device is ready. v3: Rebase. Add missing commit: vhost: support host notifier queue configuration. Matan Azrad (6): vhost: support host notifier queue configuration vhost: skip access lock when vDPA is configured vhost: improve device readiness notifications vhost: handle memory hotplug with vDPA devices vhost: notify virtq file descriptor update vdpa/mlx5: support queue update doc/guides/rel_notes/release_20_08.rst | 3 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 6 +-- drivers/vdpa/mlx5/mlx5_vdpa.c | 24 --------- drivers/vdpa/mlx5/mlx5_vdpa.h | 8 ++- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 80 +++++++++++++++++++-------- lib/librte_vhost/rte_vdpa.h | 8 ++- lib/librte_vhost/rte_vhost.h | 1 - lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/vhost_user.c | 99 +++++++++++++++++++++++++--------- 9 files changed, 152 insertions(+), 78 deletions(-)
Comments
On 6/29/20 4:08 PM, Matan Azrad wrote: > Due to the issue described in "vhost: improve device ready definition" > patch here, we need to change the ready state definition in vhost device. > > To support the suggestion improvement there is update for the host notifier control API. > > Also need to skip access lock when vDPA device is configured. > > Add also support for configuration change when the device is ready. > > v3: > Rebase. > Add missing commit: vhost: support host notifier queue configuration. > > Matan Azrad (6): > vhost: support host notifier queue configuration > vhost: skip access lock when vDPA is configured > vhost: improve device readiness notifications > vhost: handle memory hotplug with vDPA devices > vhost: notify virtq file descriptor update > vdpa/mlx5: support queue update > > doc/guides/rel_notes/release_20_08.rst | 3 ++ > drivers/vdpa/ifc/ifcvf_vdpa.c | 6 +-- > drivers/vdpa/mlx5/mlx5_vdpa.c | 24 --------- > drivers/vdpa/mlx5/mlx5_vdpa.h | 8 ++- > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 80 +++++++++++++++++++-------- > lib/librte_vhost/rte_vdpa.h | 8 ++- > lib/librte_vhost/rte_vhost.h | 1 - > lib/librte_vhost/vhost.h | 1 + > lib/librte_vhost/vhost_user.c | 99 +++++++++++++++++++++++++--------- > 9 files changed, 152 insertions(+), 78 deletions(-) > Applied to dpdk-next-virtio/master Thanks, Maxime
Hi Matan, In our daily regression test, we found this patch set will decrease virtio performance and causes virtio interrupt not working properly in multi queue scenarios. Could you help to take a look? Details in Bugzilla https://bugs.dpdk.org/show_bug.cgi?id=507, btw, pls use low qemu version(qemu<4.1) to reproduce the second issue since the case blocked by one qemu bug with high qemu version. BR, Yinan > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Maxime Coquelin > Sent: 2020年6月30日 1:24 > To: Matan Azrad <matan@mellanox.com> > Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com> > Subject: Re: [dpdk-dev] [PATCH v3 0/6] vhost: improve ready state > > > > On 6/29/20 4:08 PM, Matan Azrad wrote: > > Due to the issue described in "vhost: improve device ready definition" > > patch here, we need to change the ready state definition in vhost device. > > > > To support the suggestion improvement there is update for the host notifier > control API. > > > > Also need to skip access lock when vDPA device is configured. > > > > Add also support for configuration change when the device is ready. > > > > v3: > > Rebase. > > Add missing commit: vhost: support host notifier queue configuration. > > > > Matan Azrad (6): > > vhost: support host notifier queue configuration > > vhost: skip access lock when vDPA is configured > > vhost: improve device readiness notifications > > vhost: handle memory hotplug with vDPA devices > > vhost: notify virtq file descriptor update > > vdpa/mlx5: support queue update > > > > doc/guides/rel_notes/release_20_08.rst | 3 ++ > > drivers/vdpa/ifc/ifcvf_vdpa.c | 6 +-- > > drivers/vdpa/mlx5/mlx5_vdpa.c | 24 --------- > > drivers/vdpa/mlx5/mlx5_vdpa.h | 8 ++- > > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 80 +++++++++++++++++++-------- > > lib/librte_vhost/rte_vdpa.h | 8 ++- > > lib/librte_vhost/rte_vhost.h | 1 - > > lib/librte_vhost/vhost.h | 1 + > > lib/librte_vhost/vhost_user.c | 99 +++++++++++++++++++++++++--------- > > 9 files changed, 152 insertions(+), 78 deletions(-) > > > > Applied to dpdk-next-virtio/master > > Thanks, > Maxime