mbox series

[v2,0/3] Introduce new class for vDPA device drivers

Message ID 1578567617-3541-1-git-send-email-matan@mellanox.com (mailing list archive)
Headers
Series Introduce new class for vDPA device drivers |

Message

Matan Azrad Jan. 9, 2020, 11 a.m. UTC
  As discussed and as described in RFC "[RFC] net: new vdpa PMD for Mellanox devices", new vDPA driver is going to be added for Mellanox devices - vDPA mlx5 and more.

The only vDPA driver now is the IFC driver that is located in net directory.

The IFC driver and the new vDPA mlx5 driver provide the vDPA ops introduced in librte_vhost and not the eth-dev ops.
All the others drivers in net class provide the eth-dev ops.
The set of features is also different.

Create a new class for vDPA drivers and move IFC to this class.
Later, all the new drivers that implement the vDPA ops will be added to the vDPA class.

Also, a vDPA device driver features list was added to vDPA documentation.

Please review the features list and the series.

Later on, I'm going to send the vDPA mlx5 driver.

Thanks.

v2:
Apply comments from Maxime Coquelin, Andrew Rybchenko and Tiwei Bie.


Matan Azrad (3):
  drivers: introduce vDPA class
  doc: add vDPA feature table
  drivers: move ifc driver to the vDPA class

 MAINTAINERS                               |   19 +-
 doc/guides/conf.py                        |    5 +
 doc/guides/index.rst                      |    1 +
 doc/guides/nics/features/ifcvf.ini        |    8 -
 doc/guides/nics/ifc.rst                   |  106 ---
 doc/guides/nics/index.rst                 |    1 -
 doc/guides/vdpadevs/features/default.ini  |   50 ++
 doc/guides/vdpadevs/features/ifcvf.ini    |    8 +
 doc/guides/vdpadevs/features_overview.rst |   74 ++
 doc/guides/vdpadevs/ifc.rst               |  106 +++
 doc/guides/vdpadevs/index.rst             |   15 +
 drivers/Makefile                          |    2 +
 drivers/meson.build                       |    1 +
 drivers/net/Makefile                      |    3 -
 drivers/net/ifc/Makefile                  |   34 -
 drivers/net/ifc/base/ifcvf.c              |  329 --------
 drivers/net/ifc/base/ifcvf.h              |  162 ----
 drivers/net/ifc/base/ifcvf_osdep.h        |   52 --
 drivers/net/ifc/ifcvf_vdpa.c              | 1280 -----------------------------
 drivers/net/ifc/meson.build               |    9 -
 drivers/net/ifc/rte_pmd_ifc_version.map   |    3 -
 drivers/net/meson.build                   |    1 -
 drivers/vdpa/Makefile                     |   14 +
 drivers/vdpa/ifc/Makefile                 |   34 +
 drivers/vdpa/ifc/base/ifcvf.c             |  329 ++++++++
 drivers/vdpa/ifc/base/ifcvf.h             |  162 ++++
 drivers/vdpa/ifc/base/ifcvf_osdep.h       |   52 ++
 drivers/vdpa/ifc/ifcvf_vdpa.c             | 1280 +++++++++++++++++++++++++++++
 drivers/vdpa/ifc/meson.build              |    9 +
 drivers/vdpa/ifc/rte_pmd_ifc_version.map  |    3 +
 drivers/vdpa/meson.build                  |    8 +
 31 files changed, 2164 insertions(+), 1996 deletions(-)
 delete mode 100644 doc/guides/nics/features/ifcvf.ini
 delete mode 100644 doc/guides/nics/ifc.rst
 create mode 100644 doc/guides/vdpadevs/features/default.ini
 create mode 100644 doc/guides/vdpadevs/features/ifcvf.ini
 create mode 100644 doc/guides/vdpadevs/features_overview.rst
 create mode 100644 doc/guides/vdpadevs/ifc.rst
 create mode 100644 doc/guides/vdpadevs/index.rst
 delete mode 100644 drivers/net/ifc/Makefile
 delete mode 100644 drivers/net/ifc/base/ifcvf.c
 delete mode 100644 drivers/net/ifc/base/ifcvf.h
 delete mode 100644 drivers/net/ifc/base/ifcvf_osdep.h
 delete mode 100644 drivers/net/ifc/ifcvf_vdpa.c
 delete mode 100644 drivers/net/ifc/meson.build
 delete mode 100644 drivers/net/ifc/rte_pmd_ifc_version.map
 create mode 100644 drivers/vdpa/Makefile
 create mode 100644 drivers/vdpa/ifc/Makefile
 create mode 100644 drivers/vdpa/ifc/base/ifcvf.c
 create mode 100644 drivers/vdpa/ifc/base/ifcvf.h
 create mode 100644 drivers/vdpa/ifc/base/ifcvf_osdep.h
 create mode 100644 drivers/vdpa/ifc/ifcvf_vdpa.c
 create mode 100644 drivers/vdpa/ifc/meson.build
 create mode 100644 drivers/vdpa/ifc/rte_pmd_ifc_version.map
 create mode 100644 drivers/vdpa/meson.build
  

Comments

Thomas Monjalon Jan. 13, 2020, 11:08 p.m. UTC | #1
09/01/2020 12:00, Matan Azrad:
> v2:
> Apply comments from Maxime Coquelin, Andrew Rybchenko and Tiwei Bie.
> 
> 
> Matan Azrad (3):
>   drivers: introduce vDPA class
>   doc: add vDPA feature table
>   drivers: move ifc driver to the vDPA class

I've fixed few minor things as discussed in this thread.

Summary of other discussions:
- Rosen said he "is not blocking the integration of this patch".
- ifc features need to be filled in a separate patch.
- ifc patches will be merged in the next-virtio tree starting now.
- Andrew and Tiwei asked for some changes in the doc which are addressed in v2,
or justified (features description is chosen to be kept simple for now).

This is the very first step for this new drivers directory,
and we will surely apply some improvements in this area
when adding more drivers.

Applied, thanks