Message ID | 1571856864-8779-1-git-send-email-david.marchand@redhat.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D6271C2A3; Wed, 23 Oct 2019 20:54:41 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id E9A331C203 for <dev@dpdk.org>; Wed, 23 Oct 2019 20:54:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571856879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IunvZcDV5ALkxO79DnHzJa6GH7AAqa8Ux3e49UBmDsc=; b=Pc7WTcqyvHIOiW/3hLINklKrnPNCvXf0rb+VeUhidQuQkE4jEm0Mc6HZIehfHlr/sPjbvf podDVBadtwo59aDtcXMPc5sAfD2I/HgFHKgA3ivG6jC8F6DP3TTcU3A9V6Q35fNzFG6RCb PNAgsGmsecdE19vagHjQJtRdWLpOWI4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-100-vz7t8edJN7O5f7NJfOI3JA-1; Wed, 23 Oct 2019 14:54:35 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A53F51005500; Wed, 23 Oct 2019 18:54:34 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com [10.40.204.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB79660872; Wed, 23 Oct 2019 18:54:32 +0000 (UTC) From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: stephen@networkplumber.org, anatoly.burakov@intel.com, thomas@monjalon.net Date: Wed, 23 Oct 2019 20:54:12 +0200 Message-Id: <1571856864-8779-1-git-send-email-david.marchand@redhat.com> In-Reply-To: <1571736761-32134-1-git-send-email-david.marchand@redhat.com> References: <1571736761-32134-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: vz7t8edJN7O5f7NJfOI3JA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH v2 00/12] EAL and PCI ABI changes for 19.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
EAL and PCI ABI changes for 19.11
|
|
Message
David Marchand
Oct. 23, 2019, 6:54 p.m. UTC
Let's prepare for the ABI freeze. The first patches are about changes that had been announced before (with a patch from Stephen that I took as it is ready as is from my pov). The malloc_heap structure from the memory subsystem can be hidden. The PCI library had some forgotten deprecated APIs that are removed with this series. rte_logs could be hidden, but I am not that confortable about doing it right away: I added an accessor to rte_logs.file, but I am fine with dropping the last patch and wait for actually hiding this in the next ABI break. Changelog since v1: - I went a step further, hiding rte_config after de-inlining non critical functions Comments?
Comments
On Wed, 23 Oct 2019 20:54:12 +0200 David Marchand <david.marchand@redhat.com> wrote: > Let's prepare for the ABI freeze. > > The first patches are about changes that had been announced before (with > a patch from Stephen that I took as it is ready as is from my pov). > > The malloc_heap structure from the memory subsystem can be hidden. > The PCI library had some forgotten deprecated APIs that are removed with > this series. > > rte_logs could be hidden, but I am not that confortable about > doing it right away: I added an accessor to rte_logs.file, but I am fine > with dropping the last patch and wait for actually hiding this in the next > ABI break. 19.11 is an api/abi break so maybe do it now.
On Wed, Oct 23, 2019 at 11:10 PM Stephen Hemminger <stephen@networkplumber.org> wrote: > > On Wed, 23 Oct 2019 20:54:12 +0200 > David Marchand <david.marchand@redhat.com> wrote: > > > Let's prepare for the ABI freeze. > > > > The first patches are about changes that had been announced before (with > > a patch from Stephen that I took as it is ready as is from my pov). > > > > The malloc_heap structure from the memory subsystem can be hidden. > > The PCI library had some forgotten deprecated APIs that are removed with > > this series. > > > > rte_logs could be hidden, but I am not that confortable about > > doing it right away: I added an accessor to rte_logs.file, but I am fine > > with dropping the last patch and wait for actually hiding this in the next > > ABI break. > > 19.11 is an api/abi break so maybe do it now. Did you look at the 4 new patches too? Same concern + this was not announced before either. I went and hid more internals, I did not see an impact on really basic bench. I would appreciate other opinions.
On Thu, 24 Oct 2019 09:32:10 +0200 David Marchand <david.marchand@redhat.com> wrote: > On Wed, Oct 23, 2019 at 11:10 PM Stephen Hemminger > <stephen@networkplumber.org> wrote: > > > > On Wed, 23 Oct 2019 20:54:12 +0200 > > David Marchand <david.marchand@redhat.com> wrote: > > > > > Let's prepare for the ABI freeze. > > > > > > The first patches are about changes that had been announced before (with > > > a patch from Stephen that I took as it is ready as is from my pov). > > > > > > The malloc_heap structure from the memory subsystem can be hidden. > > > The PCI library had some forgotten deprecated APIs that are removed with > > > this series. > > > > > > rte_logs could be hidden, but I am not that confortable about > > > doing it right away: I added an accessor to rte_logs.file, but I am fine > > > with dropping the last patch and wait for actually hiding this in the next > > > ABI break. > > > > 19.11 is an api/abi break so maybe do it now. > > Did you look at the 4 new patches too? > > Same concern + this was not announced before either. > I went and hid more internals, I did not see an impact on really basic bench. > > I would appreciate other opinions. > > These all look good. There is probably a lot more that could be done, adding more accessors in 20.02 could help but more hiding won't happen again until 20.11
On Thu, Oct 24, 2019 at 5:37 PM Stephen Hemminger <stephen@networkplumber.org> wrote: > > > > rte_logs could be hidden, but I am not that confortable about > > > > doing it right away: I added an accessor to rte_logs.file, but I am fine > > > > with dropping the last patch and wait for actually hiding this in the next > > > > ABI break. > > > > > > 19.11 is an api/abi break so maybe do it now. > > > > I went and hid more internals, I did not see an impact on really basic bench. > > > > I would appreciate other opinions. > > These all look good. There is probably a lot more that could be > done, adding more accessors in 20.02 could help but more hiding won't happen > again until 20.11 Yes, I went with the low hanging fruits. It is a long term effort in any case, when reviewing too.
23/10/2019 20:54, David Marchand: > Let's prepare for the ABI freeze. > > The first patches are about changes that had been announced before (with > a patch from Stephen that I took as it is ready as is from my pov). > > The malloc_heap structure from the memory subsystem can be hidden. > The PCI library had some forgotten deprecated APIs that are removed with > this series. > > rte_logs could be hidden, but I am not that confortable about > doing it right away: I added an accessor to rte_logs.file, but I am fine > with dropping the last patch and wait for actually hiding this in the next > ABI break. > > Changelog since v1: > - I went a step further, hiding rte_config after de-inlining non critical > functions > > Comments? Except patch 8 (hiding rte_logs), Acked-by: Thomas Monjalon <thomas@monjalon.net>