[v2,0/3] Add dual threading in QAT PMD

  Remove the limitation whereby enqueue and dequeue must be
done in same thread.
The inflight calculation is reworked to be thread-safe for 2
threads - note this is not general multi-thread support, i.e
all enqueues to a qp must still be done in one thread and
all dequeues must be done in one thread, but enqueues and
dequeues may be in separate threads.
As the tail-coalescing feature is not
threadsafe it is removed first.

v2 changes:
 - clarified wording in docs

Fiona Trahe (3):
  common/qat: remove tail write coalescing feature
  common/qat: move max inflights param into qp
  common/qat: add dual thread support

 doc/guides/compressdevs/qat_comp.rst |  5 ++-
 doc/guides/cryptodevs/qat.rst        | 11 +++++-
 drivers/common/qat/qat_qp.c          | 77 ++++++++++++++++++------------------
 drivers/common/qat/qat_qp.h          | 11 ++----
 4 files changed, 54 insertions(+), 50 deletions(-)
  

Hi Fiona,

This patchset need a rebase. Could you please send v3.

Thanks,
Akhil

> -----Original Message-----
> From: Fiona Trahe <fiona.trahe@intel.com>
> Sent: Friday, September 6, 2019 9:42 PM
> To: dev@dpdk.org
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; arkadiuszx.kusztal@intel.com;
> fiona.trahe@intel.com
> Subject: [PATCH v2 0/3] Add dual threading in QAT PMD
> 
> Remove the limitation whereby enqueue and dequeue must be
> done in same thread.
> The inflight calculation is reworked to be thread-safe for 2
> threads - note this is not general multi-thread support, i.e
> all enqueues to a qp must still be done in one thread and
> all dequeues must be done in one thread, but enqueues and
> dequeues may be in separate threads.
> As the tail-coalescing feature is not
> threadsafe it is removed first.
> 
> v2 changes:
>  - clarified wording in docs
> 
> Fiona Trahe (3):
>   common/qat: remove tail write coalescing feature
>   common/qat: move max inflights param into qp
>   common/qat: add dual thread support
> 
>  doc/guides/compressdevs/qat_comp.rst |  5 ++-
>  doc/guides/cryptodevs/qat.rst        | 11 +++++-
>  drivers/common/qat/qat_qp.c          | 77 ++++++++++++++++++------------------
>  drivers/common/qat/qat_qp.h          | 11 ++----
>  4 files changed, 54 insertions(+), 50 deletions(-)
> 
> --
> 2.13.6
  

Hi Akhil,
We're going to defer this patchset this to 20.02. 
We want to add another patch to it to mitigate some performance impacts it causes.#
I'm not sure of the process for this - do I just mark it in patchwork as deferred?
Or is there a tag I can put in an email, like Deferred-by?
Fiona

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Friday, October 4, 2019 11:48 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: RE: [PATCH v2 0/3] Add dual threading in QAT PMD
> 
> Hi Fiona,
> 
> This patchset need a rebase. Could you please send v3.
> 
> Thanks,
> Akhil
> 
> > -----Original Message-----
> > From: Fiona Trahe <fiona.trahe@intel.com>
> > Sent: Friday, September 6, 2019 9:42 PM
> > To: dev@dpdk.org
> > Cc: Akhil Goyal <akhil.goyal@nxp.com>; arkadiuszx.kusztal@intel.com;
> > fiona.trahe@intel.com
> > Subject: [PATCH v2 0/3] Add dual threading in QAT PMD
> >
> > Remove the limitation whereby enqueue and dequeue must be
> > done in same thread.
> > The inflight calculation is reworked to be thread-safe for 2
> > threads - note this is not general multi-thread support, i.e
> > all enqueues to a qp must still be done in one thread and
> > all dequeues must be done in one thread, but enqueues and
> > dequeues may be in separate threads.
> > As the tail-coalescing feature is not
> > threadsafe it is removed first.
> >
> > v2 changes:
> >  - clarified wording in docs
> >
> > Fiona Trahe (3):
> >   common/qat: remove tail write coalescing feature
> >   common/qat: move max inflights param into qp
> >   common/qat: add dual thread support
> >
> >  doc/guides/compressdevs/qat_comp.rst |  5 ++-
> >  doc/guides/cryptodevs/qat.rst        | 11 +++++-
> >  drivers/common/qat/qat_qp.c          | 77 ++++++++++++++++++------------------
> >  drivers/common/qat/qat_qp.h          | 11 ++----
> >  4 files changed, 54 insertions(+), 50 deletions(-)
> >
> > --
> > 2.13.6