mbox series

[00/11] Fixing log levels for dynamically loaded drivers

Message ID 1566214919-32250-1-git-send-email-david.marchand@redhat.com (mailing list archive)
Headers show
Series Fixing log levels for dynamically loaded drivers | expand

Message

David Marchand Aug. 19, 2019, 11:41 a.m. UTC 
All (but the Solarflare net driver) drivers currently do not care about
the log level the user might have passed at init time.

Convert existing drivers from rte_log_register to a new wrapper
RTE_LOG_REGISTER that relies on rte_log_register_type_and_pick_level
that handles this issue.

Comments

Ferruh Yigit Sept. 2, 2019, 2:17 p.m. UTC | #1 
On 8/19/2019 12:41 PM, David Marchand wrote:
> All (but the Solarflare net driver) drivers currently do not care about
> the log level the user might have passed at init time.

Is this comment for the shared libraries?
Because otherwise drivers set loglevel during initialization and init time
setting should be reflected to the logtypes before devices probed.

> 
> Convert existing drivers from rte_log_register to a new wrapper
> RTE_LOG_REGISTER that relies on rte_log_register_type_and_pick_level
> that handles this issue.
> 
>
David Marchand Sept. 3, 2019, 8:06 a.m. UTC | #2 
On Mon, Sep 2, 2019 at 4:17 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 8/19/2019 12:41 PM, David Marchand wrote:
> > All (but the Solarflare net driver) drivers currently do not care about
> > the log level the user might have passed at init time.
>
> Is this comment for the shared libraries?
> Because otherwise drivers set loglevel during initialization and init time
> setting should be reflected to the logtypes before devices probed.

Indeed, the issue is seen when building drivers as shared libraries.


--
David Marchand