mbox series

[v4,0/2] lib/librte_meter: add RFC4115 trTCM meter support

Message ID 154661036216.75321.4852909033090962683.stgit@dbuild (mailing list archive)
Headers
Series lib/librte_meter: add RFC4115 trTCM meter support |

Message

Eelco Chaudron Jan. 4, 2019, 1:59 p.m. UTC 
  This patch adds support for RFC4115 trTCM meters.


Signed-off-by: Eelco Chaudron <echaudro@redhat.com>

v4:
 - Fixed typo
 - Cleaned up code to be aligned with RFC diagram

v3:
 - Gave the rfc4115 meter it's own data structures

v2:
 - Marked all functions with __rte_experimental, and added
   "EXPERIMENTAL:..." to doxygen comments.
 - Removed library version change, and merged it with first patch
 - Do not call rte_meter_trtcm_rfc4115_color_aware_check in
   rte_meter_trtcm_rfc4115_color_blind_check to avoid error with
   it being marked as experimental

Eelco Chaudron (2):
      lib/librte_meter: add RFC4115 trTCM meter support
      test/test_meter: update meter test to include RFC4115 meters


 lib/librte_meter/rte_meter.c           |   42 ++++++
 lib/librte_meter/rte_meter.h           |  233 ++++++++++++++++++++++++++++++++
 lib/librte_meter/rte_meter_version.map |    9 +
 test/test/test_meter.c                 |  212 +++++++++++++++++++++++++++++
 4 files changed, 494 insertions(+), 2 deletions(-)

Comments

Cristian Dumitrescu Jan. 7, 2019, 3:58 p.m. UTC | #1 
> -----Original Message-----
> From: Eelco Chaudron [mailto:echaudro@redhat.com]
> Sent: Friday, January 4, 2019 2:00 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH v4 0/2] lib/librte_meter: add RFC4115 trTCM meter support
> 
> This patch adds support for RFC4115 trTCM meters.
> 
> 
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> 
> v4:
>  - Fixed typo
>  - Cleaned up code to be aligned with RFC diagram
> 

Series Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied to next-qos tree, thanks!
Thomas Monjalon Jan. 9, 2019, 11:22 p.m. UTC | #2 
07/01/2019 16:58, Dumitrescu, Cristian:
> From: Eelco Chaudron [mailto:echaudro@redhat.com]
> > 
> > This patch adds support for RFC4115 trTCM meters.
> > 
> > 
> > Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> > 
> > v4:
> >  - Fixed typo
> >  - Cleaned up code to be aligned with RFC diagram
> > 
> 
> Series Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Applied to next-qos tree, thanks!

#include "rte_compat.h" is missing.
Fixing in-tree
Eelco Chaudron Jan. 10, 2019, 8:25 a.m. UTC | #3 
Thanks Thomas!

On 10 Jan 2019, at 0:22, Thomas Monjalon wrote:

> 07/01/2019 16:58, Dumitrescu, Cristian:
>> From: Eelco Chaudron [mailto:echaudro@redhat.com]
>>>
>>> This patch adds support for RFC4115 trTCM meters.
>>>
>>>
>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>>
>>> v4:
>>>  - Fixed typo
>>>  - Cleaned up code to be aligned with RFC diagram
>>>
>>
>> Series Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>
>> Applied to next-qos tree, thanks!
>
> #include "rte_compat.h" is missing.
> Fixing in-tree