Message ID | 1537541639-22764-1-git-send-email-amo@semihalf.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD0A6326D; Fri, 21 Sep 2018 16:54:02 +0200 (CEST) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id 908D51DA4 for <dev@dpdk.org>; Fri, 21 Sep 2018 16:54:01 +0200 (CEST) Received: by mail-lf1-f67.google.com with SMTP id m26-v6so11726591lfb.0 for <dev@dpdk.org>; Fri, 21 Sep 2018 07:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+6RT/7GA20wEvHvG/vfKllpXFgc0KHZnB7Iz/3hHGEU=; b=bESbFVoBBCbWuYiqu2hP7Q77bcVkYT00tEoEfDB5ja0yST3iC4z7Gd+DWC+zCc9HVT UTY5Czr+H0lMKFcWKNqbXF9/QBc2iGzAi9FwPsOXKeijwK0n7XHud0Lu7LnoBCg+hvF/ 6nBuze2uRL0hoogR+WIS8xWA/1q4dkFKbGbHkttBvptK98gDd8Uo8i5ABcijb2BBZzDm J0xTcu3A2E33ZZ/x3g2V2C7/Ot9fa/8wi3QnLlIoC248k1O+gdcqQdytOfzNdHctiaBh T5P1yg4LxuzQPgUuJ9wyAKgnbhktgqF1hqSRMQP/ZE72BsRltRNDkKghrA1UOtAOJxLO 7pXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+6RT/7GA20wEvHvG/vfKllpXFgc0KHZnB7Iz/3hHGEU=; b=uJpLWaYXaGxFgr/q4J55nJWgnNbeHCdgShrB784PTcjBDQYdDLc8IEksfy9ulpWk+h xfGgRVGTa34wKMhfpMQ2KocIa4PZbsb536aXOiDIbmkqrdDNFbCjwzzD5jujSRtNrfHH z/ISTEyvp4ltHzuDEiEvvnNJmhpf9FPXAnD+YEms37/U4bAoGuASF+Hp5zOx+x4MeKWJ h+4MKEUgy3PuH0zUo8KA4xckNrBmgypGeDTGy/FYdjDjqgRmqkuOANaC7in0nDYEkTqB 54JDxBaSVboBOk5fyl5rcHQgBXCGq9ztutFESpqvGSw8+0VexVF6VKKfAyR9jFt88Iw7 HjXQ== X-Gm-Message-State: APzg51BpdriQBYC7aaVebpoUd0LEIDVC0HOz/eWdqjhiN3c0F582DT0p NtjRy4doK8+YTNd6D36R0uN+CAnuMyw= X-Google-Smtp-Source: ANB0VdZofNB27QGlK5SKVkYt6KYYfkDpzl/zgvs0DEyZlUYr+Tvw/tYVRjz2ACMHutJLk/boWy9gMw== X-Received: by 2002:a19:4ed3:: with SMTP id u80-v6mr17042664lfk.55.1537541640872; Fri, 21 Sep 2018 07:54:00 -0700 (PDT) Received: from amok.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.googlemail.com with ESMTPSA id d13-v6sm2268744lfi.74.2018.09.21.07.53.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 21 Sep 2018 07:54:00 -0700 (PDT) From: Andrzej Ostruszka <amo@semihalf.com> To: dev@dpdk.org Cc: mw@semihalf.com, nadavh@marvell.com Date: Fri, 21 Sep 2018 16:53:53 +0200 Message-Id: <1537541639-22764-1-git-send-email-amo@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1535118895-6505-1-git-send-email-tdu@semihalf.com> References: <1535118895-6505-1-git-send-email-tdu@semihalf.com> Subject: [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
crypto/mvsam: add new features and fixes
|
|
Message
Andrzej Ostruszka
Sept. 21, 2018, 2:53 p.m. UTC
This patch series introduces following changes: * Add support for HMAC SHA224, AES ECB and NULL algorithms. * Update hash digest sizes to match hardware capabilities. * Fix a shared build. v2: * added Cc: stable@dpdk.org to couple of patches * rephrased the subject/commit msgs Szymon Sliwa (1): crypto/mvsam: update hash digest sizes Tomasz Duszynski (5): crypto/mvsam: fix shared library build crypto/mvsam: support for HMAC SHA224 crypto/mvsam: support for AES ECB crypto/mvsam: support for crypto/auth NULL algorithms crypto/mvsam: add 3DES ECB to the capabilities list drivers/crypto/mvsam/Makefile | 2 +- drivers/crypto/mvsam/rte_mrvl_pmd.c | 15 ++++ drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 150 +++++++++++++++++++++++++++----- 3 files changed, 144 insertions(+), 23 deletions(-)
Comments
Hi Andrzej, On 9/21/2018 8:23 PM, Andrzej Ostruszka wrote: > This patch series introduces following changes: > > * Add support for HMAC SHA224, AES ECB and NULL algorithms. > * Update hash digest sizes to match hardware capabilities. > * Fix a shared build. > > v2: > * added Cc: stable@dpdk.org to couple of patches > * rephrased the subject/commit msgs > > Szymon Sliwa (1): > crypto/mvsam: update hash digest sizes > > Tomasz Duszynski (5): > crypto/mvsam: fix shared library build > crypto/mvsam: support for HMAC SHA224 > crypto/mvsam: support for AES ECB > crypto/mvsam: support for crypto/auth NULL algorithms > crypto/mvsam: add 3DES ECB to the capabilities list > > drivers/crypto/mvsam/Makefile | 2 +- > drivers/crypto/mvsam/rte_mrvl_pmd.c | 15 ++++ > drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 150 +++++++++++++++++++++++++++----- > 3 files changed, 144 insertions(+), 23 deletions(-) > I am not able to cleanly apply your 3 patchsets. http://patches.dpdk.org/user/todo/dpdk/?series=1172 http://patches.dpdk.org/user/todo/dpdk/?series=1440 http://patches.dpdk.org/user/todo/dpdk/?series=1442 Could you please rebase and send a single patchset if possible. Also, I believe http://patches.dpdk.org/patch/44254/ can be squashed with http://patches.dpdk.org/patch/45104/ Thanks, Akhil
Hello Akhil On 25.09.2018 17:24, Akhil Goyal wrote: > Hi Andrzej, [...] > I am not able to cleanly apply your 3 patchsets. > http://patches.dpdk.org/user/todo/dpdk/?series=1172 > http://patches.dpdk.org/user/todo/dpdk/?series=1440 > http://patches.dpdk.org/user/todo/dpdk/?series=1442 > > Could you please rebase and send a single patchset if possible. The problem is that next-crypto is not in sync with next-net. In particular it is missing this commit: 7a39d1b common/mvep: add common code for Marvell drivers Could you rebase/merge next-crypto with next-net to have this commit? > Also, I believe http://patches.dpdk.org/patch/44254/ > can be squashed with http://patches.dpdk.org/patch/45104/ No problem I can package all patches into one set but as mentioned above some of them depend on common mvep code introduced already in next-net. Best regards Andrzej
On 9/26/2018 3:33 PM, Andrzej Ostruszka wrote: > Hello Akhil > > On 25.09.2018 17:24, Akhil Goyal wrote: >> Hi Andrzej, > [...] >> I am not able to cleanly apply your 3 patchsets. >> http://patches.dpdk.org/user/todo/dpdk/?series=1172 >> http://patches.dpdk.org/user/todo/dpdk/?series=1440 >> http://patches.dpdk.org/user/todo/dpdk/?series=1442 >> >> Could you please rebase and send a single patchset if possible. > The problem is that next-crypto is not in sync with next-net. In > particular it is missing this commit: > > 7a39d1b common/mvep: add common code for Marvell drivers > > Could you rebase/merge next-crypto with next-net to have this commit? If it is dependent on net-next, then I will defer this set to be applied next week when the master is in sync with net-next. > >> Also, I believe http://patches.dpdk.org/patch/44254/ >> can be squashed with http://patches.dpdk.org/patch/45104/ > No problem I can package all patches into one set but as mentioned above > some of them depend on common mvep code introduced already in next-net. No need for now.. I will wait for master to get in sync and then apply the dependent patches. Is there any series which can be applied without any dependency? And it would be a good practice to mention the dependencies in the cover note in future. -Akhil
On 9/21/2018 8:23 PM, Andrzej Ostruszka wrote: > This patch series introduces following changes: > > * Add support for HMAC SHA224, AES ECB and NULL algorithms. > * Update hash digest sizes to match hardware capabilities. > * Fix a shared build. > > v2: > * added Cc: stable@dpdk.org to couple of patches > * rephrased the subject/commit msgs > > Szymon Sliwa (1): > crypto/mvsam: update hash digest sizes > > Tomasz Duszynski (5): > crypto/mvsam: fix shared library build > crypto/mvsam: support for HMAC SHA224 > crypto/mvsam: support for AES ECB > crypto/mvsam: support for crypto/auth NULL algorithms > crypto/mvsam: add 3DES ECB to the capabilities list > > drivers/crypto/mvsam/Makefile | 2 +- > drivers/crypto/mvsam/rte_mrvl_pmd.c | 15 ++++ > drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 150 +++++++++++++++++++++++++++----- > 3 files changed, 144 insertions(+), 23 deletions(-) Series applied to dpdk-next-crypto Thanks