Message ID | 1533910253-29652-1-git-send-email-fiona.trahe@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F3EF2661; Fri, 10 Aug 2018 16:11:04 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 39388FEB for <dev@dpdk.org>; Fri, 10 Aug 2018 16:11:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2018 07:11:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,219,1531810800"; d="scan'208";a="82324073" Received: from sivswdev01.ir.intel.com (HELO localhost.localdomain) ([10.237.217.45]) by orsmga002.jf.intel.com with ESMTP; 10 Aug 2018 07:10:58 -0700 From: Fiona Trahe <fiona.trahe@intel.com> To: dev@dpdk.org, pablo.de.lara.guarch@intel.com, tomaszx.jozwiak@intel.com, thomas@monjalon.net Cc: fiona.trahe@intel.com Date: Fri, 10 Aug 2018 15:10:47 +0100 Message-Id: <1533910253-29652-1-git-send-email-fiona.trahe@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: <1533833430-29134-8-git-send-email-fiona.trahe@intel.com> References: <1533833430-29134-8-git-send-email-fiona.trahe@intel.com> Subject: [dpdk-dev] [PATCH v3 0/6] doc/qat: clarify build config options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
doc/qat: clarify build config options
|
|
Message
Fiona Trahe
Aug. 10, 2018, 2:10 p.m. UTC
Clarified documentation structure between compressedev, cryptodev and common build parts. Clarified build configuration options. Added Testing section. Fixed typos and made some cosmetic improvements. v3 changes - squashed some patches - added more text to remaining commit msgs - fixed underline line length - fixed typo: comp_qat should be qat v2 changes - split into patchset - changed test path from build/build/test/test to build/app - use make defconfig instead of make config T=xxx - matched underline lengths to titles Fiona Trahe (6): doc/qat: add limitations to compressdev PMD doc/qat: add information on how to test doc/qat: fix typos and make cosmetic changes doc/qat: add overview of doc sections doc/qat: update build instructions for both PMDs doc/qat: describe build config options doc/guides/compressdevs/qat_comp.rst | 6 +- doc/guides/cryptodevs/qat.rst | 195 +++++++++++++++++++++++++---------- 2 files changed, 143 insertions(+), 58 deletions(-)
Comments
-----Original Message-----
From: Trahe, Fiona
Sent: Friday, August 10, 2018 4:11 PM
To: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; thomas@monjalon.net
Cc: Trahe, Fiona <fiona.trahe@intel.com>
Subject: [PATCH v3 0/6] doc/qat: clarify build config options
Clarified documentation structure between compressedev, cryptodev and common build parts.
Clarified build configuration options.
Added Testing section.
Fixed typos and made some cosmetic improvements.
v3 changes
- squashed some patches
- added more text to remaining commit msgs
- fixed underline line length
- fixed typo: comp_qat should be qat
v2 changes
- split into patchset
- changed test path from build/build/test/test to build/app
- use make defconfig instead of make config T=xxx
- matched underline lengths to titles
Fiona Trahe (6):
doc/qat: add limitations to compressdev PMD
doc/qat: add information on how to test
doc/qat: fix typos and make cosmetic changes
doc/qat: add overview of doc sections
doc/qat: update build instructions for both PMDs
doc/qat: describe build config options
doc/guides/compressdevs/qat_comp.rst | 6 +-
doc/guides/cryptodevs/qat.rst | 195 +++++++++++++++++++++++++----------
2 files changed, 143 insertions(+), 58 deletions(-)
--
2.13.6
Series-acked-by: tomaszx.jozwiak@intel.com
On 8/10/2018 7:40 PM, Fiona Trahe wrote: > Clarified documentation structure between > compressedev, cryptodev and common build parts. > Clarified build configuration options. > Added Testing section. > Fixed typos and made some cosmetic improvements. > > > v3 changes > - squashed some patches > - added more text to remaining commit msgs > - fixed underline line length > - fixed typo: comp_qat should be qat > > v2 changes > - split into patchset > - changed test path from build/build/test/test to build/app > - use make defconfig instead of make config T=xxx > - matched underline lengths to titles > > Fiona Trahe (6): > doc/qat: add limitations to compressdev PMD > doc/qat: add information on how to test > doc/qat: fix typos and make cosmetic changes > doc/qat: add overview of doc sections > doc/qat: update build instructions for both PMDs > doc/qat: describe build config options > > doc/guides/compressdevs/qat_comp.rst | 6 +- > doc/guides/cryptodevs/qat.rst | 195 +++++++++++++++++++++++++---------- > 2 files changed, 143 insertions(+), 58 deletions(-) > > Patchset applied to dpdk-next-crypto. Subject for "doc/qat: fix typos and make cosmetic changes" changed to "doc/qat: correct typo and make cosmetic changes" to avoid git log error. Thanks, Akhil
23/08/2018 13:12, Akhil Goyal: > Patchset applied to dpdk-next-crypto. > > Subject for "doc/qat: fix typos and make cosmetic changes" changed to "doc/qat: correct typo and make cosmetic changes" > > to avoid git log error. Which error? Lack of Fixes tag? As a committer, you must be sure the Fixes tags and Cc: stable@dpdk.org are all set. It is mandatory to know what should be backported and where. Even typos should be backported.
Hi Thomas, On 8/23/2018 4:54 PM, Thomas Monjalon wrote: > 23/08/2018 13:12, Akhil Goyal: >> Patchset applied to dpdk-next-crypto. >> >> Subject for "doc/qat: fix typos and make cosmetic changes" changed to "doc/qat: correct typo and make cosmetic changes" >> >> to avoid git log error. > Which error? Lack of Fixes tag? > As a committer, you must be sure the Fixes tags and Cc: stable@dpdk.org > are all set. It is mandatory to know what should be backported and where. > Even typos should be backported. > > Fiona clarified that this patch is not required for back porting. Regards, Akhil
23/08/2018 13:28, Akhil Goyal: > Hi Thomas, > > On 8/23/2018 4:54 PM, Thomas Monjalon wrote: > > > 23/08/2018 13:12, Akhil Goyal: > >> Patchset applied to dpdk-next-crypto. > >> > >> Subject for "doc/qat: fix typos and make cosmetic changes" changed to "doc/qat: correct typo and make cosmetic changes" > >> > >> to avoid git log error. > > Which error? Lack of Fixes tag? > > As a committer, you must be sure the Fixes tags and Cc: stable@dpdk.org > > are all set. It is mandatory to know what should be backported and where. > > Even typos should be backported. > > > > > Fiona clarified that this patch is not required for back porting. It will make future backporting of doc fixes harder. That's a good example to discuss. OK to keep it as is, and will discuss it with maintainers of stable branches during the Dublin event, in order to make the policies clear.