diff mbox

[dpdk-dev] ip_pipeline: fix cpu socket-id error

Message ID 1453287677-221142-1-git-send-email-jasvinder.singh@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Jasvinder Singh Jan. 20, 2016, 11:01 a.m. UTC 
  This patch fixes the socket-id error in ip_pipeline sample
application running over uni-processor systems.

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/ip_pipeline/init.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

Comments

Stephen Hemminger Jan. 20, 2016, 6:32 p.m. UTC | #1 
On Wed, 20 Jan 2016 11:01:17 +0000
Jasvinder Singh <jasvinder.singh@intel.com> wrote:

> +static inline int
> +app_get_cpu_socket_id(uint32_t pmd_id)
> +{
> +	int status = rte_eth_dev_socket_id(pmd_id);
> +
> +	if (status == -1)
> +		return 0;
> +
> +	return status;
> +

Why not:
    return (status != SOCKET_ID_ANY) ? status : 0;
diff mbox

Patch

diff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c
index 186ca03..86aa378 100644
--- a/examples/ip_pipeline/init.c
+++ b/examples/ip_pipeline/init.c
@@ -835,6 +835,17 @@  app_init_link_frag_ras(struct app_params *app)
 	}
 }
 
+static inline int
+app_get_cpu_socket_id(uint32_t pmd_id)
+{
+	int status = rte_eth_dev_socket_id(pmd_id);
+
+	if (status == -1)
+		return 0;
+
+	return status;
+}
+
 static void
 app_init_link(struct app_params *app)
 {
@@ -890,7 +901,7 @@  app_init_link(struct app_params *app)
 				p_link->pmd_id,
 				rxq_queue_id,
 				p_rxq->size,
-				rte_eth_dev_socket_id(p_link->pmd_id),
+				app_get_cpu_socket_id(p_link->pmd_id),
 				&p_rxq->conf,
 				app->mempool[p_rxq->mempool_id]);
 			if (status < 0)
@@ -917,7 +928,7 @@  app_init_link(struct app_params *app)
 				p_link->pmd_id,
 				txq_queue_id,
 				p_txq->size,
-				rte_eth_dev_socket_id(p_link->pmd_id),
+				app_get_cpu_socket_id(p_link->pmd_id),
 				&p_txq->conf);
 			if (status < 0)
 				rte_panic("%s (%" PRIu32 "): "
@@ -989,7 +1000,7 @@  app_init_tm(struct app_params *app)
 		/* TM */
 		p_tm->sched_port_params.name = p_tm->name;
 		p_tm->sched_port_params.socket =
-			rte_eth_dev_socket_id(p_link->pmd_id);
+			app_get_cpu_socket_id(p_link->pmd_id);
 		p_tm->sched_port_params.rate =
 			(uint64_t) link_eth_params.link_speed * 1000 * 1000 / 8;