Message ID | 1449755601-25670-1-git-send-email-bernard.iremonger@intel.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 6641A8E5F; Thu, 10 Dec 2015 14:53:29 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 574958E58 for <dev@dpdk.org>; Thu, 10 Dec 2015 14:53:28 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 10 Dec 2015 05:53:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,408,1444719600"; d="scan'208";a="870877891" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga002.fm.intel.com with ESMTP; 10 Dec 2015 05:53:25 -0800 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id tBADrO6V031790; Thu, 10 Dec 2015 13:53:24 GMT Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id tBADrOIc025714; Thu, 10 Dec 2015 13:53:24 GMT Received: (from bairemon@localhost) by sivswdev01.ir.intel.com with id tBADrORH025710; Thu, 10 Dec 2015 13:53:24 GMT From: Bernard Iremonger <bernard.iremonger@intel.com> To: dev@dpdk.org Date: Thu, 10 Dec 2015 13:53:21 +0000 Message-Id: <1449755601-25670-1-git-send-email-bernard.iremonger@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1449749971-5422-1-git-send-email-bernard.iremonger@intel.com> References: <1449749971-5422-1-git-send-email-bernard.iremonger@intel.com> Subject: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of hugepages needed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Iremonger, Bernard
Dec. 10, 2015, 1:53 p.m. UTC
Change MAX_QUEUES from 512 to 128 to reduce the number of hugepages required by the vhost-switch program. Changes in v2: remove comment added before #define MAX_QUEUES in v1 patch. Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> --- examples/vhost/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Thursday, December 10, 2015 1:53 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of hugepages needed > > Change MAX_QUEUES from 512 to 128 to reduce the number of hugepages > required by the vhost-switch program. > > Changes in v2: > remove comment added before #define MAX_QUEUES in v1 patch. > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> Wasn't it increased a while ago, because someone complained that 128 queues might not be enough on FVL? From git log I can see that it was first increased from 128 to 256, then from 256 to 512. The reason mentioned - HW that has bigger number of queues. Isn't it not the case anymore? If yes, why? BTW, shouldn't it be then at least: +#ifndef MAX_QUEUES +#define MAX_QUEUES 128 +#endif So people can just do -D MAX_QUEUES=X at build time if they like(need) to. Konstantin > --- > examples/vhost/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index b30f1bd..5ce5926 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -1,7 +1,7 @@ > /*- > * BSD LICENSE > * > - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > + * Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > * All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > @@ -53,7 +53,7 @@ > > #include "main.h" > > -#define MAX_QUEUES 512 > +#define MAX_QUEUES 128 > > /* the maximum number of external ports supported */ > #define MAX_SUP_PORTS 1 > -- > 2.6.3
Hi Konstantin, <snip> > > Subject: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of > > hugepages needed > > > > Change MAX_QUEUES from 512 to 128 to reduce the number of hugepages > > required by the vhost-switch program. > > > > Changes in v2: > > remove comment added before #define MAX_QUEUES in v1 patch. > > > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > > Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> > > > Wasn't it increased a while ago, because someone complained that > 128 queues might not be enough on FVL? > From git log I can see that it was first increased from 128 to 256, then from > 256 to 512. > The reason mentioned - HW that has bigger number of queues. > Isn't it not the case anymore? > If yes, why? > > BTW, shouldn't it be then at least: > > +#ifndef MAX_QUEUES > +#define MAX_QUEUES 128 > +#endif > > So people can just do -D MAX_QUEUES=X at build time if they like(need) to. > Konstantin > <snip> I will add #ifndef MAX_QUEUES and #endif. Regards, Bernard.
On 12/10/2015 04:50 PM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger >> Sent: Thursday, December 10, 2015 1:53 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of hugepages needed >> >> Change MAX_QUEUES from 512 to 128 to reduce the number of hugepages >> required by the vhost-switch program. >> >> Changes in v2: >> remove comment added before #define MAX_QUEUES in v1 patch. >> >> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> >> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> > > > Wasn't it increased a while ago, because someone complained that > 128 queues might not be enough on FVL? > From git log I can see that it was first increased from 128 to 256, > then from 256 to 512. > The reason mentioned - HW that has bigger number of queues. > Isn't it not the case anymore? > If yes, why? > > BTW, shouldn't it be then at least: > > +#ifndef MAX_QUEUES > +#define MAX_QUEUES 128 > +#endif > > So people can just do -D MAX_QUEUES=X at build time if they like(need) to. Being subject to constant changes back and forth suggests this really should be a runtime tunable rather than build time constant. - Panu -
diff --git a/examples/vhost/main.c b/examples/vhost/main.c index b30f1bd..5ce5926 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/main.c @@ -1,7 +1,7 @@ /*- * BSD LICENSE * - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. + * Copyright(c) 2010-2015 Intel Corporation. All rights reserved. * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -53,7 +53,7 @@ #include "main.h" -#define MAX_QUEUES 512 +#define MAX_QUEUES 128 /* the maximum number of external ports supported */ #define MAX_SUP_PORTS 1