net/ice: fix VSI array out of bounds
Checks
Commit Message
In the loop, when the index of array "vsi->rss_key" is equal
to "vsi->rss_key_size", the array will be out of bounds.
Fixes: 50370662b727 ("net/ice: support device and queue ops")
Signed-off-by: Wang Jie <jie1x.wang@intel.com>
---
drivers/net/ice/ice_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Wang, Jie1X <jie1x.wang@intel.com>
> Sent: Wednesday, May 12, 2021 10:27 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, Jie1X <jie1x.wang@intel.com>
> Subject: [PATCH] net/ice: fix VSI array out of bounds
>
> In the loop, when the index of array "vsi->rss_key" is equal to
> "vsi->rss_key_size", the array will be out of bounds.
>
> Fixes: 50370662b727 ("net/ice: support device and queue ops")
Cc: stable@dpdk.org
>
> Signed-off-by: Wang Jie <jie1x.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -3034,7 +3034,7 @@ static int ice_init_rss(struct ice_pf *pf)
/* configure RSS key */
if (!rss_conf->rss_key) {
/* Calculate the default hash key */
- for (i = 0; i <= vsi->rss_key_size; i++)
+ for (i = 0; i < vsi->rss_key_size; i++)
vsi->rss_key[i] = (uint8_t)rte_rand();
} else {
rte_memcpy(vsi->rss_key, rss_conf->rss_key,