diff mbox series

[v13,08/10] app/testpmd: fix headers inclusion

Message ID	1620241931-28435-9-git-send-email-jizh@linux.microsoft.com (mailing list archive)
State	Superseded, archived
Delegated to:	Andrew Rybchenko
Headers	From: Jie Zhou <jizh@linux.microsoft.com> To: dev@dpdk.org Cc: dmitry.kozliuk@gmail.com, xiaoyun.li@intel.com, roretzla@microsoft.com, talshn@nvidia.com, pallavi.kadam@intel.com, thomas@monjalon.net, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, stable@dpdk.org Date: Wed, 5 May 2021 12:12:09 -0700 Message-Id: <1620241931-28435-9-git-send-email-jizh@linux.microsoft.com> In-Reply-To: <1620241931-28435-1-git-send-email-jizh@linux.microsoft.com> References: <1620236174-10676-1-git-send-email-jizh@linux.microsoft.com> <1620241931-28435-1-git-send-email-jizh@linux.microsoft.com> Subject: [dpdk-dev] [PATCH v13 08/10] app/testpmd: fix headers inclusion Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	app/testpmd: enable testpmd on Windows \| [v13,00/10] app/testpmd: enable testpmd on Windows [v13,01/10] lib: build libraries that testpmd depends on [v13,02/10] eal/windows: add necessary macros [v13,03/10] eal/windows: add device event stubs [v13,04/10] eal/Windows: add clock_gettime on Windows [v13,05/10] app/testpmd: resolve name collisions [v13,06/10] app/testpmd: fix parse_fec_mode return type name [v13,07/10] app/testpmd: replace POSIX specific code [v13,08/10] app/testpmd: fix headers inclusion [v13,09/10] app/testpmd: fix unused function warnings [v13,10/10] app/testpmd: enable building testpmd on Windows

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Jie Zhou May 5, 2021, 7:12 p.m. UTC

  - Include rte_os_shim.h in testpmd.h
- Remove redundant headers

Signed-off-by: Jie Zhou <jizh@microsoft.com>
Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
Acked-by: Tal Shnaiderman <talshn@nvidia.com>
---
 app/test-pmd/cmdline.c      | 3 ---
 app/test-pmd/cmdline_flow.c | 2 --
 app/test-pmd/parameters.c   | 1 -
 app/test-pmd/testpmd.h      | 1 +
 4 files changed, 1 insertion(+), 6 deletions(-)

Comments

Dmitry Kozlyuk June 20, 2021, 11:30 p.m. UTC | #1

2021-05-05 12:12 (UTC-0700), Jie Zhou:
> - Include rte_os_shim.h in testpmd.h
> - Remove redundant headers
> 
> Signed-off-by: Jie Zhou <jizh@microsoft.com>
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> Acked-by: Tal Shnaiderman <talshn@nvidia.com>

It would be logical to merge this patch with the previous one.

Jie Zhou June 23, 2021, 8:58 p.m. UTC | #2

On Mon, Jun 21, 2021 at 02:30:48AM +0300, Dmitry Kozlyuk wrote:
> 2021-05-05 12:12 (UTC-0700), Jie Zhou:
> > - Include rte_os_shim.h in testpmd.h
> > - Remove redundant headers
> > 
> > Signed-off-by: Jie Zhou <jizh@microsoft.com>
> > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> > Acked-by: Tal Shnaiderman <talshn@nvidia.com>
> 
> It would be logical to merge this patch with the previous one.

Will merge 08 and 07 into one in V14.

diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 10b0f6239..bfd2fb924 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -10,9 +10,6 @@ 
 #include <string.h>
 #include <unistd.h>
 #include <inttypes.h>
-#include <sys/socket.h>
-#include <netinet/in.h>
-
 #include <sys/queue.h>
 
 #include <rte_common.h>
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 888b9179b..a3cd4773a 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -10,8 +10,6 @@ 
 #include <errno.h>
 #include <ctype.h>
 #include <string.h>
-#include <arpa/inet.h>
-#include <sys/socket.h>
 
 #include <rte_string_fns.h>
 #include <rte_common.h>
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 4c3cbbac3..5e69d2aa8 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -19,7 +19,6 @@ 
 #include <stdint.h>
 #include <unistd.h>
 #include <inttypes.h>
-#include <arpa/inet.h>
 
 #include <rte_common.h>
 #include <rte_byteorder.h>
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 04b49a9c0..d61a055bd 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -11,6 +11,7 @@ 
 #include <rte_bus_pci.h>
 #include <rte_gro.h>
 #include <rte_gso.h>
+#include <rte_os_shim.h>
 #include <cmdline.h>
 #include <sys/queue.h>