app/bbdev: fix wrong variable
Checks
Commit Message
This patch corrected misused variable.
Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
app/test-bbdev/test_bbdev_perf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Friday, April 23, 2021 12:43 AM
>
> This patch corrected misused variable.
>
> Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
> Cc: stable@dpdk.org
>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Thanks
Acked-by: Nicolas Chautru <Nicolas.chautru@intel.com>
> ---
> app/test-bbdev/test_bbdev_perf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-
> bbdev/test_bbdev_perf.c
> index 45b85b9..b8bf512 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -372,14 +372,14 @@ check_dev_cap(const struct rte_bbdev_info
> *dev_info)
> if (nb_harq_inputs > cap->num_buffers_hard_out) {
> printf(
> "Too many HARQ inputs defined: %u,
> max: %u\n",
> - nb_hard_outputs,
> + nb_harq_inputs,
> cap->num_buffers_hard_out);
> return TEST_FAILED;
> }
> if (nb_harq_outputs > cap->num_buffers_hard_out)
> {
> printf(
> "Too many HARQ outputs defined:
> %u, max: %u\n",
> - nb_hard_outputs,
> + nb_harq_outputs,
> cap->num_buffers_hard_out);
> return TEST_FAILED;
> }
> --
> 2.7.4
Chautru, Nicolas:
> From: Min Hu (Connor) <humin29@huawei.com>
> >
> > This patch corrected misused variable.
> >
> > Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>
> Thanks
>
> Acked-by: Nicolas Chautru <Nicolas.chautru@intel.com>
It is not enough. The commit log must described what was broken in which case.
在 2021/4/26 0:30, Thomas Monjalon 写道:
> Chautru, Nicolas:
>> From: Min Hu (Connor) <humin29@huawei.com>
>>>
>>> This patch corrected misused variable.
>>>
>>> Fixes: d819c08327f3 ("app/bbdev: update for 5GNR")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>
>> Thanks
>>
>> Acked-by: Nicolas Chautru <Nicolas.chautru@intel.com>
>
> It is not enough. The commit log must described what was broken in which case.
>
Hi, fixed in v2, thanks.
>
@@ -372,14 +372,14 @@ check_dev_cap(const struct rte_bbdev_info *dev_info)
if (nb_harq_inputs > cap->num_buffers_hard_out) {
printf(
"Too many HARQ inputs defined: %u, max: %u\n",
- nb_hard_outputs,
+ nb_harq_inputs,
cap->num_buffers_hard_out);
return TEST_FAILED;
}
if (nb_harq_outputs > cap->num_buffers_hard_out) {
printf(
"Too many HARQ outputs defined: %u, max: %u\n",
- nb_hard_outputs,
+ nb_harq_outputs,
cap->num_buffers_hard_out);
return TEST_FAILED;
}