event/dlb: fix bugs due to accessing uninitialized variables
Checks
Commit Message
This patch updates the PMD to initialize response fields
prior to calling into the PF layer.
Fixes the following coverity issues:
Fixes: eb14a3421afd ("event/dlb: add eventdev start")
Coverity issue: 366205
Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
Coverity issue: 366202
Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
Coverity issue: 366200
Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
drivers/event/dlb/dlb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
On Wed, Feb 3, 2021 at 11:42 PM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
> This patch updates the PMD to initialize response fields
> prior to calling into the PF layer.
>
> Fixes the following coverity issues:
>
> Fixes: eb14a3421afd ("event/dlb: add eventdev start")
> Coverity issue: 366205
>
> Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
> Coverity issue: 366202
>
> Fixes: f0073621940c ("event/dlb: add eventdev stop and close")
> Coverity issue: 366200
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
Please increment the patch version when you send a new version.
Fixed ./devtools/check-git-log.sh issues and Applied to
dpdk-next-eventdev/for-main for rc3. Thanks.
@@ -1847,7 +1847,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
{
struct dlb_hw_dev *handle = &dlb->qm_instance;
struct dlb_create_dir_queue_args cfg;
- struct dlb_cmd_response response;
+ struct dlb_cmd_response response = {0};
int32_t ret;
cfg.response = (uintptr_t)&response;
@@ -3573,7 +3573,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
{
struct dlb_hw_dev *handle = &dlb->qm_instance;
struct dlb_get_ldb_queue_depth_args cfg;
- struct dlb_cmd_response response;
+ struct dlb_cmd_response response = {0};
int ret;
cfg.queue_id = queue->qm_queue.id;
@@ -3595,7 +3595,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
{
struct dlb_hw_dev *handle = &dlb->qm_instance;
struct dlb_get_dir_queue_depth_args cfg;
- struct dlb_cmd_response response;
+ struct dlb_cmd_response response = {0};
int ret;
cfg.queue_id = queue->qm_queue.id;