net/octeontx: fix max Rx packet length corruption

Message ID 20210126085244.1617026-1-skori@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series net/octeontx: fix max Rx packet length corruption |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-testing warning Testing issues

Commit Message

Sunil Kumar Kori Jan. 26, 2021, 8:52 a.m. UTC
  From: Sunil Kumar Kori <skori@marvell.com>

Maximum Rx packet length is getting updated twice which
corrupts actual value.

Fixes: 3151e6a687a3 ("net/octeontx: support MTU")
Cc: stable@dpdk.org

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
 drivers/net/octeontx/octeontx_ethdev.c | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Harman Kalra Jan. 28, 2021, 7:16 p.m. UTC | #1
On Tue, Jan 26, 2021 at 02:22:43PM +0530, skori@marvell.com wrote:
> From: Sunil Kumar Kori <skori@marvell.com>
> 
> Maximum Rx packet length is getting updated twice which
> corrupts actual value.
> 
> Fixes: 3151e6a687a3 ("net/octeontx: support MTU")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>

Thanks for fixing.

Acked-by: Harman Kalra <hkalra@marvell.com>

> ---
>  drivers/net/octeontx/octeontx_ethdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
> index 81779885d..5836dbe09 100644
> --- a/drivers/net/octeontx/octeontx_ethdev.c
> +++ b/drivers/net/octeontx/octeontx_ethdev.c
> @@ -867,7 +867,6 @@ octeontx_dev_info(struct rte_eth_dev *dev,
>  
>  	dev_info->max_mac_addrs =
>  				octeontx_bgx_port_mac_entries_get(nic->port_id);
> -	dev_info->max_rx_pktlen = PKI_MAX_PKTLEN;
>  	dev_info->max_rx_queues = 1;
>  	dev_info->max_tx_queues = PKO_MAX_NUM_DQ;
>  	dev_info->min_rx_bufsize = 0;
> -- 
> 2.25.1
>
  
Jerin Jacob Feb. 4, 2021, 11 a.m. UTC | #2
On Fri, Jan 29, 2021 at 12:46 AM Harman Kalra <hkalra@marvell.com> wrote:
>
> On Tue, Jan 26, 2021 at 02:22:43PM +0530, skori@marvell.com wrote:
> > From: Sunil Kumar Kori <skori@marvell.com>
> >
> > Maximum Rx packet length is getting updated twice which
> > corrupts actual value.
> >
> > Fixes: 3151e6a687a3 ("net/octeontx: support MTU")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>
> Thanks for fixing.
>
> Acked-by: Harman Kalra <hkalra@marvell.com>

Applied to dpdk-next-net-mrvl/for-main. Thanks



>
> > ---
> >  drivers/net/octeontx/octeontx_ethdev.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
> > index 81779885d..5836dbe09 100644
> > --- a/drivers/net/octeontx/octeontx_ethdev.c
> > +++ b/drivers/net/octeontx/octeontx_ethdev.c
> > @@ -867,7 +867,6 @@ octeontx_dev_info(struct rte_eth_dev *dev,
> >
> >       dev_info->max_mac_addrs =
> >                               octeontx_bgx_port_mac_entries_get(nic->port_id);
> > -     dev_info->max_rx_pktlen = PKI_MAX_PKTLEN;
> >       dev_info->max_rx_queues = 1;
> >       dev_info->max_tx_queues = PKO_MAX_NUM_DQ;
> >       dev_info->min_rx_bufsize = 0;
> > --
> > 2.25.1
> >
  

Patch

diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
index 81779885d..5836dbe09 100644
--- a/drivers/net/octeontx/octeontx_ethdev.c
+++ b/drivers/net/octeontx/octeontx_ethdev.c
@@ -867,7 +867,6 @@  octeontx_dev_info(struct rte_eth_dev *dev,
 
 	dev_info->max_mac_addrs =
 				octeontx_bgx_port_mac_entries_get(nic->port_id);
-	dev_info->max_rx_pktlen = PKI_MAX_PKTLEN;
 	dev_info->max_rx_queues = 1;
 	dev_info->max_tx_queues = PKO_MAX_NUM_DQ;
 	dev_info->min_rx_bufsize = 0;